Add comment to clarify handling of NextValueExpr return type in insert_select_planner

pull/7920/head
Mehmet Yilmaz 2025-03-07 15:42:19 +00:00
parent bb4f2dec3d
commit 693eb29cbe
1 changed files with 14 additions and 0 deletions

View File

@ -1640,6 +1640,20 @@ process_entry_pair(TargetEntry *insertEntry, TargetEntry *selectEntry,
Oid sourceType = exprType((Node *) selectEntry->expr);
Oid targetType = attr->atttypid;
/*
* If the select expression is a NextValueExpr, use its actual return type.
*
* NextValueExpr represents a call to the nextval() function, which is used to
* obtain the next value from a sequencecommonly for populating auto-increment
* columns. In many cases, nextval() returns an INT8 (bigint), but the actual
* return type may differ depending on database configuration or custom implementations.
*
* Since the target column might have a different type (e.g., INT4), we need to
* obtain the real return type of nextval() to ensure that any type coercion is applied
* correctly. This is done by calling GetNextvalReturnTypeCatalog(), which looks up the
* function in the catalog and returns its return type. The effectiveCastFromType is then
* set to this value, ensuring that subsequent comparisons and casts use the correct type.
*/
if (IsA(selectEntry->expr, NextValueExpr))
{
Oid nextvalType = GetNextvalReturnTypeCatalog();