external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing volatile qualifier. 

Variables being modified in the PG_TRY block and read in the PG_CATCH
block should be qualified with volatile.

The variable waitEventSet is modified in the PG_TRY block (line 1085)
and read in the PG_CATCH block (line 1095).

The variable relation is modified in the PG_TRY block (line 500) and
read in the PG_CATCH block (line 515).

Co-authored-by: Hong Yi <zouzou0208@gmail.com>
pull/7570/head
Xing Guo 2024-04-02 21:38:36 +08:00
parent 3929a5b2a6
commit 6a8f26cae6
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/distributed/connection/remote_commands.c
View File

@ -883,7 +883,7 @@ WaitForAllConnections(List *connectionList, bool raiseInterrupts)
palloc(totalConnectionCount * sizeof(MultiConnection *)); palloc(totalConnectionCount * sizeof(MultiConnection *));
WaitEvent *events = palloc(totalConnectionCount * sizeof(WaitEvent)); WaitEvent *events = palloc(totalConnectionCount * sizeof(WaitEvent));
bool *connectionReady = palloc(totalConnectionCount * sizeof(bool)); bool *connectionReady = palloc(totalConnectionCount * sizeof(bool));
WaitEventSet *waitEventSet = NULL; WaitEventSet *volatile waitEventSet = NULL;
/* convert connection list to an array such that we can move items around */ /* convert connection list to an array such that we can move items around */
MultiConnection *connectionItem = NULL; MultiConnection *connectionItem = NULL;

4
src/backend/distributed/utils/citus_depended_object.c
View File

@ -465,8 +465,8 @@ static bool
AnyObjectViolatesOwnership(DropStmt *dropStmt) AnyObjectViolatesOwnership(DropStmt *dropStmt)
{ {
bool hasOwnershipViolation = false; bool hasOwnershipViolation = false;
volatile ObjectAddress objectAddress = { 0 }; ObjectAddress objectAddress = { 0 };
Relation relation = NULL; volatile Relation relation = NULL;
ObjectType objectType = dropStmt->removeType; ObjectType objectType = dropStmt->removeType;
bool missingOk = dropStmt->missing_ok; bool missingOk = dropStmt->missing_ok;