From 6c3f58afaa6994819a5e1eb5a66512448c3b9e3f Mon Sep 17 00:00:00 2001 From: Onder Kalaci Date: Thu, 1 Dec 2022 15:05:27 +0100 Subject: [PATCH] remove useless checks --- .../distributed/metadata/node_metadata.c | 25 +++---------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/src/backend/distributed/metadata/node_metadata.c b/src/backend/distributed/metadata/node_metadata.c index 37da61904..085cf12aa 100644 --- a/src/backend/distributed/metadata/node_metadata.c +++ b/src/backend/distributed/metadata/node_metadata.c @@ -829,26 +829,7 @@ SyncDistributedObjectsCommandList(WorkerNode *workerNode) static void SyncDistributedObjectsToNodeList(List *workerNodeList) { - List *workerNodesToSync = NIL; - WorkerNode *workerNode = NULL; - foreach_ptr(workerNode, workerNodeList) - { - if (NodeIsCoordinator(workerNode)) - { - /* coordinator has all the objects */ - continue; - } - - if (!NodeIsPrimary(workerNode)) - { - /* secondary nodes gets the objects from their primaries via replication */ - continue; - } - - workerNodesToSync = lappend(workerNodesToSync, workerNode); - } - - if (workerNodesToSync == NIL) + if (workerNodeList == NIL) { return; } @@ -857,12 +838,12 @@ SyncDistributedObjectsToNodeList(List *workerNodeList) Assert(ShouldPropagate()); - List *commandList = SyncDistributedObjectsCommandList(workerNode); + List *commandList = SyncDistributedObjectsCommandList(linitial(workerNodeList)); /* send commands to new workers, the current user should be a superuser */ Assert(superuser()); SendMetadataCommandListToWorkerListInCoordinatedTransaction( - workerNodesToSync, + workerNodeList, CurrentUserName(), commandList); }