From 6c5d263b7a57b542613686f3e9e7fc4a7de53a04 Mon Sep 17 00:00:00 2001 From: Marco Slot Date: Mon, 15 Mar 2021 09:34:02 +0100 Subject: [PATCH] Remove unnecessary AtEOXact_Files call --- .../transaction/transaction_management.c | 22 +------------------ 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/src/backend/distributed/transaction/transaction_management.c b/src/backend/distributed/transaction/transaction_management.c index 7bb16e441..93d6351b1 100644 --- a/src/backend/distributed/transaction/transaction_management.c +++ b/src/backend/distributed/transaction/transaction_management.c @@ -318,28 +318,8 @@ CoordinatedTransactionCallback(XactEvent event, void *arg) /* stop propagating notices from workers, we know the query is failed */ DisableWorkerMessagePropagation(); - /* - * FIXME: Add warning for the COORD_TRANS_COMMITTED case. That - * can be reached if this backend fails after the - * XACT_EVENT_PRE_COMMIT state. - */ + RemoveIntermediateResultsDirectory(); - /* - * Call other parts of citus that need to integrate into - * transaction management. Do so before doing other work, so the - * callbacks still can perform work if needed. - */ - { - /* - * On Windows it's not possible to delete a file before you've closed all - * handles to it (rmdir will return success but not take effect). Since - * we're in an ABORT handler it's very likely that not all handles have - * been closed; force them closed here before running - * RemoveIntermediateResultsDirectory. - */ - AtEOXact_Files(false); - RemoveIntermediateResultsDirectory(); - } ResetShardPlacementTransactionState(); /* handles both already prepared and open transactions */