From 6d4f70363e972c918e5a4bced7fa836fb3a5c7d2 Mon Sep 17 00:00:00 2001 From: Burak Velioglu Date: Thu, 27 Jan 2022 10:54:24 +0300 Subject: [PATCH] Address reviews --- src/backend/distributed/commands/sequence.c | 4 ++-- src/backend/distributed/metadata/dependency.c | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/backend/distributed/commands/sequence.c b/src/backend/distributed/commands/sequence.c index 3a1e949f3..674ced9f5 100644 --- a/src/backend/distributed/commands/sequence.c +++ b/src/backend/distributed/commands/sequence.c @@ -689,8 +689,8 @@ GenerateBackupNameForSequenceCollision(const ObjectAddress *address) strncpy_s(newName + baseLength, NAMEDATALEN - baseLength, suffix, suffixLength); - Oid typeOid = get_relname_relid(newName, schemaId); - if (typeOid == InvalidOid) + Oid newRelationId = get_relname_relid(newName, schemaId); + if (newRelationId == InvalidOid) { return newName; } diff --git a/src/backend/distributed/metadata/dependency.c b/src/backend/distributed/metadata/dependency.c index 0a3236a8a..820cb848f 100644 --- a/src/backend/distributed/metadata/dependency.c +++ b/src/backend/distributed/metadata/dependency.c @@ -706,7 +706,6 @@ SupportedDependencyByCitus(const ObjectAddress *address) /* * IsTableOwnedByExtension returns whether the table with the given relation ID is * owned by an extension. - * TODO: Check what if the extension is not distributed? */ bool IsTableOwnedByExtension(Oid relationId)