From 711aec80fad7bf27d5763911c3dc8afdf59758a5 Mon Sep 17 00:00:00 2001 From: Karina <55838532+Green-Chan@users.noreply.github.com> Date: Fri, 7 Feb 2025 17:29:13 +0300 Subject: [PATCH] Fix system_queries test to actually test the problem (#7613) The test added in #7604 doesn't reach the `HasRangeTableRef` function and thus doesn't test what it should. Co-authored-by: Karina Litskevich --- src/test/regress/expected/system_queries.out | 3 +++ src/test/regress/sql/system_queries.sql | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/test/regress/expected/system_queries.out b/src/test/regress/expected/system_queries.out index cd2aef4d2..174f4cc10 100644 --- a/src/test/regress/expected/system_queries.out +++ b/src/test/regress/expected/system_queries.out @@ -1,3 +1,5 @@ +BEGIN; +SET LOCAL citus.show_shards_for_app_name_prefixes = ''; -- The following query retrieves the foreign key constraints of the table "pg_dist_background_job" -- along with their details. This modification includes a fix for a null pointer exception that occurred -- in the "HasRangeTableRef" method of "worker_shard_visibility". The issue was resolved with PR #7604. @@ -31,3 +33,4 @@ order by pg_dist_background_task_depend_job_id_fkey | job_id | pg_dist_background_job | pg_catalog (2 rows) +END; diff --git a/src/test/regress/sql/system_queries.sql b/src/test/regress/sql/system_queries.sql index 1e1d86876..d43d20d53 100644 --- a/src/test/regress/sql/system_queries.sql +++ b/src/test/regress/sql/system_queries.sql @@ -1,3 +1,5 @@ +BEGIN; +SET LOCAL citus.show_shards_for_app_name_prefixes = ''; -- The following query retrieves the foreign key constraints of the table "pg_dist_background_job" -- along with their details. This modification includes a fix for a null pointer exception that occurred -- in the "HasRangeTableRef" method of "worker_shard_visibility". The issue was resolved with PR #7604. @@ -25,3 +27,4 @@ where and ns.nspname='pg_catalog' order by fns.nspname, fc.relname, a.attnum; +END;