From 712d15dc20fc79742e962b2b66e285ffa3188452 Mon Sep 17 00:00:00 2001
From: Jodi-Ann Francis <53411733+francisjodi@users.noreply.github.com>
Date: Wed, 30 Aug 2023 15:09:59 -0400
Subject: [PATCH] Review changes

---
 .../distributed/deparser/deparse_role_stmts.c | 32 ++++++-------------
 src/test/regress/sql/pg16.sql                 |  1 -
 2 files changed, 10 insertions(+), 23 deletions(-)

diff --git a/src/backend/distributed/deparser/deparse_role_stmts.c b/src/backend/distributed/deparser/deparse_role_stmts.c
index c0f336fd1..47b3c641d 100644
--- a/src/backend/distributed/deparser/deparse_role_stmts.c
+++ b/src/backend/distributed/deparser/deparse_role_stmts.c
@@ -409,28 +409,16 @@ AppendRevokeAdminOptionFor(StringInfo buf, GrantRoleStmt *stmt)
 		{
 			switch (opt->defname)
 			{
-				case "admin":
-					appendStringInfo(buf, "ADMIN OPTION FOR ");
-					opt_count++;
-					break;
-
-				case "inherit":
-					if (opt_count > 0)
-					{
-						appendStringInfo(buf, ", ");
-					}
-					appendStringInfo(buf, "INHERIT OPTION FOR ");
-					opt_count++;
-					break;
-
-				case "set":
-					if (opt_count > 0)
-					{
-						appendStringInfo(buf, ", ");
-					}
-					appendStringInfo(buf, "SET OPTION FOR ");
-					opt_count++;
-					break;
+				appendStringInfo(buf, "ADMIN OPTION FOR ");
+			}
+			else if (strcmp(opt->defname, "inherit") == 0);
+			{
+				appendStringInfo(buf, "INHERIT TRUE");
+				appendStringInfo(buf, "GRANT x TO y WITH INHERIT TRUE, SET TRUE;");
+			}
+			else if (strcmp(opt->defname, "set") == 0)
+			{
+				appendStringInfo(buf, "SET TRUE"); 
 			}
 		}
 	}
diff --git a/src/test/regress/sql/pg16.sql b/src/test/regress/sql/pg16.sql
index a078e76b9..d889c0723 100644
--- a/src/test/regress/sql/pg16.sql
+++ b/src/test/regress/sql/pg16.sql
@@ -594,4 +594,3 @@ RESET citus.grep_remote_commands;
 \set VERBOSITY terse
 SET client_min_messages TO ERROR;
 DROP SCHEMA pg16 CASCADE;
-