external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bump PG versions to 17.7, 16.11 (#8355) 

This PR bumps PG versions in CI tests and update some error messages in
statistics based on the following commits of latest PG minors:

https://github.com/postgres/postgres/commit/ab16418ee
https://github.com/postgres/postgres/commit/f225473cb
https://github.com/postgres/postgres/commit/f9b41f3e1

Sister PR https://github.com/citusdata/the-process/pull/181
main
Naisila Puka 2025-12-15 16:45:55 +03:00 committed by GitHub
parent 62a9190667
commit 7157f30d3e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.devcontainer/Dockerfile
View File

@ -73,7 +73,7 @@ USER citus
# build postgres versions separately for effective parrallelism and caching of already built versions when changing only certain versions # build postgres versions separately for effective parrallelism and caching of already built versions when changing only certain versions
FROM base AS pg16 FROM base AS pg16
RUN MAKEFLAGS="-j $(nproc)" pgenv build 16.10 RUN MAKEFLAGS="-j $(nproc)" pgenv build 16.11
RUN rm .pgenv/src/*.tar* RUN rm .pgenv/src/*.tar*
RUN make -C .pgenv/src/postgresql-*/ clean RUN make -C .pgenv/src/postgresql-*/ clean
RUN make -C .pgenv/src/postgresql-*/src/include install RUN make -C .pgenv/src/postgresql-*/src/include install
@ -85,7 +85,7 @@ RUN cp -r .pgenv/src .pgenv/pgsql-* .pgenv/config .pgenv-staging/
RUN rm .pgenv-staging/config/default.conf RUN rm .pgenv-staging/config/default.conf
FROM base AS pg17 FROM base AS pg17
RUN MAKEFLAGS="-j $(nproc)" pgenv build 17.6 RUN MAKEFLAGS="-j $(nproc)" pgenv build 17.7
RUN rm .pgenv/src/*.tar* RUN rm .pgenv/src/*.tar*
RUN make -C .pgenv/src/postgresql-*/ clean RUN make -C .pgenv/src/postgresql-*/ clean
RUN make -C .pgenv/src/postgresql-*/src/include install RUN make -C .pgenv/src/postgresql-*/src/include install
@ -203,7 +203,7 @@ COPY --chown=citus:citus .psqlrc .
RUN sudo chown --from=root:root citus:citus -R ~ RUN sudo chown --from=root:root citus:citus -R ~
# sets default pg version # sets default pg version
RUN pgenv switch 17.6 RUN pgenv switch 17.7
# make connecting to the coordinator easy # make connecting to the coordinator easy
ENV PGPORT=9700 ENV PGPORT=9700

10
.github/workflows/build_and_test.yml vendored
View File

@ -31,11 +31,11 @@ jobs:
pgupgrade_image_name: "ghcr.io/citusdata/pgupgradetester" pgupgrade_image_name: "ghcr.io/citusdata/pgupgradetester"
style_checker_image_name: "ghcr.io/citusdata/stylechecker" style_checker_image_name: "ghcr.io/citusdata/stylechecker"
style_checker_tools_version: "0.8.33" style_checker_tools_version: "0.8.33"
sql_snapshot_pg_version: "17.6" sql_snapshot_pg_version: "17.7"
image_suffix: "-v9555df2" image_suffix: "-vafdc5ac"
pg16_version: '{ "major": "16", "full": "16.10" }' pg16_version: '{ "major": "16", "full": "16.11" }'
pg17_version: '{ "major": "17", "full": "17.6" }' pg17_version: '{ "major": "17", "full": "17.7" }'
upgrade_pg_versions: "16.10-17.6" upgrade_pg_versions: "16.11-17.7"
steps: steps:
# Since GHA jobs need at least one step we use a noop step here. # Since GHA jobs need at least one step we use a noop step here.
- name: Set up parameters - name: Set up parameters

4
src/test/regress/expected/pg18_0.out
View File

@ -8,12 +8,12 @@ SELECT substring(:'server_version', '\d+')::int >= 18 AS server_version_ge_18
-- behavior is same among PG versions, error message differs -- behavior is same among PG versions, error message differs
-- relevant PG18 commit: 3eea4dc2c7, 38883916e -- relevant PG18 commit: 3eea4dc2c7, 38883916e
CREATE STATISTICS tst ON a FROM (VALUES (x)) AS foo; CREATE STATISTICS tst ON a FROM (VALUES (x)) AS foo;
ERROR: only a single relation is allowed in CREATE STATISTICS ERROR: CREATE STATISTICS only supports relation names in the FROM clause
CREATE FUNCTION tftest(int) returns table(a int, b int) as $$ CREATE FUNCTION tftest(int) returns table(a int, b int) as $$
SELECT $1, $1+i FROM generate_series(1,5) g(i); SELECT $1, $1+i FROM generate_series(1,5) g(i);
$$ LANGUAGE sql IMMUTABLE STRICT; $$ LANGUAGE sql IMMUTABLE STRICT;
CREATE STATISTICS alt_stat2 ON a FROM tftest(1); CREATE STATISTICS alt_stat2 ON a FROM tftest(1);
ERROR: only a single relation is allowed in CREATE STATISTICS ERROR: CREATE STATISTICS only supports relation names in the FROM clause
DROP FUNCTION tftest; DROP FUNCTION tftest;
\if :server_version_ge_18 \if :server_version_ge_18
\else \else

2
src/test/regress/expected/propagate_statistics.out
View File

@ -16,7 +16,7 @@ SELECT create_distributed_table('test_stats', 'a');
(1 row) (1 row)
CREATE STATISTICS pg_temp.s1 (dependencies) ON a, b FROM test_stats; CREATE STATISTICS pg_temp.s1 (dependencies) ON a, b FROM test_stats;
ERROR: "statistics object s1" has dependency on unsupported object "schema pg_temp_xxx" ERROR: "statistics object pg_temp_xxx.s1" has dependency on unsupported object "schema pg_temp_xxx"
CREATE STATISTICS s1 (dependencies) ON a, b FROM test_stats; CREATE STATISTICS s1 (dependencies) ON a, b FROM test_stats;
-- test for distributing an already existing statistics -- test for distributing an already existing statistics
CREATE TABLE "test'stats2" ( CREATE TABLE "test'stats2" (