From 6d79d251019314f4abd29ce8138cf4da10a51d6f Mon Sep 17 00:00:00 2001 From: Hadi Moshayedi Date: Mon, 6 Nov 2017 23:16:43 -0500 Subject: [PATCH] Fix a relcache reference leak in stats collection. In DistributedTablesSize() we didn't close the relations that had replication factor > 2. This caused relcache reference leaks, and warning messages like following in logs: WARNING: relcache reference leak: relation "researchers" not closed --- src/backend/distributed/utils/statistics_collection.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/backend/distributed/utils/statistics_collection.c b/src/backend/distributed/utils/statistics_collection.c index 246175aff..ce63c088b 100644 --- a/src/backend/distributed/utils/statistics_collection.c +++ b/src/backend/distributed/utils/statistics_collection.c @@ -397,6 +397,7 @@ DistributedTablesSize(List *distTableOids) if (PartitionMethod(relationId) == DISTRIBUTE_BY_HASH && !SingleReplicatedTable(relationId)) { + heap_close(relation, AccessShareLock); continue; }