From 78795251e14928d9498fe76d03a54ebea5119f1f Mon Sep 17 00:00:00 2001 From: Hanefi Onaldi Date: Thu, 17 Feb 2022 02:31:45 +0300 Subject: [PATCH] Revert "Improve CI checks for enterprise merges on master (#4981)" This reverts commit b649dffabddc99eb4d3b408edb46eabd9fcc2c0c. --- ci/README.md | 4 ++-- ci/check_enterprise_merge.sh | 8 -------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/ci/README.md b/ci/README.md index eef0fd4de..31fdb7e0e 100644 --- a/ci/README.md +++ b/ci/README.md @@ -156,9 +156,9 @@ git merge "community/$PR_BRANCH" familiar with the change. 5. You should rerun the `check-merge-to-enterprise` check on `community/$PR_BRANCH`. You can use re-run from failed option in circle CI. -6. You can now merge the PR on enterprise. Be sure to NOT use "squash and merge", +6. You can now merge the PR on community. Be sure to NOT use "squash and merge", but instead use the regular "merge commit" mode. -7. You can now merge the PR on community. Be sure to NOT use "squash and merge", +7. You can now merge the PR on enterprise. Be sure to NOT use "squash and merge", but instead use the regular "merge commit" mode. The subsequent PRs on community will be able to pass the diff --git a/ci/check_enterprise_merge.sh b/ci/check_enterprise_merge.sh index 040a5c224..097e1aed5 100755 --- a/ci/check_enterprise_merge.sh +++ b/ci/check_enterprise_merge.sh @@ -65,14 +65,6 @@ fi # undo partial merge git merge --abort -# If we have a conflict on enterprise merge on the master branch, we have a problem. -# Provide an error message to indicate that enterprise merge is needed. -if [[ $PR_BRANCH = master ]]; then - echo "ERROR: Master branch has merge conlicts with enterprise-master." - echo "Try re-running this job if you merged community PR before enterprise PR. Otherwise conflicts need to be resolved as a separate PR on enterprise." - exit 1 -fi - if ! git fetch enterprise "$PR_BRANCH" ; then echo "ERROR: enterprise/$PR_BRANCH was not found and community PR branch could not be merged into enterprise-master" exit 1