From 79dcb8014075f6a2e6867e0f8d39bb390e0ebc92 Mon Sep 17 00:00:00 2001
From: Sait Talha Nisanci <s.talhanisanci@gmail.com>
Date: Sat, 20 Jun 2020 20:55:59 +0300
Subject: [PATCH] Changelog: Test IS NORMALIZED for pg13

Tests for is_normalized and normalized ar eadded. One thing that seems
to be because of existent bug is that when we don't give the second
argument to normalize or is_normalized, which is optional, it crashes.
Because in the executor part, in the expression we don't have the
default argument.

Changelog entry in PG-13:
Add SQL functions NORMALIZE() to normalize Unicode strings, and IS NORMALIZED to check for normalization (Peter Eisentraut)

Commit on Postgres:
2991ac5fc9b3904ca4582be6d323497d7c3d17c9
---
 src/test/regress/expected/pg13.out | 82 +++++++++++++++++++++++++++++-
 src/test/regress/sql/pg13.sql      | 10 ++++
 2 files changed, 91 insertions(+), 1 deletion(-)

diff --git a/src/test/regress/expected/pg13.out b/src/test/regress/expected/pg13.out
index 8b3a4b0dd..77250a647 100644
--- a/src/test/regress/expected/pg13.out
+++ b/src/test/regress/expected/pg13.out
@@ -83,9 +83,89 @@ SELECT * FROM ab WHERE (ROW(a,b)).f2 > (ROW(0,38)).f2 ORDER BY 1,2;
  20 | 40
 (1 row)
 
+CREATE TABLE text_table (name text);
+SELECT create_distributed_table('text_table', 'name');
+ create_distributed_table
+---------------------------------------------------------------------
+
+(1 row)
+
+INSERT INTO text_table VALUES ('abc');
+-- not normalized
+INSERT INTO text_table VALUES (U&'\0061\0308bc');
+SELECT name IS NORMALIZED FROM text_table ORDER BY 1;
+ is_normalized
+---------------------------------------------------------------------
+ f
+ t
+(2 rows)
+
+SELECT is_normalized(name) FROM text_table ORDER BY 1;
+ is_normalized
+---------------------------------------------------------------------
+ f
+ t
+(2 rows)
+
+SELECT normalize(name) FROM text_table ORDER BY 1;
+ normalize
+---------------------------------------------------------------------
+ abc
+ äbc
+(2 rows)
+
+INSERT INTO text_table VALUES (normalize(U&'\0061\0308bc', NFC));
+-- test unicode escape
+-- insert the word 'data' with unicode escapes
+INSERT INTO text_table VALUES(U&'d\0061t\+000061');
+-- insert the word слон
+INSERT INTO text_table VALUES(U&'\0441\043B\043E\043D');
+SELECT * FROM text_table ORDER BY 1;
+ name
+---------------------------------------------------------------------
+ abc
+ äbc
+ data
+ äbc
+ слон
+(5 rows)
+
+-- Test that we don't propagate base types
+CREATE TYPE myvarchar;
+CREATE FUNCTION myvarcharin(cstring, oid, integer) RETURNS myvarchar
+LANGUAGE internal IMMUTABLE PARALLEL SAFE STRICT AS 'varcharin';
+NOTICE:  return type myvarchar is only a shell
+CREATE FUNCTION myvarcharout(myvarchar) RETURNS cstring
+LANGUAGE internal IMMUTABLE PARALLEL SAFE STRICT AS 'varcharout';
+NOTICE:  argument type myvarchar is only a shell
+CREATE TYPE myvarchar (
+    input = myvarcharin,
+    output = myvarcharout,
+    alignment = integer,
+    storage = main
+);
+CREATE TABLE my_table (a int, b myvarchar);
+-- this will error because it seems that we don't propagate the "BASE TYPES"
+-- Alter table also errors out so this doesn't seem to apply to use:
+-- """Add ALTER TYPE options useful for extensions,
+-- like TOAST and I/O functions control (Tomas Vondra, Tom Lane)"""
+SELECT create_distributed_table('my_table', 'a');
+ERROR:  type "test_pg13.myvarchar" does not exist
+CONTEXT:  while executing command on localhost:xxxxx
+CREATE TABLE test_table(a int, b tsvector);
+SELECT create_distributed_table('test_table', 'a');
+ create_distributed_table
+---------------------------------------------------------------------
+
+(1 row)
+
+-- we currently don't support this
+CREATE INDEX test_table_index ON test_table USING gist (b tsvector_ops(siglen = 100));
+ERROR:  citus currently doesn't support this index arguments
 drop schema test_pg13 cascade;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 5 other objects
 DETAIL:  drop cascades to table dist_table
 drop cascades to table generated_col_table
 drop cascades to view v
 drop cascades to table ab
+drop cascades to table text_table
diff --git a/src/test/regress/sql/pg13.sql b/src/test/regress/sql/pg13.sql
index 00a229780..73eae1d4b 100644
--- a/src/test/regress/sql/pg13.sql
+++ b/src/test/regress/sql/pg13.sql
@@ -43,4 +43,14 @@ INSERT INTO ab SELECT i, 2 * i FROM generate_series(1,20)i;
 SELECT * FROM ab WHERE (ROW(a,b)).f1 > (ROW(10,30)).f1 ORDER BY 1,2;
 SELECT * FROM ab WHERE (ROW(a,b)).f2 > (ROW(0,38)).f2 ORDER BY 1,2;
 
+CREATE TABLE text_table (name text);
+SELECT create_distributed_table('text_table', 'name');
+INSERT INTO text_table VALUES ('abc');
+-- not normalized
+INSERT INTO text_table VALUES (U&'\0061\0308bc');
+SELECT name IS NORMALIZED FROM text_table ORDER BY 1;
+SELECT is_normalized(name) FROM text_table ORDER BY 1;
+SELECT normalize(name) FROM text_table ORDER BY 1;
+INSERT INTO text_table VALUES (normalize(U&'\0061\0308bc', NFC));
+
 drop schema test_pg13 cascade;
\ No newline at end of file