Refactor circleci config for better readability (#3013)

.circleci/config.yml

@@ -5,148 +5,208 @@ orbs:
 jobs:
   build:
     docker:
-      - {image: 'citusdata/extbuilder:werror'}
+      - image: 'citusdata/extbuilder:werror'
     steps:
       - checkout
-      - {run: {name: 'Configure, Build, and Install', command: build-ext}}
+      - run: 
-      - {persist_to_workspace: {root: ., paths: [.]}}
+          name: 'Configure, Build, and Install'
+          command: build-ext
+      - persist_to_workspace: 
+          root: . 
+          paths: [.]
   check-style:
     docker:
-      - {image: 'citusdata/stylechecker:latest'}
+      - image: 'citusdata/stylechecker:latest'
     steps:
       - checkout
-      - {run: {name: 'Check Style', command: citus_indent --check}}
+      - run:
+          name: 'Check Style'
+          command: citus_indent --check
   check-sql-snapshots:
     docker:
-      - {image: 'citusdata/extbuilder:werror'}
+      - image: 'citusdata/extbuilder:werror'
     steps:
       - checkout
-      - {run: {name: 'Check Snapshots', command: "./configure && make check-sql-snapshots -C src/backend/distributed"}}
+      - run: 
+          name: 'Check Snapshots'
+          command: "./configure && make check-sql-snapshots -C src/backend/distributed"
   test-10_check-multi:
     docker:
-      - {image: 'citusdata/exttester-10:latest'}
+      - image: 'citusdata/exttester-10:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace: 
-      - {run: {name: 'Install and Test (check-multi)', command: 'install-and-test-ext check-multi'}}
+          at: .
-      - {codecov/upload: {flags: 'test_10,multi'}}
+      - run: 
+          name: 'Install and Test (check-multi)'
+          command: 'install-and-test-ext check-multi'
+      - codecov/upload:
+          flags: 'test_10,multi'
   test-10_check-tt-van-mx:
     docker:
-      - {image: 'citusdata/exttester-10:latest'}
+      - image: 'citusdata/exttester-10:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-tt-van-mx)', command: 'install-and-test-ext check-multi-task-tracker-extra check-vanilla check-multi-mx'}}
+          at: .
-      - {codecov/upload: {flags: 'test_10,tracker,vanilla,mx'}}
+      - run:
+          name: 'Install and Test (check-tt-van-mx)'
+          command: 'install-and-test-ext check-multi-task-tracker-extra check-vanilla check-multi-mx'
+      - codecov/upload:
+          flags: 'test_10,tracker,vanilla,mx'
   test-10_check-iso-work-fol:
     docker:
-      - {image: 'citusdata/exttester-10:latest'}
+      - image: 'citusdata/exttester-10:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-iso-work-fol)', command: 'install-and-test-ext check-isolation check-worker'}}
+           at: .
-      - {codecov/upload: {flags: 'test_10,isolation,worker'}}
+      - run: 
+          name: 'Install and Test (check-iso-work-fol)'
+          command: 'install-and-test-ext check-isolation check-worker'
+      - codecov/upload: 
+          flags: 'test_10,isolation,worker'
   test-10_check-fol:
     docker:
-      - {image: 'citusdata/exttester-10:latest'}
+      - image: 'citusdata/exttester-10:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
+          at: .
       - run:
           name: 'Enable core dumps'
           command: 'ulimit -c unlimited'
-      - {run: {name: 'Install and Test (fol)', command: 'install-and-test-ext check-follower-cluster'}}
+      - run: 
+          name: 'Install and Test (fol)'
+          command: 'install-and-test-ext check-follower-cluster'
       - run:
           command: |
             mkdir -p /tmp/core_dumps
             cp core.* /tmp/core_dumps
           when: on_fail
-      - {codecov/upload: {flags: 'follower'}}
+      - codecov/upload: 
-      - {store_artifacts: {path: '/tmp/core_dumps'}}
+          flags: 'follower'
+      - store_artifacts:
+          path: '/tmp/core_dumps'
   test-10_check-failure:
     docker:
-      - {image: 'citusdata/failtester-10:latest'}
+      - image: 'citusdata/failtester-10:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-failure)', command: 'install-and-test-ext check-failure'}}
+          at: .
+      - run:
+          name: 'Install and Test (check-failure)'
+          command: 'install-and-test-ext check-failure'
   test-11_check-multi:
     docker:
-      - {image: 'citusdata/exttester-11:latest'}
+      - image: 'citusdata/exttester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-multi)', command: 'install-and-test-ext check-multi'}}
+          at: .
-      - {codecov/upload: {flags: 'test_11,multi'}}
+      - run: 
+          name: 'Install and Test (check-multi)'
+          command: 'install-and-test-ext check-multi'
+      - codecov/upload: 
+          flags: 'test_11,multi'
 
   test-11_check-non-adaptive-multi:
     docker:
-      - {image: 'citusdata/exttester-11:latest'}
+      - image: 'citusdata/exttester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-non-adaptive-executors)', command: 'install-and-test-ext check-multi-non-adaptive'}}
+          at: .
-      - {codecov/upload: {flags: 'test_11,multi'}}
+      - run: 
+          name: 'Install and Test (check-non-adaptive-executors)'
+          command: 'install-and-test-ext check-multi-non-adaptive'
+      - codecov/upload:
+          flags: 'test_11,multi'
 
   test-11_check-non-adaptive-failure:
     docker:
-      - {image: 'citusdata/failtester-11:latest'}
+      - image: 'citusdata/failtester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace: 
-      - {run: {name: 'Install and Test (check-non-adaptive-executors)', command: 'install-and-test-ext check-failure-non-adaptive'}}
+          at: .
-      - {codecov/upload: {flags: 'test_11,failure'}}
+      - run: 
+          name: 'Install and Test (check-non-adaptive-executors)'
+          command: 'install-and-test-ext check-failure-non-adaptive'
+      - codecov/upload:
+          flags: 'test_11,failure'
 
   test-11_check-non-adaptive-isolation:
     docker:
-      - {image: 'citusdata/exttester-11:latest'}
+      - image: 'citusdata/exttester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-non-adaptive-executors)', command: 'install-and-test-ext check-isolation-non-adaptive'}}
+          at: .
-      - {codecov/upload: {flags: 'test_11,isolation'}}
+      - run: 
+          name: 'Install and Test (check-non-adaptive-executors)'
+          command: 'install-and-test-ext check-isolation-non-adaptive'
+      - codecov/upload: 
+          flags: 'test_11,isolation'
 
 
   test-11_check-tt-van-mx:
     docker:
-      - {image: 'citusdata/exttester-11:latest'}
+      - image: 'citusdata/exttester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-tt-van-mx)', command: 'install-and-test-ext check-multi-task-tracker-extra check-vanilla check-multi-mx'}}
+          at: .
-      - {codecov/upload: {flags: 'test_11,tracker,vanilla,mx'}}
+      - run: 
+          name: 'Install and Test (check-tt-van-mx)'
+          command: 'install-and-test-ext check-multi-task-tracker-extra check-vanilla check-multi-mx'
+      - codecov/upload: 
+          flags: 'test_11,tracker,vanilla,mx'
   test-11_check-iso-work-fol:
     docker:
-      - {image: 'citusdata/exttester-11:latest'}
+      - image: 'citusdata/exttester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
-      - {run: {name: 'Install and Test (check-iso-work-fol)', command: 'install-and-test-ext check-isolation check-worker'}}
+          at: .
-      - {codecov/upload: {flags: 'test_11,isolation,worker'}}
+      - run: 
+          name: 'Install and Test (check-iso-work-fol)'
+          command: 'install-and-test-ext check-isolation check-worker'
+      - codecov/upload:
+          flags: 'test_11,isolation,worker'
   test-11_check-fol:
     docker:
-      - {image: 'citusdata/exttester-11:latest'}
+      - image: 'citusdata/exttester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace:
+          at: .
       - run:
           name: 'Enable core dumps'
           command: 'ulimit -c unlimited'
-      - {run: {name: 'Install and Test (fol)', command: 'install-and-test-ext check-follower-cluster'}}
+      - run:
+          name: 'Install and Test (fol)'
+          command: 'install-and-test-ext check-follower-cluster'
       - run:
           command: |
             mkdir -p /tmp/core_dumps
             cp core.* /tmp/core_dumps
           when: on_fail
-      - {codecov/upload: {flags: 'follower'}}
+      - codecov/upload: 
-      - {store_artifacts: {path: '/tmp/core_dumps'}}
+          flags: 'follower'
+      - store_artifacts: 
+          path: '/tmp/core_dumps'
   test-11_check-failure:
     docker:
-      - {image: 'citusdata/failtester-11:latest'}
+      - image: 'citusdata/failtester-11:latest'
     working_directory: /home/circleci/project
     steps:
-      - {attach_workspace: {at: .}}
+      - attach_workspace: 
-      - {run: {name: 'Install and Test (check-failure)', command: 'install-and-test-ext check-failure'}}
+          at: .
+      - run:
+          name: 'Install and Test (check-failure)'
+          command: 'install-and-test-ext check-failure'
 workflows:
   version: 2
   build_and_test:
@@ -155,18 +215,31 @@ workflows:
       - check-style
       - check-sql-snapshots
 
-      - {test-10_check-multi: {requires: [build]}}
+      - test-10_check-multi:
-      - {test-10_check-tt-van-mx: {requires: [build]}}
+          requires: [build]
-      - {test-10_check-iso-work-fol: {requires: [build]}}
+      - test-10_check-tt-van-mx: 
-      - {test-10_check-fol: {requires: [build]}}
+          requires: [build]
-      - {test-10_check-failure: {requires: [build]}}
+      - test-10_check-iso-work-fol:
+          requires: [build]
+      - test-10_check-fol: 
+          requires: [build]
+      - test-10_check-failure:
+          requires: [build]
 
-      - {test-11_check-multi: {requires: [build]}}
+      - test-11_check-multi:
-      - {test-11_check-tt-van-mx: {requires: [build]}}
+          requires: [build]
-      - {test-11_check-iso-work-fol: {requires: [build]}}
+      - test-11_check-tt-van-mx:
-      - {test-11_check-fol: {requires: [build]}}
+          requires: [build]
-      - {test-11_check-failure: {requires: [build]}}
+      - test-11_check-iso-work-fol:
+          requires: [build]
+      - test-11_check-fol:
+          requires: [build]
+      - test-11_check-failure:
+          requires: [build]
 
-      - {test-11_check-non-adaptive-multi: {requires: [build]}}
+      - test-11_check-non-adaptive-multi:
-      - {test-11_check-non-adaptive-failure: {requires: [build]}}
+          requires: [build]
-      - {test-11_check-non-adaptive-isolation: {requires: [build]}}
+      - test-11_check-non-adaptive-failure:
+          requires: [build]
+      - test-11_check-non-adaptive-isolation:
+          requires: [build]