external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix escaping in sequence dependency queries (#6345) 

Co-authored-by: Marco Slot <marco.slot@gmail.com>
pull/6355/head
Marco Slot 2022-09-14 16:43:24 +02:00 committed by Marco Slot
parent eba70af7a2
commit 7d56c25e28
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/distributed/commands/alter_table.c
View File

@ -1604,6 +1604,8 @@ ReplaceTable(Oid sourceId, Oid targetId, List *justBeforeDropCommands,
} }
else if (ShouldSyncTableMetadata(sourceId)) else if (ShouldSyncTableMetadata(sourceId))
{ {
char *qualifiedTableName = quote_qualified_identifier(schemaName, sourceName);
/* /*
* We are converting a citus local table to a distributed/reference table, * We are converting a citus local table to a distributed/reference table,
* so we should prevent dropping the sequence on the table. Otherwise, we'd * so we should prevent dropping the sequence on the table. Otherwise, we'd
@ -1612,8 +1614,8 @@ ReplaceTable(Oid sourceId, Oid targetId, List *justBeforeDropCommands,
StringInfo command = makeStringInfo(); StringInfo command = makeStringInfo();
appendStringInfo(command, appendStringInfo(command,
"SELECT pg_catalog.worker_drop_sequence_dependency('%s');", "SELECT pg_catalog.worker_drop_sequence_dependency(%s);",
quote_qualified_identifier(schemaName, sourceName)); quote_literal_cstr(qualifiedTableName));
SendCommandToWorkersWithMetadata(command->data); SendCommandToWorkersWithMetadata(command->data);
} }
@ -1903,11 +1905,17 @@ CreateWorkerChangeSequenceDependencyCommand(char *sequenceSchemaName, char *sequ
char *sourceSchemaName, char *sourceName, char *sourceSchemaName, char *sourceName,
char *targetSchemaName, char *targetName) char *targetSchemaName, char *targetName)
{ {
char *qualifiedSchemaName = quote_qualified_identifier(sequenceSchemaName,
sequenceName);
char *qualifiedSourceName = quote_qualified_identifier(sourceSchemaName, sourceName);
char *qualifiedTargetName = quote_qualified_identifier(targetSchemaName, targetName);
StringInfo query = makeStringInfo(); StringInfo query = makeStringInfo();
appendStringInfo(query, "SELECT worker_change_sequence_dependency('%s', '%s', '%s')", appendStringInfo(query, "SELECT worker_change_sequence_dependency(%s, %s, %s)",
quote_qualified_identifier(sequenceSchemaName, sequenceName), quote_literal_cstr(qualifiedSchemaName),
quote_qualified_identifier(sourceSchemaName, sourceName), quote_literal_cstr(qualifiedSourceName),
quote_qualified_identifier(targetSchemaName, targetName)); quote_literal_cstr(qualifiedTargetName));
return query->data; return query->data;
} }