Merge pull request #4817 from citusdata/marcocitus/fix-warning

Remove unnecessary AtEOXact_Files call
pull/4819/head
Marco Slot 2021-03-15 09:58:41 +01:00 committed by GitHub
commit 7d8d5cad98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 21 deletions

View File

@ -318,28 +318,8 @@ CoordinatedTransactionCallback(XactEvent event, void *arg)
/* stop propagating notices from workers, we know the query is failed */
DisableWorkerMessagePropagation();
/*
* FIXME: Add warning for the COORD_TRANS_COMMITTED case. That
* can be reached if this backend fails after the
* XACT_EVENT_PRE_COMMIT state.
*/
RemoveIntermediateResultsDirectory();
/*
* Call other parts of citus that need to integrate into
* transaction management. Do so before doing other work, so the
* callbacks still can perform work if needed.
*/
{
/*
* On Windows it's not possible to delete a file before you've closed all
* handles to it (rmdir will return success but not take effect). Since
* we're in an ABORT handler it's very likely that not all handles have
* been closed; force them closed here before running
* RemoveIntermediateResultsDirectory.
*/
AtEOXact_Files(false);
RemoveIntermediateResultsDirectory();
}
ResetShardPlacementTransactionState();
/* handles both already prepared and open transactions */