external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add comments, use strncmp, clean up GUC desc. 

Good to go!
pull/1277/head
Jason Petersen 2017-04-04 16:15:39 -06:00
parent 033fda9183
commit 7e46f41c12
No known key found for this signature in database
GPG Key ID: 9F1D3510D110ABA9
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/distributed/executor/multi_utility.c
View File

@ -409,6 +409,12 @@ multi_ProcessUtility(Node *parsetree,
}
/*
* SkipCitusProcessingForUtility simply returns whether a given utility should
* bypass Citus processing and checks and be handled exclusively by standard
* PostgreSQL utility processing. At present, CREATE/ALTER/DROP EXTENSION,
* ABORT, COMMIT, ROLLBACK, and SET (GUC) statements are exempt from Citus.
*/
static bool
SkipCitusProcessingForUtility(Node *parsetree)
{
@ -460,6 +466,11 @@ SkipCitusProcessingForUtility(Node *parsetree)
}
/*
* IsCitusExtensionStmt returns whether a given utility is a CREATE or ALTER
* EXTENSION statement which references the citus extension. This function
* returns false for all other inputs.
*/
static bool
IsCitusExtensionStmt(Node *parsetree)
{
@ -1370,6 +1381,11 @@ ErrorIfUnstableCreateOrAlterExtensionStmt(Node *parsetree)
}
/*
* ExtractNewExtensionVersion returns the new extension version specified by
* a CREATE or ALTER EXTENSION statement. Other inputs are not permitted. This
* function returns NULL for statements with no explicit version specified.
*/
static char *
ExtractNewExtensionVersion(Node *parsetree)
{
@ -1394,8 +1410,7 @@ ExtractNewExtensionVersion(Node *parsetree)
foreach(optionsCell, optionsList)
{
DefElem *defElement = (DefElem *) lfirst(optionsCell);
if (strcmp(defElement->defname, "new_version") == 0)
if (strncmp(defElement->defname, "new_version", NAMEDATALEN) == 0)
{
newVersion = strVal(defElement->arg);
break;

4
src/backend/distributed/shared_library_init.c
View File

@ -615,7 +615,7 @@ RegisterCitusConfigVariables(void)
DefineCustomStringVariable(
"citus.version",
gettext_noop("Shows the running Citus version"),
gettext_noop("Shows the Citus library version"),
NULL,
&CitusVersion,
CITUS_VERSION,
@ -625,7 +625,7 @@ RegisterCitusConfigVariables(void)
DefineCustomBoolVariable(
"citus.enable_version_checks",
gettext_noop("Enables version checks in CREATE/ALTER extension queries"),
gettext_noop("Enables version checks during CREATE/ALTER EXTENSION commands"),
NULL,
&EnableVersionChecks,
true,