From 80360e464baafcaab922a8dceb8a472d393c43ab Mon Sep 17 00:00:00 2001
From: Onur Tirtir <onurcantirtir@gmail.com>
Date: Thu, 29 Feb 2024 01:17:25 +0300
Subject: [PATCH] improve

---
 .../commands/non_main_db_distribute_object_ops.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/backend/distributed/commands/non_main_db_distribute_object_ops.c b/src/backend/distributed/commands/non_main_db_distribute_object_ops.c
index a64fde0bc..c71052c3d 100644
--- a/src/backend/distributed/commands/non_main_db_distribute_object_ops.c
+++ b/src/backend/distributed/commands/non_main_db_distribute_object_ops.c
@@ -120,7 +120,11 @@ static MarkDistributedGloballyParams * CreateRoleStmtGetMarkDistributedParams(
 static List * DropRoleStmtGetUnmarkDistributedParams(Node *parsetree);
 
 
-/* NonMainDbDistributeObjectOps for different command types */
+/*
+ * NonMainDbDistributeObjectOps for different command types.
+ *
+ * Naming of these structs are stolen from distribute_object_ops.c.
+ */
 static NonMainDbDistributeObjectOps Any_CreateRole = {
 	.getMarkDistributedParams = CreateRoleStmtGetMarkDistributedParams,
 	.getUnmarkDistributedParams = NULL,
@@ -137,14 +141,16 @@ static NonMainDbDistributeObjectOps Any_AlterRole = {
 	.cannotBeExecutedInTransaction = false
 };
 static NonMainDbDistributeObjectOps Any_GrantRole = {
+	.getMarkDistributedParams = NULL,
+	.getUnmarkDistributedParams = NULL,
 	.cannotBeExecutedInTransaction = false
 };
-static NonMainDbDistributeObjectOps Database_Create = {
+static NonMainDbDistributeObjectOps Any_CreateDatabase = {
 	.getMarkDistributedParams = NULL,
 	.getUnmarkDistributedParams = NULL,
 	.cannotBeExecutedInTransaction = true
 };
-static NonMainDbDistributeObjectOps Database_Drop = {
+static NonMainDbDistributeObjectOps Any_DropDatabase = {
 	.getMarkDistributedParams = NULL,
 	.getUnmarkDistributedParams = NULL,
 	.cannotBeExecutedInTransaction = true
@@ -296,7 +302,7 @@ GetNonMainDbDistributeObjectOps(Node *parsetree)
 			 */
 			if (strcmp(stmt->dbname, MainDb) != 0)
 			{
-				return &Database_Create;
+				return &Any_CreateDatabase;
 			}
 
 			return NULL;
@@ -313,7 +319,7 @@ GetNonMainDbDistributeObjectOps(Node *parsetree)
 			 */
 			if (strcmp(stmt->dbname, MainDb) != 0)
 			{
-				return &Database_Drop;
+				return &Any_DropDatabase;
 			}
 
 			return NULL;