From 80686907a3f7b442045a820c5031d4f3c89d58fc Mon Sep 17 00:00:00 2001
From: aykut-bozkurt <51649454+aykut-bozkurt@users.noreply.github.com>
Date: Mon, 12 Dec 2022 18:53:17 +0300
Subject: [PATCH] print stack trace from core files instead of uploading them
 (#6539)

Prints stack trace from core files instead of uploading them.
---
 .circleci/config.yml    | 68 ++++++++---------------------------------
 ci/README.md            |  4 +++
 ci/fix_style.sh         |  1 +
 ci/print_stack_trace.sh | 25 +++++++++++++++
 4 files changed, 43 insertions(+), 55 deletions(-)
 create mode 100755 ci/print_stack_trace.sh

diff --git a/.circleci/config.yml b/.circleci/config.yml
index e98fcaab3..c7b51f177 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -6,7 +6,7 @@ orbs:
 parameters:
   image_suffix:
     type: string
-    default: '-vcbba174'
+    default: '-v7e4468f'
   pg13_version:
     type: string
     default: '13.9'
@@ -166,13 +166,9 @@ jobs:
             fi
           when: on_fail
       - run:
-          name: 'Copy coredumps'
+          name: 'Print stack traces'
           command: |
-            mkdir -p /tmp/core_dumps
-            core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
-            if [ ${#core_files[@]} -gt 0 ]; then
-                cp "${core_files[@]}" /tmp/core_dumps
-            fi
+            ./ci/print_stack_trace.sh
           when: on_fail
       - run:
           name: 'Copy pg_upgrade logs for newData dir'
@@ -185,9 +181,6 @@ jobs:
       - store_artifacts:
           name: 'Save regressions'
           path: src/test/regress/regression.diffs
-      - store_artifacts:
-          name: 'Save core dumps'
-          path: /tmp/core_dumps
       - store_artifacts:
           name: 'Save pg_upgrade logs for newData dir'
           path: /tmp/pg_upgrade_newData_logs
@@ -270,17 +263,10 @@ jobs:
             find src/test/regress/tmp_citus_test/ -name "logfile_*" -exec cp -t src/test/regress/tmp_citus_test/logfiles/ {} +
           when: on_fail
       - run:
-          name: 'Copy coredumps'
+          name: 'Print stack traces'
           command: |
-            mkdir -p /tmp/core_dumps
-            core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
-            if [ ${#core_files[@]} -gt 0 ]; then
-                cp "${core_files[@]}" /tmp/core_dumps
-            fi
+            ./ci/print_stack_trace.sh
           when: on_fail
-      - store_artifacts:
-          name: 'Save core dumps'
-          path: /tmp/core_dumps
       - store_artifacts:
           name: 'Save logfiles'
           path: src/test/regress/tmp_citus_test/logfiles
@@ -364,20 +350,13 @@ jobs:
             fi
           when: on_fail
       - run:
-          name: 'Copy coredumps'
+          name: 'Print stack traces'
           command: |
-            mkdir -p /tmp/core_dumps
-            core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
-            if [ ${#core_files[@]} -gt 0 ]; then
-                cp "${core_files[@]}" /tmp/core_dumps
-            fi
+            ./ci/print_stack_trace.sh
           when: on_fail
       - store_artifacts:
           name: 'Save regressions'
           path: src/test/regress/regression.diffs
-      - store_artifacts:
-          name: 'Save core dumps'
-          path: /tmp/core_dumps
       - codecov/upload:
           flags: 'test_<< parameters.pg_major >>,upgrade'
       - run:
@@ -443,13 +422,9 @@ jobs:
             fi
           when: on_fail
       - run:
-          name: 'Copy coredumps'
+          name: 'Print stack traces'
           command: |
-            mkdir -p /tmp/core_dumps
-            core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
-            if [ ${#core_files[@]} -gt 0 ]; then
-                cp "${core_files[@]}" /tmp/core_dumps
-            fi
+            ./ci/print_stack_trace.sh
           when: on_fail
       - store_artifacts:
           name: 'Save regressions'
@@ -460,9 +435,6 @@ jobs:
       - store_artifacts:
           name: 'Save results'
           path: src/test/regress/results/
-      - store_artifacts:
-          name: 'Save core dumps'
-          path: /tmp/core_dumps
       - store_artifacts:
           name: 'Save coordinator log'
           path: src/test/regress/tmp_check/master/log
@@ -534,20 +506,13 @@ jobs:
             gosu circleci make -C src/test/<< parameters.suite >> << parameters.make >>
           no_output_timeout: 2m
       - run:
-          name: 'Copy coredumps'
+          name: 'Print stack traces'
           command: |
-            mkdir -p /tmp/core_dumps
-            core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
-            if [ ${#core_files[@]} -gt 0 ]; then
-                cp "${core_files[@]}" /tmp/core_dumps
-            fi
+            ./ci/print_stack_trace.sh
           when: on_fail
       - store_artifacts:
           name: 'Save tap logs'
           path: /home/circleci/project/src/test/<< parameters.suite >>/tmp_check/log
-      - store_artifacts:
-          name: 'Save core dumps'
-          path: /tmp/core_dumps
       - codecov/upload:
           flags: 'test_<< parameters.pg_major >>,tap_<< parameters.suite >>_<< parameters.make >>'
           when: always
@@ -697,13 +662,9 @@ jobs:
             fi
           when: on_fail
       - run:
-          name: 'Copy coredumps'
+          name: 'Print stack traces'
           command: |
-            mkdir -p /tmp/core_dumps
-            core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
-            if [ ${#core_files[@]} -gt 0 ]; then
-                cp "${core_files[@]}" /tmp/core_dumps
-            fi
+            ./ci/print_stack_trace.sh
           when: on_fail
       - store_artifacts:
           name: 'Save regressions'
@@ -714,9 +675,6 @@ jobs:
       - store_artifacts:
           name: 'Save results'
           path: src/test/regress/results/
-      - store_artifacts:
-          name: 'Save core dumps'
-          path: /tmp/core_dumps
       - store_artifacts:
           name: 'Save coordinator log'
           path: src/test/regress/tmp_check/master/log
diff --git a/ci/README.md b/ci/README.md
index 2d8889f14..f4dde9cc3 100644
--- a/ci/README.md
+++ b/ci/README.md
@@ -373,3 +373,7 @@ This script checks and fixes issues with `.gitignore` rules:
 This script checks the order of the GUCs defined in `shared_library_init.c`.
 To solve this failure, please check `shared_library_init.c` and make sure that the GUC
 definitions are in alphabetical order.
+
+## `print_stack_trace.sh`
+
+This script prints stack traces for failed tests, if they left core files.
diff --git a/ci/fix_style.sh b/ci/fix_style.sh
index 8df09a378..e65447662 100755
--- a/ci/fix_style.sh
+++ b/ci/fix_style.sh
@@ -16,3 +16,4 @@ ci/disallow_hash_comments_in_spec_files.sh
 ci/disallow_long_changelog_entries.sh
 ci/normalize_expected.sh
 ci/fix_gitignore.sh
+ci/printstack_trace.sh
diff --git a/ci/print_stack_trace.sh b/ci/print_stack_trace.sh
new file mode 100755
index 000000000..3f0810587
--- /dev/null
+++ b/ci/print_stack_trace.sh
@@ -0,0 +1,25 @@
+#!/bin/bash
+
+set -euo pipefail
+
+# shellcheck disable=SC1091
+source ci/ci_helpers.sh
+
+# find all core files
+core_files=( $(find . -type f -regex .*core.*\d*.*postgres) )
+if [ ${#core_files[@]} -gt 0 ]; then
+    # print stack traces for the core files
+    for core_file in "${core_files[@]}"
+    do
+        # set print frame-arguments all: show all scalars + structures in the frame
+        # set print pretty on:           show structures in indented mode
+        # set print addr off:            do not show pointer address
+        # thread apply all bt full:      show stack traces for all threads
+        gdb --batch \
+            -ex "set print frame-arguments all" \
+            -ex "set print pretty on" \
+            -ex "set print addr off" \
+            -ex "thread apply all bt full" \
+            postgres "${core_file}"
+    done
+fi