From 8244db7d7c73a001634d209adf0c4530c5950990 Mon Sep 17 00:00:00 2001 From: Nitish Upreti Date: Tue, 12 Jul 2022 15:54:04 -0700 Subject: [PATCH] Fix test failure --- .../citus_split_shard_by_split_points.c | 16 +++++++++------- .../expected/upgrade_list_citus_objects.out | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/backend/distributed/operations/citus_split_shard_by_split_points.c b/src/backend/distributed/operations/citus_split_shard_by_split_points.c index d40245f48..11e979900 100644 --- a/src/backend/distributed/operations/citus_split_shard_by_split_points.c +++ b/src/backend/distributed/operations/citus_split_shard_by_split_points.c @@ -27,7 +27,7 @@ /* declarations for dynamic loading */ PG_FUNCTION_INFO_V1(citus_split_shard_by_split_points); -static SplitMode LookupSplitMode(Oid shardSplitModeOid); +static SplitMode LookupSplitMode(Oid shardTransferModeOid); /* * citus_split_shard_by_split_points(shard_id bigint, split_points text[], node_ids integer[], shard_transfer_mode citus.shard_transfer_mode) @@ -82,16 +82,18 @@ LookupSplitMode(Oid shardTransferModeOid) shardSplitMode = BLOCKING_SPLIT; } else if (strncmp(enumLabel, "auto", NAMEDATALEN) == 0 || - strncmp(enumLabel, "force_logical", NAMEDATALEN) == 0) + strncmp(enumLabel, "force_logical", NAMEDATALEN) == 0) { - ereport(ERROR, (errmsg("Shard Tranfer mode: '%s' is not supported. Please use 'block_writes' instead.", - enumLabel))); + ereport(ERROR, (errmsg( + "Shard Tranfer mode: '%s' is not supported. Please use 'block_writes' instead.", + enumLabel))); } else { - // We will not get here as postgres will validate the enum value. - ereport(ERROR, (errmsg("Invalid shard tranfer mode: '%s'. Expected split mode is 'block_writes'.", - enumLabel))); + /* We will not get here as postgres will validate the enum value. */ + ereport(ERROR, (errmsg( + "Invalid shard tranfer mode: '%s'. Expected split mode is 'block_writes'.", + enumLabel))); } return shardSplitMode; diff --git a/src/test/regress/expected/upgrade_list_citus_objects.out b/src/test/regress/expected/upgrade_list_citus_objects.out index 614d95a9b..fb0ff32cb 100644 --- a/src/test/regress/expected/upgrade_list_citus_objects.out +++ b/src/test/regress/expected/upgrade_list_citus_objects.out @@ -289,5 +289,5 @@ ORDER BY 1; view columnar.stripe view pg_dist_shard_placement view time_partitions -(274 rows) +(273 rows)