external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't run any isolation tests in parallel (#6212) 

By running isolation tests in parallel we're just asking for flaky
tasks. The first test might temporarily block one of the commands in the
second test, which we then detect as waiting like this:
```diff
 step s2-vacuum-analyze:
     VACUUM ANALYZE test_insert_vacuum;
-
+ <waiting ...>
 step s1-commit:
     COMMIT;

+step s2-vacuum-analyze: <... completed>
```

Debugging flaky tests is also much harder when they are run in parallel.
This PR starts running all our isolation tests sequentially.

The reason for opening this PR was me seeing this failing test:
https://app.circleci.com/pipelines/github/citusdata/citus/26194/workflows/ff57e2cf-8ac4-40fe-bc0c-74a7f8fecb53/jobs/740454

As well as having fixed a similar issue recently in #6122
pull/6214/head
Jelte Fennema 2022-08-19 17:05:36 +02:00 committed by GitHub
parent 616ff2a3fe
commit 85305b2773
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/regress/isolation_schedule
View File

@ -26,12 +26,16 @@ test: isolation_citus_dist_activity
test: isolation_remove_coordinator test: isolation_remove_coordinator
test: isolation_insert_select_repartition test: isolation_insert_select_repartition
test: isolation_dml_vs_repair isolation_copy_placement_vs_copy_placement test: isolation_dml_vs_repair
test: isolation_copy_placement_vs_copy_placement
test: isolation_concurrent_dml test: isolation_concurrent_dml
test: isolation_data_migration test: isolation_data_migration
test: isolation_drop_shards isolation_copy_placement_vs_modification test: isolation_drop_shards
test: isolation_insert_vs_vacuum isolation_transaction_recovery isolation_vacuum_skip_locked test: isolation_copy_placement_vs_modification
test: isolation_insert_vs_vacuum
test: isolation_transaction_recovery
test: isolation_vacuum_skip_locked
test: isolation_progress_monitoring test: isolation_progress_monitoring
test: isolation_dump_local_wait_edges test: isolation_dump_local_wait_edges