From 859b920ba9b15dc2ee7ad6320a56ea15a72fc77d Mon Sep 17 00:00:00 2001
From: Eren Basak <aamederen@gmail.com>
Date: Tue, 10 Jan 2017 10:38:21 +0300
Subject: [PATCH] Fix escaping of workerrack in NodeListInsertCommand

This change fixes a small bug about quoting of workerrack column in
NodeListInsertCommand:

Previous: `"..., '%s'", workerRack`
Now: `"..., %s", quote_literal_cstr(workerRack)`
---
 src/backend/distributed/metadata/metadata_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/distributed/metadata/metadata_sync.c b/src/backend/distributed/metadata/metadata_sync.c
index 0bd24b33a..156f48bff 100644
--- a/src/backend/distributed/metadata/metadata_sync.c
+++ b/src/backend/distributed/metadata/metadata_sync.c
@@ -384,12 +384,12 @@ NodeListInsertCommand(List *workerNodeList)
 		char *hasMetadaString = workerNode->hasMetadata ? "TRUE" : "FALSE";
 
 		appendStringInfo(nodeListInsertCommand,
-						 "(%d, %d, %s, %d, '%s', %s)",
+						 "(%d, %d, %s, %d, %s, %s)",
 						 workerNode->nodeId,
 						 workerNode->groupId,
 						 quote_literal_cstr(workerNode->workerName),
 						 workerNode->workerPort,
-						 workerNode->workerRack,
+						 quote_literal_cstr(workerNode->workerRack),
 						 hasMetadaString);
 
 		processedWorkerNodeCount++;