mirror of https://github.com/citusdata/citus.git
Merge pull request #4709 from citusdata/sequential-mode-on-long-table-names
Hanefi Onaldi
GitHub
commit
8820541fd4
|
|
@ -49,6 +49,8 @@
|
|||
#include "distributed/multi_logical_planner.h"
|
||||
#include "distributed/multi_partitioning_utils.h"
|
||||
#include "distributed/reference_table_utils.h"
|
||||
#include "distributed/relation_access_tracking.h"
|
||||
#include "distributed/shard_utils.h"
|
||||
#include "distributed/worker_protocol.h"
|
||||
#include "distributed/worker_transaction.h"
|
||||
#include "executor/spi.h"
|
||||
|
|
@ -175,6 +177,8 @@ static TableConversionReturn * AlterDistributedTable(TableConversionParameters *
|
|||
static TableConversionReturn * AlterTableSetAccessMethod(
|
||||
TableConversionParameters *params);
|
||||
static TableConversionReturn * ConvertTable(TableConversionState *con);
|
||||
static bool SwitchToSequentialAndLocalExecutionIfShardNameTooLong(char *relationName,
|
||||
char *longestShardName);
|
||||
static void EnsureTableNotReferencing(Oid relationId, char conversionType);
|
||||
static void EnsureTableNotReferenced(Oid relationId, char conversionType);
|
||||
static void EnsureTableNotForeign(Oid relationId);
|
||||
|
|
@ -511,6 +515,10 @@ ConvertTable(TableConversionState *con)
|
|||
bool oldEnableLocalReferenceForeignKeys = EnableLocalReferenceForeignKeys;
|
||||
SetLocalEnableLocalReferenceForeignKeys(false);
|
||||
|
||||
/* switch to sequential execution if shard names will be too long */
|
||||
SwitchToSequentialAndLocalExecutionIfRelationNameTooLong(con->relationId,
|
||||
con->relationName);
|
||||
|
||||
if (con->conversionType == UNDISTRIBUTE_TABLE && con->cascadeViaForeignKeys &&
|
||||
(TableReferencing(con->relationId) || TableReferenced(con->relationId)))
|
||||
{
|
||||
|
|
@ -1572,3 +1580,104 @@ ExecuteQueryViaSPI(char *query, int SPIOK)
|
|||
ereport(ERROR, (errmsg("could not finish SPI connection")));
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* SwitchToSequentialAndLocalExecutionIfRelationNameTooLong generates the longest shard name
|
||||
* on the shards of a distributed table, and if exceeds the limit switches to sequential and
|
||||
* local execution to prevent self-deadlocks.
|
||||
*
|
||||
* In case of a RENAME, the relation name parameter should store the new table name, so
|
||||
* that the function can generate shard names of the renamed relations
|
||||
*/
|
||||
void
|
||||
SwitchToSequentialAndLocalExecutionIfRelationNameTooLong(Oid relationId,
|
||||
char *finalRelationName)
|
||||
{
|
||||
if (!IsCitusTable(relationId))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
if (ShardIntervalCount(relationId) == 0)
|
||||
{
|
||||
/*
|
||||
* Relation has no shards, so we cannot run into "long shard relation
|
||||
* name" issue.
|
||||
*/
|
||||
return;
|
||||
}
|
||||
|
||||
char *longestShardName = GetLongestShardName(relationId, finalRelationName);
|
||||
bool switchedToSequentialAndLocalExecution =
|
||||
SwitchToSequentialAndLocalExecutionIfShardNameTooLong(finalRelationName,
|
||||
longestShardName);
|
||||
|
||||
if (switchedToSequentialAndLocalExecution)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
if (PartitionedTable(relationId))
|
||||
{
|
||||
Oid longestNamePartitionId = PartitionWithLongestNameRelationId(relationId);
|
||||
if (!OidIsValid(longestNamePartitionId))
|
||||
{
|
||||
/* no partitions have been created yet */
|
||||
return;
|
||||
}
|
||||
|
||||
char *longestPartitionName = get_rel_name(longestNamePartitionId);
|
||||
char *longestPartitionShardName = GetLongestShardName(longestNamePartitionId,
|
||||
longestPartitionName);
|
||||
|
||||
SwitchToSequentialAndLocalExecutionIfShardNameTooLong(longestPartitionName,
|
||||
longestPartitionShardName);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* SwitchToSequentialAndLocalExecutionIfShardNameTooLong switches to sequential and local
|
||||
* execution if the shard name is too long.
|
||||
*
|
||||
* returns true if switched to sequential and local execution.
|
||||
*/
|
||||
static bool
|
||||
SwitchToSequentialAndLocalExecutionIfShardNameTooLong(char *relationName,
|
||||
char *longestShardName)
|
||||
{
|
||||
if (strlen(longestShardName) >= NAMEDATALEN - 1)
|
||||
{
|
||||
if (ParallelQueryExecutedInTransaction())
|
||||
{
|
||||
/*
|
||||
* If there has already been a parallel query executed, the sequential mode
|
||||
* would still use the already opened parallel connections to the workers,
|
||||
* thus contradicting our purpose of using sequential mode.
|
||||
*/
|
||||
ereport(ERROR, (errmsg(
|
||||
"Shard name (%s) for table (%s) is too long and could "
|
||||
"lead to deadlocks when executed in a transaction "
|
||||
"block after a parallel query", longestShardName,
|
||||
relationName),
|
||||
errhint("Try re-running the transaction with "
|
||||
"\"SET LOCAL citus.multi_shard_modify_mode TO "
|
||||
"\'sequential\';\"")));
|
||||
}
|
||||
else
|
||||
{
|
||||
elog(DEBUG1, "the name of the shard (%s) for relation (%s) is too long, "
|
||||
"switching to sequential and local execution mode to prevent "
|
||||
"self deadlocks",
|
||||
longestShardName, relationName);
|
||||
|
||||
SetLocalMultiShardModifyModeToSequential();
|
||||
SetLocalExecutionStatus(LOCAL_EXECUTION_REQUIRED);
|
||||
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -410,15 +410,16 @@ static char *
|
|||
GenerateLongestShardPartitionIndexName(IndexStmt *createIndexStatement)
|
||||
{
|
||||
Oid relationId = CreateIndexStmtGetRelationId(createIndexStatement);
|
||||
char *longestPartitionName = LongestPartitionName(relationId);
|
||||
if (longestPartitionName == NULL)
|
||||
Oid longestNamePartitionId = PartitionWithLongestNameRelationId(relationId);
|
||||
if (!OidIsValid(longestNamePartitionId))
|
||||
{
|
||||
/* no partitions have been created yet */
|
||||
return NULL;
|
||||
}
|
||||
|
||||
char *longestPartitionShardName = pstrdup(longestPartitionName);
|
||||
ShardInterval *shardInterval = LoadShardIntervalWithLongestShardName(relationId);
|
||||
char *longestPartitionShardName = get_rel_name(longestNamePartitionId);
|
||||
ShardInterval *shardInterval = LoadShardIntervalWithLongestShardName(
|
||||
longestNamePartitionId);
|
||||
AppendShardIdToName(&longestPartitionShardName, shardInterval->shardId);
|
||||
|
||||
IndexStmt *createLongestShardIndexStmt = copyObject(createIndexStatement);
|
||||
|
|
|
|||
|
|
@ -109,6 +109,13 @@ PreprocessRenameStmt(Node *node, const char *renameCommand,
|
|||
*/
|
||||
ErrorIfUnsupportedRenameStmt(renameStmt);
|
||||
|
||||
if (renameStmt->renameType == OBJECT_TABLE ||
|
||||
renameStmt->renameType == OBJECT_FOREIGN_TABLE)
|
||||
{
|
||||
SwitchToSequentialAndLocalExecutionIfRelationNameTooLong(tableRelationId,
|
||||
renameStmt->newname);
|
||||
}
|
||||
|
||||
DDLJob *ddlJob = palloc0(sizeof(DDLJob));
|
||||
ddlJob->targetRelationId = tableRelationId;
|
||||
ddlJob->concurrentIndexCmd = false;
|
||||
|
|
|
|||
|
|
@ -556,30 +556,6 @@ RelayEventExtendNames(Node *parseTree, char *schemaName, uint64 shardId)
|
|||
|
||||
AppendShardIdToName(oldRelationName, shardId);
|
||||
AppendShardIdToName(newRelationName, shardId);
|
||||
|
||||
/*
|
||||
* PostgreSQL creates array types for each ordinary table, with
|
||||
* the same name plus a prefix of '_'.
|
||||
*
|
||||
* ALTER TABLE ... RENAME TO ... also renames the underlying
|
||||
* array type, and the DDL is run in parallel connections over
|
||||
* all the placements and shards at once. Concurrent access
|
||||
* here deadlocks.
|
||||
*
|
||||
* Let's provide an easier to understand error message here
|
||||
* than the deadlock one.
|
||||
*
|
||||
* See also https://github.com/citusdata/citus/issues/1664
|
||||
*/
|
||||
int newRelationNameLength = strlen(*newRelationName);
|
||||
if (newRelationNameLength >= (NAMEDATALEN - 1))
|
||||
{
|
||||
ereport(ERROR,
|
||||
(errcode(ERRCODE_NAME_TOO_LONG),
|
||||
errmsg(
|
||||
"shard name %s exceeds %d characters",
|
||||
*newRelationName, NAMEDATALEN - 1)));
|
||||
}
|
||||
}
|
||||
else if (objectType == OBJECT_COLUMN)
|
||||
{
|
||||
|
|
|
|||
|
|
@ -548,13 +548,14 @@ PartitionParentOid(Oid partitionOid)
|
|||
|
||||
|
||||
/*
|
||||
* LongestPartitionName is a uitility function that returns the partition
|
||||
* name which is the longest in terms of number of characters.
|
||||
* PartitionWithLongestNameRelationId is a utility function that returns the
|
||||
* oid of the partition table that has the longest name in terms of number of
|
||||
* characters.
|
||||
*/
|
||||
char *
|
||||
LongestPartitionName(Oid parentRelationId)
|
||||
Oid
|
||||
PartitionWithLongestNameRelationId(Oid parentRelationId)
|
||||
{
|
||||
char *longestName = NULL;
|
||||
Oid longestNamePartitionId = InvalidOid;
|
||||
int longestNameLength = 0;
|
||||
List *partitionList = PartitionList(parentRelationId);
|
||||
|
||||
|
|
@ -565,12 +566,12 @@ LongestPartitionName(Oid parentRelationId)
|
|||
int partitionNameLength = strnlen(partitionName, NAMEDATALEN);
|
||||
if (partitionNameLength > longestNameLength)
|
||||
{
|
||||
longestName = partitionName;
|
||||
longestNamePartitionId = partitionRelationId;
|
||||
longestNameLength = partitionNameLength;
|
||||
}
|
||||
}
|
||||
|
||||
return longestName;
|
||||
return longestNamePartitionId;
|
||||
}
|
||||
|
||||
|
||||
|
|
|
|||
|
|
@ -12,6 +12,7 @@
|
|||
#include "postgres.h"
|
||||
|
||||
#include "utils/lsyscache.h"
|
||||
#include "distributed/metadata_utility.h"
|
||||
#include "distributed/relay_utility.h"
|
||||
#include "distributed/shard_utils.h"
|
||||
|
||||
|
|
@ -36,3 +37,21 @@ GetTableLocalShardOid(Oid citusTableOid, uint64 shardId)
|
|||
|
||||
return shardRelationOid;
|
||||
}
|
||||
|
||||
|
||||
/*
|
||||
* GetLongestShardName is a utility function that returns the name of the shard of a
|
||||
* table that has the longest name in terms of number of characters.
|
||||
*
|
||||
* Both the Oid and name of the table are required so we can create longest shard names
|
||||
* after a RENAME.
|
||||
*/
|
||||
char *
|
||||
GetLongestShardName(Oid citusTableOid, char *finalRelationName)
|
||||
{
|
||||
char *longestShardName = pstrdup(finalRelationName);
|
||||
ShardInterval *shardInterval = LoadShardIntervalWithLongestShardName(citusTableOid);
|
||||
AppendShardIdToName(&longestShardName, shardInterval->shardId);
|
||||
|
||||
return longestShardName;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -24,6 +24,10 @@
|
|||
/* controlled via GUC, should be accessed via EnableLocalReferenceForeignKeys() */
|
||||
extern bool EnableLocalReferenceForeignKeys;
|
||||
|
||||
extern void SwitchToSequentialAndLocalExecutionIfRelationNameTooLong(Oid relationId,
|
||||
char *
|
||||
finalRelationName);
|
||||
|
||||
|
||||
/*
|
||||
* DistributeObjectOps specifies handlers for node/object type pairs.
|
||||
|
|
|
|||
|
|
@ -19,7 +19,7 @@ extern bool PartitionTableNoLock(Oid relationId);
|
|||
extern bool IsChildTable(Oid relationId);
|
||||
extern bool IsParentTable(Oid relationId);
|
||||
extern Oid PartitionParentOid(Oid partitionOid);
|
||||
extern char * LongestPartitionName(Oid parentRelationId);
|
||||
extern Oid PartitionWithLongestNameRelationId(Oid parentRelationId);
|
||||
extern List * PartitionList(Oid parentRelationId);
|
||||
extern char * GenerateDetachPartitionCommand(Oid partitionTableId);
|
||||
extern char * GenerateAttachShardPartitionCommand(ShardInterval *shardInterval);
|
||||
|
|
|
|||
|
|
@ -14,5 +14,6 @@
|
|||
#include "postgres.h"
|
||||
|
||||
extern Oid GetTableLocalShardOid(Oid citusTableOid, uint64 shardId);
|
||||
extern char * GetLongestShardName(Oid citusTableOid, char *finalRelationName);
|
||||
|
||||
#endif /* SHARD_UTILS_H */
|
||||
|
|
|
|||
|
|
@ -223,3 +223,11 @@ s/^(ERROR: child table is missing constraint "\w+)_([0-9])+"/\1_xxxxxx"/g
|
|||
s/.*//g
|
||||
}
|
||||
}
|
||||
|
||||
# normalize long table shard name errors for alter_table_set_access_method and alter_distributed_table
|
||||
s/^(ERROR: child table is missing constraint "\w+)_([0-9])+"/\1_xxxxxx"/g
|
||||
s/^(DEBUG: the name of the shard \(abcde_01234567890123456789012345678901234567890_f7ff6612)_([0-9])+/\1_xxxxxx/g
|
||||
|
||||
# normalize long index name errors for multi_index_statements
|
||||
s/^(ERROR: The index name \(test_index_creation1_p2020_09_26)_([0-9])+_(tenant_id_timeperiod_idx)/\1_xxxxxx_\3/g
|
||||
s/^(DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26)_([0-9])+_(tenant_id_timeperiod_idx)/\1_xxxxxx_\3/g
|
||||
|
|
|
|||
|
|
@ -837,5 +837,85 @@ SELECT * FROM mat_view ORDER BY a;
|
|||
2 | 2
|
||||
(2 rows)
|
||||
|
||||
-- test long table names
|
||||
SET client_min_messages TO DEBUG1;
|
||||
CREATE TABLE abcde_0123456789012345678901234567890123456789012345678901234567890123456789 (x int, y int);
|
||||
NOTICE: identifier "abcde_0123456789012345678901234567890123456789012345678901234567890123456789" will be truncated to "abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
SELECT create_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'x');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
SELECT alter_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', distribution_column := 'y');
|
||||
DEBUG: the name of the shard (abcde_01234567890123456789012345678901234567890_f7ff6612_xxxxxx) for relation (abcde_012345678901234567890123456789012345678901234567890123456) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
NOTICE: creating a new table for alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
NOTICE: Moving the data of alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
DEBUG: cannot perform distributed INSERT INTO ... SELECT because the partition columns in the source table and subquery do not match
|
||||
DETAIL: The target table's partition column should correspond to a partition column in the subquery.
|
||||
CONTEXT: SQL statement "INSERT INTO alter_distributed_table.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 (x,y) SELECT x,y FROM alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
DEBUG: performing repartitioned INSERT ... SELECT
|
||||
CONTEXT: SQL statement "INSERT INTO alter_distributed_table.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 (x,y) SELECT x,y FROM alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
NOTICE: Dropping the old alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
CONTEXT: SQL statement "DROP TABLE alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456 CASCADE"
|
||||
NOTICE: Renaming the new table to alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
DEBUG: the name of the shard (abcde_01234567890123456789012345678901234567890_f7ff6612_xxxxxx) for relation (abcde_012345678901234567890123456789012345678901234567890123456) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
CONTEXT: SQL statement "ALTER TABLE alter_distributed_table.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 RENAME TO abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
alter_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
RESET client_min_messages;
|
||||
-- test long partitioned table names
|
||||
CREATE TABLE partition_lengths
|
||||
(
|
||||
tenant_id integer NOT NULL,
|
||||
timeperiod timestamp without time zone NOT NULL,
|
||||
inserted_utc timestamp without time zone NOT NULL DEFAULT now()
|
||||
) PARTITION BY RANGE (timeperiod);
|
||||
SELECT create_distributed_table('partition_lengths', 'tenant_id');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
CREATE TABLE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890 PARTITION OF partition_lengths FOR VALUES FROM ('2020-09-28 00:00:00') TO ('2020-09-29 00:00:00');
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
-- verify alter_distributed_table works with long partition names
|
||||
SELECT alter_distributed_table('partition_lengths', shard_count := 29, cascade_to_colocated := false);
|
||||
NOTICE: converting the partitions of alter_distributed_table.partition_lengths
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: Moving the data of alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths
|
||||
alter_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
-- test long partition table names
|
||||
ALTER TABLE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890 RENAME TO partition_lengths_p2020_09_28;
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
ALTER TABLE partition_lengths RENAME TO partition_lengths_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "partition_lengths_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_123456789012345678901234567890123456789012345"
|
||||
-- verify alter_distributed_table works with long partitioned table names
|
||||
SELECT alter_distributed_table('partition_lengths_12345678901234567890123456789012345678901234567890', shard_count := 17, cascade_to_colocated := false);
|
||||
NOTICE: converting the partitions of alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: Moving the data of alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
alter_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
SET client_min_messages TO WARNING;
|
||||
DROP SCHEMA alter_distributed_table CASCADE;
|
||||
|
|
|
|||
|
|
@ -816,5 +816,85 @@ SELECT * FROM mat_view ORDER BY a;
|
|||
2 | 2
|
||||
(2 rows)
|
||||
|
||||
-- test long table names
|
||||
SET client_min_messages TO DEBUG1;
|
||||
CREATE TABLE abcde_0123456789012345678901234567890123456789012345678901234567890123456789 (x int, y int);
|
||||
NOTICE: identifier "abcde_0123456789012345678901234567890123456789012345678901234567890123456789" will be truncated to "abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
SELECT create_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'x');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
SELECT alter_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', distribution_column := 'y');
|
||||
DEBUG: the name of the shard (abcde_01234567890123456789012345678901234567890_f7ff6612_xxxxxx) for relation (abcde_012345678901234567890123456789012345678901234567890123456) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
NOTICE: creating a new table for alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
NOTICE: Moving the data of alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
DEBUG: cannot perform distributed INSERT INTO ... SELECT because the partition columns in the source table and subquery do not match
|
||||
DETAIL: The target table's partition column should correspond to a partition column in the subquery.
|
||||
CONTEXT: SQL statement "INSERT INTO alter_distributed_table.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 (x,y) SELECT x,y FROM alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
DEBUG: performing repartitioned INSERT ... SELECT
|
||||
CONTEXT: SQL statement "INSERT INTO alter_distributed_table.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 (x,y) SELECT x,y FROM alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
NOTICE: Dropping the old alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
CONTEXT: SQL statement "DROP TABLE alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456 CASCADE"
|
||||
NOTICE: Renaming the new table to alter_distributed_table.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
DEBUG: the name of the shard (abcde_01234567890123456789012345678901234567890_f7ff6612_xxxxxx) for relation (abcde_012345678901234567890123456789012345678901234567890123456) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
CONTEXT: SQL statement "ALTER TABLE alter_distributed_table.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 RENAME TO abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
alter_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
RESET client_min_messages;
|
||||
-- test long partitioned table names
|
||||
CREATE TABLE partition_lengths
|
||||
(
|
||||
tenant_id integer NOT NULL,
|
||||
timeperiod timestamp without time zone NOT NULL,
|
||||
inserted_utc timestamp without time zone NOT NULL DEFAULT now()
|
||||
) PARTITION BY RANGE (timeperiod);
|
||||
SELECT create_distributed_table('partition_lengths', 'tenant_id');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
CREATE TABLE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890 PARTITION OF partition_lengths FOR VALUES FROM ('2020-09-28 00:00:00') TO ('2020-09-29 00:00:00');
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
-- verify alter_distributed_table works with long partition names
|
||||
SELECT alter_distributed_table('partition_lengths', shard_count := 29, cascade_to_colocated := false);
|
||||
NOTICE: converting the partitions of alter_distributed_table.partition_lengths
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: Moving the data of alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths_p2020_09_28_123456789012345678901234567890123
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths
|
||||
alter_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
-- test long partition table names
|
||||
ALTER TABLE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890 RENAME TO partition_lengths_p2020_09_28;
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
ALTER TABLE partition_lengths RENAME TO partition_lengths_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "partition_lengths_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_123456789012345678901234567890123456789012345"
|
||||
-- verify alter_distributed_table works with long partitioned table names
|
||||
SELECT alter_distributed_table('partition_lengths_12345678901234567890123456789012345678901234567890', shard_count := 17, cascade_to_colocated := false);
|
||||
NOTICE: converting the partitions of alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: Moving the data of alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths_p2020_09_28
|
||||
NOTICE: creating a new table for alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
NOTICE: Dropping the old alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
NOTICE: Renaming the new table to alter_distributed_table.partition_lengths_123456789012345678901234567890123456789012345
|
||||
alter_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
SET client_min_messages TO WARNING;
|
||||
DROP SCHEMA alter_distributed_table CASCADE;
|
||||
|
|
|
|||
|
|
@ -681,6 +681,40 @@ CREATE TABLE identity_cols_test (a int, b int generated by default as identity (
|
|||
SELECT alter_table_set_access_method('identity_cols_test', 'columnar');
|
||||
ERROR: cannot complete command because relation alter_table_set_access_method.identity_cols_test has identity column
|
||||
HINT: Drop the identity columns and re-try the command
|
||||
-- test long table names
|
||||
SET client_min_messages TO DEBUG1;
|
||||
CREATE TABLE abcde_0123456789012345678901234567890123456789012345678901234567890123456789 (x int, y int);
|
||||
NOTICE: identifier "abcde_0123456789012345678901234567890123456789012345678901234567890123456789" will be truncated to "abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
SELECT create_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'x');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
SELECT alter_table_set_access_method('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'columnar');
|
||||
DEBUG: the name of the shard (abcde_01234567890123456789012345678901234567890_f7ff6612_xxxxxx) for relation (abcde_012345678901234567890123456789012345678901234567890123456) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
NOTICE: creating a new table for alter_table_set_access_method.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
DEBUG: pathlist hook for columnar table am
|
||||
CONTEXT: SQL statement "SELECT EXISTS (SELECT 1 FROM alter_table_set_access_method.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162)"
|
||||
NOTICE: Moving the data of alter_table_set_access_method.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
NOTICE: Dropping the old alter_table_set_access_method.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
CONTEXT: SQL statement "DROP TABLE alter_table_set_access_method.abcde_012345678901234567890123456789012345678901234567890123456 CASCADE"
|
||||
NOTICE: Renaming the new table to alter_table_set_access_method.abcde_012345678901234567890123456789012345678901234567890123456
|
||||
DEBUG: the name of the shard (abcde_01234567890123456789012345678901234567890_f7ff6612_xxxxxx) for relation (abcde_012345678901234567890123456789012345678901234567890123456) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
CONTEXT: SQL statement "ALTER TABLE alter_table_set_access_method.abcde_0123456789012345678901234567890123456_f7ff6612_4160710162 RENAME TO abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
alter_table_set_access_method
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
SELECT * FROM abcde_0123456789012345678901234567890123456789012345678901234567890123456789;
|
||||
NOTICE: identifier "abcde_0123456789012345678901234567890123456789012345678901234567890123456789" will be truncated to "abcde_012345678901234567890123456789012345678901234567890123456"
|
||||
DEBUG: pathlist hook for columnar table am
|
||||
x | y
|
||||
---------------------------------------------------------------------
|
||||
(0 rows)
|
||||
|
||||
RESET client_min_messages;
|
||||
SET client_min_messages TO WARNING;
|
||||
DROP SCHEMA alter_table_set_access_method CASCADE;
|
||||
SELECT 1 FROM master_remove_node('localhost', :master_port);
|
||||
|
|
|
|||
|
|
@ -9,7 +9,7 @@ CREATE TABLE simple_table (
|
|||
id bigint
|
||||
);
|
||||
SELECT master_get_table_ddl_events('simple_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.simple_table (first_name text, last_name text, id bigint)
|
||||
ALTER TABLE public.simple_table OWNER TO postgres
|
||||
|
|
@ -21,7 +21,7 @@ CREATE TABLE not_null_table (
|
|||
id bigint not null
|
||||
);
|
||||
SELECT master_get_table_ddl_events('not_null_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.not_null_table (city text, id bigint NOT NULL)
|
||||
ALTER TABLE public.not_null_table OWNER TO postgres
|
||||
|
|
@ -34,7 +34,7 @@ CREATE TABLE column_constraint_table (
|
|||
age int CONSTRAINT non_negative_age CHECK (age >= 0)
|
||||
);
|
||||
SELECT master_get_table_ddl_events('column_constraint_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.column_constraint_table (first_name text, last_name text, age integer, CONSTRAINT non_negative_age CHECK ((age >= 0)))
|
||||
ALTER TABLE public.column_constraint_table OWNER TO postgres
|
||||
|
|
@ -48,7 +48,7 @@ CREATE TABLE table_constraint_table (
|
|||
CONSTRAINT bids_ordered CHECK (min_bid > max_bid)
|
||||
);
|
||||
SELECT master_get_table_ddl_events('table_constraint_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.table_constraint_table (bid_item_id bigint, min_bid numeric NOT NULL, max_bid numeric NOT NULL, CONSTRAINT bids_ordered CHECK ((min_bid > max_bid)))
|
||||
ALTER TABLE public.table_constraint_table OWNER TO postgres
|
||||
|
|
@ -67,7 +67,7 @@ SELECT create_distributed_table('check_constraint_table_1', 'id');
|
|||
(1 row)
|
||||
|
||||
SELECT master_get_table_ddl_events('check_constraint_table_1');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.check_constraint_table_1 (id integer, b boolean, CONSTRAINT check_constraint_table_1_b_check CHECK (b))
|
||||
ALTER TABLE public.check_constraint_table_1 OWNER TO postgres
|
||||
|
|
@ -84,7 +84,7 @@ SELECT create_distributed_table('check_constraint_table_2', 'id');
|
|||
(1 row)
|
||||
|
||||
SELECT master_get_table_ddl_events('check_constraint_table_2');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.check_constraint_table_2 (id integer, CONSTRAINT check_constraint_table_2_check CHECK (true))
|
||||
ALTER TABLE public.check_constraint_table_2 OWNER TO postgres
|
||||
|
|
@ -96,7 +96,7 @@ CREATE TABLE default_value_table (
|
|||
price decimal default 0.00
|
||||
);
|
||||
SELECT master_get_table_ddl_events('default_value_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.default_value_table (name text, price numeric DEFAULT 0.00)
|
||||
ALTER TABLE public.default_value_table OWNER TO postgres
|
||||
|
|
@ -109,7 +109,7 @@ CREATE TABLE pkey_table (
|
|||
id bigint PRIMARY KEY
|
||||
);
|
||||
SELECT master_get_table_ddl_events('pkey_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.pkey_table (first_name text, last_name text, id bigint NOT NULL)
|
||||
ALTER TABLE public.pkey_table OWNER TO postgres
|
||||
|
|
@ -122,7 +122,7 @@ CREATE TABLE unique_table (
|
|||
username text UNIQUE not null
|
||||
);
|
||||
SELECT master_get_table_ddl_events('unique_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.unique_table (user_id bigint NOT NULL, username text NOT NULL)
|
||||
ALTER TABLE public.unique_table OWNER TO postgres
|
||||
|
|
@ -137,7 +137,7 @@ CREATE TABLE clustered_table (
|
|||
CREATE INDEX clustered_time_idx ON clustered_table (received_at);
|
||||
CLUSTER clustered_table USING clustered_time_idx;
|
||||
SELECT master_get_table_ddl_events('clustered_table');
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE TABLE public.clustered_table (data json NOT NULL, received_at timestamp without time zone NOT NULL)
|
||||
ALTER TABLE public.clustered_table OWNER TO postgres
|
||||
|
|
@ -178,30 +178,33 @@ NOTICE: foreign-data wrapper "fake_fdw" does not have an extension defined
|
|||
|
||||
(1 row)
|
||||
|
||||
ALTER FOREIGN TABLE foreign_table rename to renamed_foreign_table;
|
||||
ALTER FOREIGN TABLE renamed_foreign_table rename full_name to rename_name;
|
||||
ALTER FOREIGN TABLE renamed_foreign_table alter rename_name type char(8);
|
||||
ALTER FOREIGN TABLE foreign_table rename to renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890" will be truncated to "renamed_foreign_table_with_long_name_12345678901234567890123456"
|
||||
ALTER FOREIGN TABLE renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890 rename full_name to rename_name;
|
||||
NOTICE: identifier "renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890" will be truncated to "renamed_foreign_table_with_long_name_12345678901234567890123456"
|
||||
ALTER FOREIGN TABLE renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890 alter rename_name type char(8);
|
||||
NOTICE: identifier "renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890" will be truncated to "renamed_foreign_table_with_long_name_12345678901234567890123456"
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
select table_name, column_name, data_type
|
||||
from information_schema.columns
|
||||
where table_schema='public' and table_name like 'renamed_foreign_table_%' and column_name <> 'id'
|
||||
order by table_name;
|
||||
table_name | column_name | data_type
|
||||
table_name | column_name | data_type
|
||||
---------------------------------------------------------------------
|
||||
renamed_foreign_table_610008 | rename_name | character
|
||||
renamed_foreign_table_610009 | rename_name | character
|
||||
renamed_foreign_table_610010 | rename_name | character
|
||||
renamed_foreign_table_610011 | rename_name | character
|
||||
renamed_foreign_table_with_long_name_1234567890_6a8dd6f8_610008 | rename_name | character
|
||||
renamed_foreign_table_with_long_name_1234567890_6a8dd6f8_610009 | rename_name | character
|
||||
renamed_foreign_table_with_long_name_1234567890_6a8dd6f8_610010 | rename_name | character
|
||||
renamed_foreign_table_with_long_name_1234567890_6a8dd6f8_610011 | rename_name | character
|
||||
(4 rows)
|
||||
|
||||
\c - - :master_host :master_port
|
||||
SELECT master_get_table_ddl_events('renamed_foreign_table');
|
||||
SELECT master_get_table_ddl_events('renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890');
|
||||
NOTICE: foreign-data wrapper "fake_fdw" does not have an extension defined
|
||||
master_get_table_ddl_events
|
||||
master_get_table_ddl_events
|
||||
---------------------------------------------------------------------
|
||||
CREATE SERVER IF NOT EXISTS fake_fdw_server FOREIGN DATA WRAPPER fake_fdw
|
||||
CREATE FOREIGN TABLE public.renamed_foreign_table (id bigint NOT NULL, rename_name character(8) DEFAULT ''::text NOT NULL) SERVER fake_fdw_server OPTIONS (encoding 'utf-8', compression 'true')
|
||||
ALTER TABLE public.renamed_foreign_table OWNER TO postgres
|
||||
CREATE FOREIGN TABLE public.renamed_foreign_table_with_long_name_12345678901234567890123456 (id bigint NOT NULL, rename_name character(8) DEFAULT ''::text NOT NULL) SERVER fake_fdw_server OPTIONS (encoding 'utf-8', compression 'true')
|
||||
ALTER TABLE public.renamed_foreign_table_with_long_name_12345678901234567890123456 OWNER TO postgres
|
||||
(3 rows)
|
||||
|
||||
-- propagating views is not supported
|
||||
|
|
@ -210,7 +213,8 @@ SELECT master_get_table_ddl_events('local_view');
|
|||
ERROR: local_view is not a regular, foreign or partitioned table
|
||||
-- clean up
|
||||
DROP VIEW IF EXISTS local_view;
|
||||
DROP FOREIGN TABLE IF EXISTS renamed_foreign_table;
|
||||
DROP FOREIGN TABLE IF EXISTS renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890" will be truncated to "renamed_foreign_table_with_long_name_12345678901234567890123456"
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
select table_name, column_name, data_type
|
||||
from information_schema.columns
|
||||
|
|
|
|||
|
|
@ -362,13 +362,13 @@ SET client_min_messages TO DEBUG1;
|
|||
CREATE INDEX ix_test_index_creation2
|
||||
ON test_index_creation1 USING btree
|
||||
(tenant_id, timeperiod);
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_10311_tenant_id_timeperiod_idx
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_xxxxxx_tenant_id_timeperiod_idx
|
||||
-- same test with schema qualified
|
||||
SET search_path TO public;
|
||||
CREATE INDEX ix_test_index_creation3
|
||||
ON multi_index_statements.test_index_creation1 USING btree
|
||||
(tenant_id, timeperiod);
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_10311_tenant_id_timeperiod_idx
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_xxxxxx_tenant_id_timeperiod_idx
|
||||
SET search_path TO multi_index_statements;
|
||||
-- we cannot switch to sequential execution
|
||||
-- after a parallel query
|
||||
|
|
@ -382,7 +382,7 @@ BEGIN;
|
|||
CREATE INDEX ix_test_index_creation4
|
||||
ON test_index_creation1 USING btree
|
||||
(tenant_id, timeperiod);
|
||||
ERROR: The index name (test_index_creation1_p2020_09_26_10311_tenant_id_timeperiod_idx) on a shard is too long and could lead to deadlocks when executed in a transaction block after a parallel query
|
||||
ERROR: The index name (test_index_creation1_p2020_09_26_xxxxxx_tenant_id_timeperiod_idx) on a shard is too long and could lead to deadlocks when executed in a transaction block after a parallel query
|
||||
HINT: Try re-running the transaction with "SET LOCAL citus.multi_shard_modify_mode TO 'sequential';"
|
||||
ROLLBACK;
|
||||
-- try inside a sequential block
|
||||
|
|
@ -397,7 +397,7 @@ BEGIN;
|
|||
CREATE INDEX ix_test_index_creation4
|
||||
ON test_index_creation1 USING btree
|
||||
(tenant_id, timeperiod);
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_10311_tenant_id_timeperiod_idx
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_xxxxxx_tenant_id_timeperiod_idx
|
||||
ROLLBACK;
|
||||
-- should be able to create indexes with INCLUDE/WHERE
|
||||
CREATE INDEX ix_test_index_creation5 ON test_index_creation1
|
||||
|
|
@ -406,7 +406,7 @@ CREATE INDEX ix_test_index_creation5 ON test_index_creation1
|
|||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_2_tenant_id_timeperiod_field1_idx
|
||||
CREATE UNIQUE INDEX ix_test_index_creation6 ON test_index_creation1
|
||||
USING btree(tenant_id, timeperiod);
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_10311_tenant_id_timeperiod_idx
|
||||
DEBUG: the index name on the shards of the partition is too long, switching to sequential and local execution mode to prevent self deadlocks: test_index_creation1_p2020_09_26_xxxxxx_tenant_id_timeperiod_idx
|
||||
-- should be able to create short named indexes in parallel
|
||||
-- as the table/index name is short
|
||||
CREATE INDEX f1
|
||||
|
|
|
|||
|
|
@ -125,13 +125,112 @@ SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.name_len
|
|||
(1 row)
|
||||
|
||||
\c - - :master_host :master_port
|
||||
-- Placeholders for RENAME operations
|
||||
\set VERBOSITY TERSE
|
||||
-- Rename the table to a too-long name
|
||||
SET client_min_messages TO DEBUG1;
|
||||
SET citus.force_max_query_parallelization TO ON;
|
||||
ALTER TABLE name_lengths RENAME TO name_len_12345678901234567890123456789012345678901234567890;
|
||||
ERROR: shard name name_len_12345678901234567890123456789012345678_fcd8ab6f_xxxxx exceeds 63 characters
|
||||
DEBUG: the name of the shard (name_len_12345678901234567890123456789012345678_fcd8ab6f_xxxxx) for relation (name_len_12345678901234567890123456789012345678901234567890) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
SELECT * FROM name_len_12345678901234567890123456789012345678901234567890;
|
||||
col1 | col2 | float_col_12345678901234567890123456789012345678901234567890 | date_col_12345678901234567890123456789012345678901234567890 | int_col_12345678901234567890123456789012345678901234567890
|
||||
---------------------------------------------------------------------
|
||||
(0 rows)
|
||||
|
||||
ALTER TABLE name_len_12345678901234567890123456789012345678901234567890 RENAME TO name_lengths;
|
||||
SELECT * FROM name_lengths;
|
||||
col1 | col2 | float_col_12345678901234567890123456789012345678901234567890 | date_col_12345678901234567890123456789012345678901234567890 | int_col_12345678901234567890123456789012345678901234567890
|
||||
---------------------------------------------------------------------
|
||||
(0 rows)
|
||||
|
||||
-- Test renames on zero shard distributed tables
|
||||
CREATE TABLE append_zero_shard_table (a int);
|
||||
SELECT create_distributed_table('append_zero_shard_table', 'a', 'append');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
ALTER TABLE append_zero_shard_table rename TO append_zero_shard_table_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "append_zero_shard_table_12345678901234567890123456789012345678901234567890" will be truncated to "append_zero_shard_table_123456789012345678901234567890123456789"
|
||||
-- Verify that we do not support long renames after parallel queries are executed in transaction block
|
||||
BEGIN;
|
||||
ALTER TABLE name_lengths rename col1 to new_column_name;
|
||||
ALTER TABLE name_lengths RENAME TO name_len_12345678901234567890123456789012345678901234567890;
|
||||
ERROR: Shard name (name_len_12345678901234567890123456789012345678_fcd8ab6f_xxxxx) for table (name_len_12345678901234567890123456789012345678901234567890) is too long and could lead to deadlocks when executed in a transaction block after a parallel query
|
||||
HINT: Try re-running the transaction with "SET LOCAL citus.multi_shard_modify_mode TO 'sequential';"
|
||||
ROLLBACK;
|
||||
-- The same operation will work when sequential mode is set
|
||||
BEGIN;
|
||||
SET LOCAL citus.multi_shard_modify_mode TO 'sequential';
|
||||
ALTER TABLE name_lengths rename col1 to new_column_name;
|
||||
ALTER TABLE name_lengths RENAME TO name_len_12345678901234567890123456789012345678901234567890;
|
||||
DEBUG: the name of the shard (name_len_12345678901234567890123456789012345678_fcd8ab6f_xxxxx) for relation (name_len_12345678901234567890123456789012345678901234567890) is too long, switching to sequential and local execution mode to prevent self deadlocks
|
||||
ROLLBACK;
|
||||
RESET client_min_messages;
|
||||
-- test long partitioned table renames
|
||||
SET citus.shard_replication_factor TO 1;
|
||||
CREATE TABLE partition_lengths
|
||||
(
|
||||
tenant_id integer NOT NULL,
|
||||
timeperiod timestamp without time zone NOT NULL
|
||||
) PARTITION BY RANGE (timeperiod);
|
||||
SELECT create_distributed_table('partition_lengths', 'tenant_id');
|
||||
create_distributed_table
|
||||
---------------------------------------------------------------------
|
||||
|
||||
(1 row)
|
||||
|
||||
CREATE TABLE partition_lengths_p2020_09_28 PARTITION OF partition_lengths FOR VALUES FROM ('2020-09-28 00:00:00') TO ('2020-09-29 00:00:00');
|
||||
-- verify that we can rename partitioned tables and partitions to too-long names
|
||||
ALTER TABLE partition_lengths RENAME TO partition_lengths_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "partition_lengths_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_123456789012345678901234567890123456789012345"
|
||||
-- verify that we can rename partitioned tables and partitions with too-long names
|
||||
ALTER TABLE partition_lengths_12345678901234567890123456789012345678901234567890 RENAME TO partition_lengths;
|
||||
NOTICE: identifier "partition_lengths_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_123456789012345678901234567890123456789012345"
|
||||
-- Placeholders for unsupported operations
|
||||
\set VERBOSITY TERSE
|
||||
-- renaming distributed table partitions
|
||||
ALTER TABLE partition_lengths_p2020_09_28 RENAME TO partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
-- creating or attaching new partitions with long names create deadlocks
|
||||
CREATE TABLE partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890 (LIKE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890);
|
||||
NOTICE: identifier "partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_29_123456789012345678901234567890123"
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
ALTER TABLE partition_lengths
|
||||
ATTACH PARTITION partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890
|
||||
FOR VALUES FROM ('2020-09-29 00:00:00') TO ('2020-09-30 00:00:00');
|
||||
NOTICE: identifier "partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_29_123456789012345678901234567890123"
|
||||
ERROR: canceling the transaction since it was involved in a distributed deadlock
|
||||
CREATE TABLE partition_lengths_p2020_09_30_12345678901234567890123456789012345678901234567890
|
||||
PARTITION OF partition_lengths
|
||||
FOR VALUES FROM ('2020-09-30 00:00:00') TO ('2020-10-01 00:00:00');
|
||||
NOTICE: identifier "partition_lengths_p2020_09_30_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_30_123456789012345678901234567890123"
|
||||
ERROR: canceling the transaction since it was involved in a distributed deadlock
|
||||
DROP TABLE partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_29_123456789012345678901234567890123"
|
||||
-- creating or attaching new partitions with long names work when using sequential shard modify mode
|
||||
BEGIN;
|
||||
SET LOCAL citus.multi_shard_modify_mode = sequential;
|
||||
CREATE TABLE partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890 (LIKE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890);
|
||||
NOTICE: identifier "partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_29_123456789012345678901234567890123"
|
||||
NOTICE: identifier "partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_28_123456789012345678901234567890123"
|
||||
ALTER TABLE partition_lengths
|
||||
ATTACH PARTITION partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890
|
||||
FOR VALUES FROM ('2020-09-29 00:00:00') TO ('2020-09-30 00:00:00');
|
||||
NOTICE: identifier "partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_29_123456789012345678901234567890123"
|
||||
CREATE TABLE partition_lengths_p2020_09_30_12345678901234567890123456789012345678901234567890
|
||||
PARTITION OF partition_lengths
|
||||
FOR VALUES FROM ('2020-09-30 00:00:00') TO ('2020-10-01 00:00:00');
|
||||
NOTICE: identifier "partition_lengths_p2020_09_30_12345678901234567890123456789012345678901234567890" will be truncated to "partition_lengths_p2020_09_30_123456789012345678901234567890123"
|
||||
ROLLBACK;
|
||||
-- renaming distributed table constraints are not supported
|
||||
ALTER TABLE name_lengths RENAME CONSTRAINT unique_12345678901234567890123456789012345678901234567890 TO unique2_12345678901234567890123456789012345678901234567890;
|
||||
ERROR: renaming constraints belonging to distributed tables is currently unsupported
|
||||
DROP TABLE partition_lengths CASCADE;
|
||||
\set VERBOSITY DEFAULT
|
||||
-- Verify that we can create indexes with very long names on zero shard tables.
|
||||
CREATE INDEX append_zero_shard_table_idx_12345678901234567890123456789012345678901234567890 ON append_zero_shard_table_12345678901234567890123456789012345678901234567890(a);
|
||||
NOTICE: identifier "append_zero_shard_table_idx_12345678901234567890123456789012345678901234567890" will be truncated to "append_zero_shard_table_idx_12345678901234567890123456789012345"
|
||||
NOTICE: identifier "append_zero_shard_table_12345678901234567890123456789012345678901234567890" will be truncated to "append_zero_shard_table_123456789012345678901234567890123456789"
|
||||
-- Verify that CREATE INDEX on already distributed table has proper shard names.
|
||||
CREATE INDEX tmp_idx_12345678901234567890123456789012345678901234567890 ON name_lengths(col2);
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
|
|
@ -148,15 +247,19 @@ SELECT "relname", "Column", "Type", "Definition" FROM index_attrs WHERE
|
|||
-- by the parser/rewriter before further processing, just as in Postgres.
|
||||
CREATE INDEX tmp_idx_123456789012345678901234567890123456789012345678901234567890 ON name_lengths(col2);
|
||||
NOTICE: identifier "tmp_idx_123456789012345678901234567890123456789012345678901234567890" will be truncated to "tmp_idx_1234567890123456789012345678901234567890123456789012345"
|
||||
-- Verify we can rename indexes with long names
|
||||
ALTER INDEX tmp_idx_123456789012345678901234567890123456789012345678901234567890 RENAME TO tmp_idx_newname_123456789012345678901234567890123456789012345678901234567890;
|
||||
NOTICE: identifier "tmp_idx_123456789012345678901234567890123456789012345678901234567890" will be truncated to "tmp_idx_1234567890123456789012345678901234567890123456789012345"
|
||||
NOTICE: identifier "tmp_idx_newname_123456789012345678901234567890123456789012345678901234567890" will be truncated to "tmp_idx_newname_12345678901234567890123456789012345678901234567"
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
SELECT "relname", "Column", "Type", "Definition" FROM index_attrs WHERE
|
||||
relname LIKE 'tmp_idx_%' ORDER BY 1 DESC, 2 DESC, 3 DESC, 4 DESC;
|
||||
relname | Column | Type | Definition
|
||||
---------------------------------------------------------------------
|
||||
tmp_idx_newname_1234567890123456789012345678901_c54e849b_225003 | col2 | integer | col2
|
||||
tmp_idx_newname_1234567890123456789012345678901_c54e849b_225002 | col2 | integer | col2
|
||||
tmp_idx_123456789012345678901234567890123456789_5e470afa_225003 | col2 | integer | col2
|
||||
tmp_idx_123456789012345678901234567890123456789_5e470afa_225002 | col2 | integer | col2
|
||||
tmp_idx_123456789012345678901234567890123456789_599636aa_225003 | col2 | integer | col2
|
||||
tmp_idx_123456789012345678901234567890123456789_599636aa_225002 | col2 | integer | col2
|
||||
(4 rows)
|
||||
|
||||
\c - - :master_host :master_port
|
||||
|
|
@ -208,14 +311,14 @@ SELECT master_create_worker_shards('sneaky_name_lengths', '2', '2');
|
|||
(1 row)
|
||||
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
\di public.sneaky*225006
|
||||
\di public.sneaky*225030
|
||||
List of relations
|
||||
Schema | Name | Type | Owner | Table
|
||||
---------------------------------------------------------------------
|
||||
public | sneaky_name_lengths_int_col_1234567890123456789_6402d2cd_225006 | index | postgres | sneaky_name_lengths_225006
|
||||
public | sneaky_name_lengths_int_col_1234567890123456789_6402d2cd_225030 | index | postgres | sneaky_name_lengths_225030
|
||||
(1 row)
|
||||
|
||||
SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.sneaky_name_lengths_225006'::regclass ORDER BY 1 DESC, 2 DESC;
|
||||
SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.sneaky_name_lengths_225030'::regclass ORDER BY 1 DESC, 2 DESC;
|
||||
Constraint | Definition
|
||||
---------------------------------------------------------------------
|
||||
checky_12345678901234567890123456789012345678901234567890 | CHECK (int_col_123456789012345678901234567890123456789012345678901234 > 100)
|
||||
|
|
@ -239,11 +342,11 @@ SELECT create_distributed_table('sneaky_name_lengths', 'col1', 'hash');
|
|||
(1 row)
|
||||
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
\di unique*225008
|
||||
\di unique*225032
|
||||
List of relations
|
||||
Schema | Name | Type | Owner | Table
|
||||
---------------------------------------------------------------------
|
||||
public | unique_1234567890123456789012345678901234567890_a5986f27_225008 | index | postgres | sneaky_name_lengths_225008
|
||||
public | unique_1234567890123456789012345678901234567890_a5986f27_225032 | index | postgres | sneaky_name_lengths_225032
|
||||
(1 row)
|
||||
|
||||
\c - - :master_host :master_port
|
||||
|
|
@ -336,3 +439,4 @@ DROP TABLE multi_name_lengths.too_long_12345678901234567890123456789012345678901
|
|||
-- Clean up.
|
||||
DROP TABLE name_lengths CASCADE;
|
||||
DROP TABLE U&"elephant_!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D" UESCAPE '!' CASCADE;
|
||||
RESET citus.force_max_query_parallelization;
|
||||
|
|
|
|||
|
|
@ -3,6 +3,7 @@
|
|||
CREATE SCHEMA null_parameters;
|
||||
SET search_path TO null_parameters;
|
||||
SET citus.next_shard_id TO 1680000;
|
||||
SET citus.shard_count to 32;
|
||||
CREATE TABLE text_dist_column (key text, value text);
|
||||
SELECT create_distributed_table('text_dist_column', 'key');
|
||||
create_distributed_table
|
||||
|
|
|
|||
|
|
@ -280,5 +280,33 @@ CREATE MATERIALIZED VIEW mat_view AS SELECT * FROM mat_view_test;
|
|||
SELECT alter_distributed_table('mat_view_test', shard_count := 5, cascade_to_colocated := false);
|
||||
SELECT * FROM mat_view ORDER BY a;
|
||||
|
||||
-- test long table names
|
||||
SET client_min_messages TO DEBUG1;
|
||||
CREATE TABLE abcde_0123456789012345678901234567890123456789012345678901234567890123456789 (x int, y int);
|
||||
SELECT create_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'x');
|
||||
SELECT alter_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', distribution_column := 'y');
|
||||
RESET client_min_messages;
|
||||
|
||||
-- test long partitioned table names
|
||||
CREATE TABLE partition_lengths
|
||||
(
|
||||
tenant_id integer NOT NULL,
|
||||
timeperiod timestamp without time zone NOT NULL,
|
||||
inserted_utc timestamp without time zone NOT NULL DEFAULT now()
|
||||
) PARTITION BY RANGE (timeperiod);
|
||||
|
||||
SELECT create_distributed_table('partition_lengths', 'tenant_id');
|
||||
CREATE TABLE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890 PARTITION OF partition_lengths FOR VALUES FROM ('2020-09-28 00:00:00') TO ('2020-09-29 00:00:00');
|
||||
|
||||
-- verify alter_distributed_table works with long partition names
|
||||
SELECT alter_distributed_table('partition_lengths', shard_count := 29, cascade_to_colocated := false);
|
||||
|
||||
-- test long partition table names
|
||||
ALTER TABLE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890 RENAME TO partition_lengths_p2020_09_28;
|
||||
ALTER TABLE partition_lengths RENAME TO partition_lengths_12345678901234567890123456789012345678901234567890;
|
||||
|
||||
-- verify alter_distributed_table works with long partitioned table names
|
||||
SELECT alter_distributed_table('partition_lengths_12345678901234567890123456789012345678901234567890', shard_count := 17, cascade_to_colocated := false);
|
||||
|
||||
SET client_min_messages TO WARNING;
|
||||
DROP SCHEMA alter_distributed_table CASCADE;
|
||||
|
|
|
|||
|
|
@ -213,6 +213,14 @@ CREATE TABLE identity_cols_test (a int, b int generated by default as identity (
|
|||
-- errors out since we don't support alter_table.* udfs with tables having any identity columns
|
||||
SELECT alter_table_set_access_method('identity_cols_test', 'columnar');
|
||||
|
||||
-- test long table names
|
||||
SET client_min_messages TO DEBUG1;
|
||||
CREATE TABLE abcde_0123456789012345678901234567890123456789012345678901234567890123456789 (x int, y int);
|
||||
SELECT create_distributed_table('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'x');
|
||||
SELECT alter_table_set_access_method('abcde_0123456789012345678901234567890123456789012345678901234567890123456789', 'columnar');
|
||||
SELECT * FROM abcde_0123456789012345678901234567890123456789012345678901234567890123456789;
|
||||
RESET client_min_messages;
|
||||
|
||||
SET client_min_messages TO WARNING;
|
||||
DROP SCHEMA alter_table_set_access_method CASCADE;
|
||||
SELECT 1 FROM master_remove_node('localhost', :master_port);
|
||||
|
|
|
|||
|
|
@ -123,9 +123,9 @@ CREATE FOREIGN TABLE foreign_table (
|
|||
) SERVER fake_fdw_server OPTIONS (encoding 'utf-8', compression 'true');
|
||||
|
||||
SELECT create_distributed_table('foreign_table', 'id');
|
||||
ALTER FOREIGN TABLE foreign_table rename to renamed_foreign_table;
|
||||
ALTER FOREIGN TABLE renamed_foreign_table rename full_name to rename_name;
|
||||
ALTER FOREIGN TABLE renamed_foreign_table alter rename_name type char(8);
|
||||
ALTER FOREIGN TABLE foreign_table rename to renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890;
|
||||
ALTER FOREIGN TABLE renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890 rename full_name to rename_name;
|
||||
ALTER FOREIGN TABLE renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890 alter rename_name type char(8);
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
select table_name, column_name, data_type
|
||||
from information_schema.columns
|
||||
|
|
@ -133,7 +133,7 @@ where table_schema='public' and table_name like 'renamed_foreign_table_%' and co
|
|||
order by table_name;
|
||||
\c - - :master_host :master_port
|
||||
|
||||
SELECT master_get_table_ddl_events('renamed_foreign_table');
|
||||
SELECT master_get_table_ddl_events('renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890');
|
||||
|
||||
-- propagating views is not supported
|
||||
CREATE VIEW local_view AS SELECT * FROM simple_table;
|
||||
|
|
@ -142,7 +142,7 @@ SELECT master_get_table_ddl_events('local_view');
|
|||
|
||||
-- clean up
|
||||
DROP VIEW IF EXISTS local_view;
|
||||
DROP FOREIGN TABLE IF EXISTS renamed_foreign_table;
|
||||
DROP FOREIGN TABLE IF EXISTS renamed_foreign_table_with_long_name_12345678901234567890123456789012345678901234567890;
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
select table_name, column_name, data_type
|
||||
from information_schema.columns
|
||||
|
|
|
|||
|
|
@ -84,13 +84,89 @@ ALTER TABLE name_lengths ADD CONSTRAINT nl_checky_123456789012345678901234567890
|
|||
SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.name_lengths_225002'::regclass ORDER BY 1 DESC, 2 DESC;
|
||||
\c - - :master_host :master_port
|
||||
|
||||
-- Placeholders for RENAME operations
|
||||
\set VERBOSITY TERSE
|
||||
-- Rename the table to a too-long name
|
||||
SET client_min_messages TO DEBUG1;
|
||||
SET citus.force_max_query_parallelization TO ON;
|
||||
ALTER TABLE name_lengths RENAME TO name_len_12345678901234567890123456789012345678901234567890;
|
||||
SELECT * FROM name_len_12345678901234567890123456789012345678901234567890;
|
||||
ALTER TABLE name_len_12345678901234567890123456789012345678901234567890 RENAME TO name_lengths;
|
||||
SELECT * FROM name_lengths;
|
||||
|
||||
-- Test renames on zero shard distributed tables
|
||||
CREATE TABLE append_zero_shard_table (a int);
|
||||
SELECT create_distributed_table('append_zero_shard_table', 'a', 'append');
|
||||
ALTER TABLE append_zero_shard_table rename TO append_zero_shard_table_12345678901234567890123456789012345678901234567890;
|
||||
|
||||
|
||||
-- Verify that we do not support long renames after parallel queries are executed in transaction block
|
||||
BEGIN;
|
||||
ALTER TABLE name_lengths rename col1 to new_column_name;
|
||||
ALTER TABLE name_lengths RENAME TO name_len_12345678901234567890123456789012345678901234567890;
|
||||
ROLLBACK;
|
||||
|
||||
-- The same operation will work when sequential mode is set
|
||||
BEGIN;
|
||||
SET LOCAL citus.multi_shard_modify_mode TO 'sequential';
|
||||
ALTER TABLE name_lengths rename col1 to new_column_name;
|
||||
ALTER TABLE name_lengths RENAME TO name_len_12345678901234567890123456789012345678901234567890;
|
||||
ROLLBACK;
|
||||
|
||||
RESET client_min_messages;
|
||||
|
||||
-- test long partitioned table renames
|
||||
SET citus.shard_replication_factor TO 1;
|
||||
CREATE TABLE partition_lengths
|
||||
(
|
||||
tenant_id integer NOT NULL,
|
||||
timeperiod timestamp without time zone NOT NULL
|
||||
) PARTITION BY RANGE (timeperiod);
|
||||
|
||||
SELECT create_distributed_table('partition_lengths', 'tenant_id');
|
||||
CREATE TABLE partition_lengths_p2020_09_28 PARTITION OF partition_lengths FOR VALUES FROM ('2020-09-28 00:00:00') TO ('2020-09-29 00:00:00');
|
||||
|
||||
-- verify that we can rename partitioned tables and partitions to too-long names
|
||||
ALTER TABLE partition_lengths RENAME TO partition_lengths_12345678901234567890123456789012345678901234567890;
|
||||
|
||||
-- verify that we can rename partitioned tables and partitions with too-long names
|
||||
ALTER TABLE partition_lengths_12345678901234567890123456789012345678901234567890 RENAME TO partition_lengths;
|
||||
|
||||
-- Placeholders for unsupported operations
|
||||
\set VERBOSITY TERSE
|
||||
|
||||
-- renaming distributed table partitions
|
||||
ALTER TABLE partition_lengths_p2020_09_28 RENAME TO partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890;
|
||||
|
||||
-- creating or attaching new partitions with long names create deadlocks
|
||||
CREATE TABLE partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890 (LIKE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890);
|
||||
ALTER TABLE partition_lengths
|
||||
ATTACH PARTITION partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890
|
||||
FOR VALUES FROM ('2020-09-29 00:00:00') TO ('2020-09-30 00:00:00');
|
||||
CREATE TABLE partition_lengths_p2020_09_30_12345678901234567890123456789012345678901234567890
|
||||
PARTITION OF partition_lengths
|
||||
FOR VALUES FROM ('2020-09-30 00:00:00') TO ('2020-10-01 00:00:00');
|
||||
DROP TABLE partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890;
|
||||
|
||||
-- creating or attaching new partitions with long names work when using sequential shard modify mode
|
||||
BEGIN;
|
||||
SET LOCAL citus.multi_shard_modify_mode = sequential;
|
||||
CREATE TABLE partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890 (LIKE partition_lengths_p2020_09_28_12345678901234567890123456789012345678901234567890);
|
||||
ALTER TABLE partition_lengths
|
||||
ATTACH PARTITION partition_lengths_p2020_09_29_12345678901234567890123456789012345678901234567890
|
||||
FOR VALUES FROM ('2020-09-29 00:00:00') TO ('2020-09-30 00:00:00');
|
||||
CREATE TABLE partition_lengths_p2020_09_30_12345678901234567890123456789012345678901234567890
|
||||
PARTITION OF partition_lengths
|
||||
FOR VALUES FROM ('2020-09-30 00:00:00') TO ('2020-10-01 00:00:00');
|
||||
ROLLBACK;
|
||||
|
||||
-- renaming distributed table constraints are not supported
|
||||
ALTER TABLE name_lengths RENAME CONSTRAINT unique_12345678901234567890123456789012345678901234567890 TO unique2_12345678901234567890123456789012345678901234567890;
|
||||
|
||||
DROP TABLE partition_lengths CASCADE;
|
||||
\set VERBOSITY DEFAULT
|
||||
|
||||
-- Verify that we can create indexes with very long names on zero shard tables.
|
||||
CREATE INDEX append_zero_shard_table_idx_12345678901234567890123456789012345678901234567890 ON append_zero_shard_table_12345678901234567890123456789012345678901234567890(a);
|
||||
|
||||
-- Verify that CREATE INDEX on already distributed table has proper shard names.
|
||||
|
||||
CREATE INDEX tmp_idx_12345678901234567890123456789012345678901234567890 ON name_lengths(col2);
|
||||
|
|
@ -104,6 +180,9 @@ SELECT "relname", "Column", "Type", "Definition" FROM index_attrs WHERE
|
|||
-- by the parser/rewriter before further processing, just as in Postgres.
|
||||
CREATE INDEX tmp_idx_123456789012345678901234567890123456789012345678901234567890 ON name_lengths(col2);
|
||||
|
||||
-- Verify we can rename indexes with long names
|
||||
ALTER INDEX tmp_idx_123456789012345678901234567890123456789012345678901234567890 RENAME TO tmp_idx_newname_123456789012345678901234567890123456789012345678901234567890;
|
||||
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
SELECT "relname", "Column", "Type", "Definition" FROM index_attrs WHERE
|
||||
relname LIKE 'tmp_idx_%' ORDER BY 1 DESC, 2 DESC, 3 DESC, 4 DESC;
|
||||
|
|
@ -136,8 +215,8 @@ SELECT master_create_distributed_table('sneaky_name_lengths', 'int_col_123456789
|
|||
SELECT master_create_worker_shards('sneaky_name_lengths', '2', '2');
|
||||
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
\di public.sneaky*225006
|
||||
SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.sneaky_name_lengths_225006'::regclass ORDER BY 1 DESC, 2 DESC;
|
||||
\di public.sneaky*225030
|
||||
SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.sneaky_name_lengths_225030'::regclass ORDER BY 1 DESC, 2 DESC;
|
||||
\c - - :master_host :master_port
|
||||
|
||||
SET citus.shard_count TO 2;
|
||||
|
|
@ -155,7 +234,7 @@ CREATE TABLE sneaky_name_lengths (
|
|||
SELECT create_distributed_table('sneaky_name_lengths', 'col1', 'hash');
|
||||
|
||||
\c - - :public_worker_1_host :worker_1_port
|
||||
\di unique*225008
|
||||
\di unique*225032
|
||||
\c - - :master_host :master_port
|
||||
|
||||
SET citus.shard_count TO 2;
|
||||
|
|
@ -215,3 +294,4 @@ DROP TABLE multi_name_lengths.too_long_12345678901234567890123456789012345678901
|
|||
-- Clean up.
|
||||
DROP TABLE name_lengths CASCADE;
|
||||
DROP TABLE U&"elephant_!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D!0441!043B!043E!043D" UESCAPE '!' CASCADE;
|
||||
RESET citus.force_max_query_parallelization;
|
||||
|
|
|
|||
|
|
@ -4,6 +4,7 @@ CREATE SCHEMA null_parameters;
|
|||
SET search_path TO null_parameters;
|
||||
|
||||
SET citus.next_shard_id TO 1680000;
|
||||
SET citus.shard_count to 32;
|
||||
CREATE TABLE text_dist_column (key text, value text);
|
||||
SELECT create_distributed_table('text_dist_column', 'key');
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue