external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move RowExclusiveLock to start in SyncMetadataToNodes

pull/3068/head
Marco Slot 2019-10-04 12:07:41 +02:00
parent 217db2a03e
commit 89377ee578
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/distributed/metadata/metadata_sync.c
View File

@ -1278,7 +1278,12 @@ SyncMetadataToNodes(void)
return METADATA_SYNC_SUCCESS; return METADATA_SYNC_SUCCESS;
} }
if (!ConditionalLockRelationOid(DistNodeRelationId(), AccessShareLock)) /*
* Request a RowExclusiveLock so we don't run concurrently with other
* functions updating pg_dist_node, but allow concurrency with functions
* which are just reading from pg_dist_node.
*/
if (!ConditionalLockRelationOid(DistNodeRelationId(), RowExclusiveLock))
{ {
return METADATA_SYNC_FAILED_LOCK; return METADATA_SYNC_FAILED_LOCK;
} }
@ -1293,17 +1298,7 @@ SyncMetadataToNodes(void)
{ {
bool raiseInterrupts = false; bool raiseInterrupts = false;
/* if (!SyncMetadataSnapshotToNode(workerNode, raiseInterrupts))
* Request a RowExclusiveLock so we don't run concurrently with other
* functions updating pg_dist_node, but allow concurrency with functions
* which are just reading from pg_dist_node.
*/
if (!ConditionalLockRelationOid(DistNodeRelationId(), RowExclusiveLock))
{
result = METADATA_SYNC_FAILED_LOCK;
break;
}
else if (!SyncMetadataSnapshotToNode(workerNode, raiseInterrupts))
{ {
result = METADATA_SYNC_FAILED_SYNC; result = METADATA_SYNC_FAILED_SYNC;
} }