From ed107835cb002835c2006a004348aa18d2ac0b60 Mon Sep 17 00:00:00 2001 From: gledis69 Date: Mon, 7 Feb 2022 18:34:39 +0300 Subject: [PATCH 1/4] Updates a few details in Contributing.md * Adds installation of `mitmproxy`. I was getting this error from running regression tests: ``` Can't exec "mitmdump": No such file or directory at /home/glediszeneli/citus/src/test/regress/pg_regress_multi.pl line 215. ``` * Calls `install-all` in the setup. Without `install-all` the `mutli-extension` regression test failed. --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7777554b2..8e85fbbba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,7 +31,7 @@ why we ask this as well as instructions for how to proceed, see the cd citus ./configure make - make install + make install install-all cd src/test/regress make check ``` @@ -51,7 +51,7 @@ why we ask this as well as instructions for how to proceed, see the autoconf flex git libcurl4-gnutls-dev libicu-dev \ libkrb5-dev liblz4-dev libpam0g-dev libreadline-dev \ libselinux1-dev libssl-dev libxslt1-dev libzstd-dev \ - make uuid-dev + make uuid-dev mitmproxy ``` 2. Get, build, and test the code From 4c2a0f0aa0aa3193399202f680bdd718bcda8e9e Mon Sep 17 00:00:00 2001 From: gledis69 Date: Wed, 9 Feb 2022 22:00:39 +0300 Subject: [PATCH 2/4] Removing install-all, but adding a comment about it --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8e85fbbba..692f0c743 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,7 +31,7 @@ why we ask this as well as instructions for how to proceed, see the cd citus ./configure make - make install install-all + make install cd src/test/regress make check ``` @@ -62,6 +62,8 @@ why we ask this as well as instructions for how to proceed, see the ./configure make sudo make install + # Optionally, you might instead want to use `sudo make install-all` + # since `multi_extension` test would fail due to missing downgrade scripts. cd src/test/regress make check ``` From 49c594a55075f46a82a38a9f749a50f67100b1c7 Mon Sep 17 00:00:00 2001 From: gledis69 Date: Fri, 11 Feb 2022 14:17:22 +0300 Subject: [PATCH 3/4] Adding install-all comment to all OS-es --- CONTRIBUTING.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 692f0c743..47d628034 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,6 +32,8 @@ why we ask this as well as instructions for how to proceed, see the ./configure make make install + # Optionally, you might instead want to use `sudo make install-all` + # since `multi_extension` regression test would fail due to missing downgrade scripts. cd src/test/regress make check ``` @@ -63,7 +65,7 @@ why we ask this as well as instructions for how to proceed, see the make sudo make install # Optionally, you might instead want to use `sudo make install-all` - # since `multi_extension` test would fail due to missing downgrade scripts. + # since `multi_extension` regression test would fail due to missing downgrade scripts. cd src/test/regress make check ``` @@ -106,6 +108,8 @@ why we ask this as well as instructions for how to proceed, see the PG_CONFIG=/usr/pgsql-14/bin/pg_config ./configure make sudo make install + # Optionally, you might instead want to use `sudo make install-all` + # since `multi_extension` regression test would fail due to missing downgrade scripts. cd src/test/regress make check ``` @@ -127,6 +131,8 @@ cd build cmake .. make -j5 sudo make install +# Optionally, you might instead want to use `sudo make install-all` +# since `multi_extension` regression test would fail due to missing downgrade scripts. cd ../.. git clone https://github.com/citusdata/tools.git From 5478bd0105421982664186b68005a6e0271798bb Mon Sep 17 00:00:00 2001 From: gledis69 Date: Fri, 11 Feb 2022 14:23:43 +0300 Subject: [PATCH 4/4] Remove extra sudo in comment for Mac --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 47d628034..ae8d8c625 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,7 +32,7 @@ why we ask this as well as instructions for how to proceed, see the ./configure make make install - # Optionally, you might instead want to use `sudo make install-all` + # Optionally, you might instead want to use `make install-all` # since `multi_extension` regression test would fail due to missing downgrade scripts. cd src/test/regress make check