Address reviews

velioglu/wo_seq_test_1
Burak Velioglu 2022-01-21 11:47:10 +03:00
parent 46b4b55c7b
commit 8a5c8c449f
No known key found for this signature in database
GPG Key ID: F6827E620F6549C6
2 changed files with 8 additions and 3 deletions

View File

@ -367,7 +367,7 @@ GetCitusTableDDLCommandList(Oid relationId)
/* /*
* ReplicateAllDependenciesToNodeCommandList returns commands to replicate all * ReplicateAllObjectsToNodeCommandList returns commands to replicate all
* previously marked objects to a worker node. The function also sets * previously marked objects to a worker node. The function also sets
* clusterHasDistributedFunction if there are any distributed functions. * clusterHasDistributedFunction if there are any distributed functions.
*/ */

View File

@ -648,7 +648,7 @@ PgDistTableMetadataSyncCommandList(void)
} }
} }
/* remove all dist table related metadata first */ /* remove all dist table and object related metadata first */
metadataSnapshotCommandList = lappend(metadataSnapshotCommandList, metadataSnapshotCommandList = lappend(metadataSnapshotCommandList,
DELETE_ALL_PARTITIONS); DELETE_ALL_PARTITIONS);
metadataSnapshotCommandList = lappend(metadataSnapshotCommandList, DELETE_ALL_SHARDS); metadataSnapshotCommandList = lappend(metadataSnapshotCommandList, DELETE_ALL_SHARDS);
@ -755,7 +755,7 @@ SyncObjectDependenciesCommandList(WorkerNode *workerNode)
List *commandList = NIL; List *commandList = NIL;
/* /*
* Detach partitions, remove shell tables and delete all objects first. * Detach partitions and remove shell tables first.
*/ */
commandList = list_concat(commandList, DetachPartitionCommandList()); commandList = list_concat(commandList, DetachPartitionCommandList());
commandList = lappend(commandList, REMOVE_ALL_CLUSTERED_TABLES_ONLY_COMMAND); commandList = lappend(commandList, REMOVE_ALL_CLUSTERED_TABLES_ONLY_COMMAND);
@ -817,6 +817,11 @@ SyncObjectDependenciesToNode(WorkerNode *workerNode)
} }
/*
* SyncPgDistTableMetadataToNode syncs the pg_dist_partition, pg_dist_shard
* pg_dist_placement and pg_dist_object metadata entries.
*
*/
static void static void
SyncPgDistTableMetadataToNode(WorkerNode *workerNode) SyncPgDistTableMetadataToNode(WorkerNode *workerNode)
{ {