mirror of https://github.com/citusdata/citus.git
Fix review comments
parent
0b31f7bc9f
commit
8a866a3d5e
|
@ -1475,6 +1475,7 @@ ShouldShutdownConnection(MultiConnection *connection, const int cachedConnection
|
|||
connection->forceCloseAtTransactionEnd ||
|
||||
PQstatus(connection->pgConn) != CONNECTION_OK ||
|
||||
!RemoteTransactionIdle(connection) ||
|
||||
connection->requiresReplication ||
|
||||
(MaxCachedConnectionLifetime >= 0 &&
|
||||
MillisecondsToTimeout(connection->connectionEstablishmentStart,
|
||||
MaxCachedConnectionLifetime) <= 0);
|
||||
|
|
|
@ -234,15 +234,6 @@ ErrorIfCannotSplitShardExtended(SplitOperation splitOperation,
|
|||
SplitTargetName[splitOperation])));
|
||||
}
|
||||
|
||||
if (extern_IsColumnarTableAmTable(shardIntervalToSplit->relationId))
|
||||
{
|
||||
ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
|
||||
errmsg("Cannot %s %s as operation "
|
||||
"is not supported for Columnar tables.",
|
||||
SplitOperationName[splitOperation],
|
||||
SplitTargetName[splitOperation])));
|
||||
}
|
||||
|
||||
uint32 relationReplicationFactor = TableShardReplicationFactor(
|
||||
shardIntervalToSplit->relationId);
|
||||
if (relationReplicationFactor > 1)
|
||||
|
|
|
@ -2109,7 +2109,7 @@ CreateShardSplitSubscription(MultiConnection *connection, char *sourceNodeName,
|
|||
SHARD_SPLIT_SUBSCRIPTION_PREFIX)),
|
||||
quote_literal_cstr(conninfo->data),
|
||||
quote_identifier(publicationName),
|
||||
slotName);
|
||||
escape_param_str(slotName));
|
||||
|
||||
ExecuteCriticalRemoteCommand(connection, createSubscriptionCommand->data);
|
||||
pfree(createSubscriptionCommand->data);
|
||||
|
|
Loading…
Reference in New Issue