external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix review comments

users/saawasek/non_blocking_split_integrated
Sameer Awasekar 2022-08-04 18:22:01 +05:30
parent 0b31f7bc9f
commit 8a866a3d5e
3 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/distributed/connection/connection_management.c
View File

@ -1475,6 +1475,7 @@ ShouldShutdownConnection(MultiConnection *connection, const int cachedConnection
connection->forceCloseAtTransactionEnd || connection->forceCloseAtTransactionEnd ||
PQstatus(connection->pgConn) != CONNECTION_OK || PQstatus(connection->pgConn) != CONNECTION_OK ||
!RemoteTransactionIdle(connection) || !RemoteTransactionIdle(connection) ||
connection->requiresReplication ||
(MaxCachedConnectionLifetime >= 0 && (MaxCachedConnectionLifetime >= 0 &&
MillisecondsToTimeout(connection->connectionEstablishmentStart, MillisecondsToTimeout(connection->connectionEstablishmentStart,
MaxCachedConnectionLifetime) <= 0); MaxCachedConnectionLifetime) <= 0);

9
src/backend/distributed/operations/shard_split.c
View File

@ -234,15 +234,6 @@ ErrorIfCannotSplitShardExtended(SplitOperation splitOperation,
SplitTargetName[splitOperation]))); SplitTargetName[splitOperation])));
} }
if (extern_IsColumnarTableAmTable(shardIntervalToSplit->relationId))
{
ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("Cannot %s %s as operation "
"is not supported for Columnar tables.",
SplitOperationName[splitOperation],
SplitTargetName[splitOperation])));
}
uint32 relationReplicationFactor = TableShardReplicationFactor( uint32 relationReplicationFactor = TableShardReplicationFactor(
shardIntervalToSplit->relationId); shardIntervalToSplit->relationId);
if (relationReplicationFactor > 1) if (relationReplicationFactor > 1)

2
src/backend/distributed/replication/multi_logical_replication.c
View File

@ -2109,7 +2109,7 @@ CreateShardSplitSubscription(MultiConnection *connection, char *sourceNodeName,
SHARD_SPLIT_SUBSCRIPTION_PREFIX)), SHARD_SPLIT_SUBSCRIPTION_PREFIX)),
quote_literal_cstr(conninfo->data), quote_literal_cstr(conninfo->data),
quote_identifier(publicationName), quote_identifier(publicationName),
slotName); escape_param_str(slotName));
ExecuteCriticalRemoteCommand(connection, createSubscriptionCommand->data); ExecuteCriticalRemoteCommand(connection, createSubscriptionCommand->data);
pfree(createSubscriptionCommand->data); pfree(createSubscriptionCommand->data);