external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Possible undefined behavior for bit shift in citus_stat_tenants.c

pull/7954/head
Maksim Melnikov 2025-04-07 13:42:16 +03:00
parent 0e6127c4f6
commit 8a8a493b67
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/distributed/utils/citus_stat_tenants.c
View File

@ -48,6 +48,9 @@ ExecutorEnd_hook_type prev_ExecutorEnd = NULL;
#define ATTRIBUTE_STRING_FORMAT_WITHOUT_TID "/*{\"cId\":%d}*/" #define ATTRIBUTE_STRING_FORMAT_WITHOUT_TID "/*{\"cId\":%d}*/"
#define STAT_TENANTS_COLUMNS 9 #define STAT_TENANTS_COLUMNS 9
#define ONE_QUERY_SCORE 1000000000 #define ONE_QUERY_SCORE 1000000000
#define BYTE_TO_BIT 3 /* 2^3 bits/byte */
#define TENANTS_STATS_FIELD_BIT_LENGTH(tenantStats, field) (sizeof((tenantStats)->field) \
<< BYTE_TO_BIT)
static char AttributeToTenant[MAX_TENANT_ATTRIBUTE_LENGTH] = ""; static char AttributeToTenant[MAX_TENANT_ATTRIBUTE_LENGTH] = "";
static CmdType AttributeToCommandType = CMD_UNKNOWN; static CmdType AttributeToCommandType = CMD_UNKNOWN;
@ -605,8 +608,12 @@ ReduceScoreIfNecessary(TenantStats *tenantStats, TimestampTz queryTime)
*/ */
if (periodCountAfterLastScoreReduction > 0) if (periodCountAfterLastScoreReduction > 0)
{ {
tenantStats->score >>= periodCountAfterLastScoreReduction;
tenantStats->lastScoreReduction = queryTime; tenantStats->lastScoreReduction = queryTime;
/*addtional check to avoid undefined behavior */
tenantStats->score = (periodCountAfterLastScoreReduction <
TENANTS_STATS_FIELD_BIT_LENGTH(tenantStats, score))
? tenantStats->score >> periodCountAfterLastScoreReduction
: 0;
} }
} }