From 8b672421a212bdf0487ad12c7f47d76df4e16017 Mon Sep 17 00:00:00 2001
From: Jelte Fennema <github-tech@jeltef.nl>
Date: Mon, 22 Aug 2022 10:40:05 +0200
Subject: [PATCH] Fix warnings

---
 src/backend/distributed/metadata/metadata_utility.c | 4 ++--
 src/backend/distributed/utils/background_jobs.c     | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/backend/distributed/metadata/metadata_utility.c b/src/backend/distributed/metadata/metadata_utility.c
index 8a2f4a891..6cf02eda1 100644
--- a/src/backend/distributed/metadata/metadata_utility.c
+++ b/src/backend/distributed/metadata/metadata_utility.c
@@ -2817,7 +2817,7 @@ JobTasksStatusCount(int64 jobId, int *scheduled, int *running, int *done, int *e
 	CLEAR_OPTIONAL_COUNTER(error);
 	CLEAR_OPTIONAL_COUNTER(unscheduled);
 
-#undef CLEAR_OPTIONAL_COUNTER;
+#undef CLEAR_OPTIONAL_COUNTER
 
 	Relation pgDistBackgroundTasks =
 		table_open(DistBackgroundTasksRelationId(), RowExclusiveLock);
@@ -2851,7 +2851,7 @@ JobTasksStatusCount(int64 jobId, int *scheduled, int *running, int *done, int *e
 #define INCREMENT_OPTIONAL_COUNTER(counter) \
 	if (counter) \
 	{ \
-		*counter = (*counter)++; \
+		(*counter)++; \
 	}
 
 		switch (status)
diff --git a/src/backend/distributed/utils/background_jobs.c b/src/backend/distributed/utils/background_jobs.c
index a97f3eaf7..9774f40b2 100644
--- a/src/backend/distributed/utils/background_jobs.c
+++ b/src/backend/distributed/utils/background_jobs.c
@@ -487,8 +487,7 @@ ConsumeTaskWorkerOutput(shm_mq_handle *responseq, BackgroundTask *task, bool *ha
 				{
 					*hadError = true;
 				}
-
-				/* fall-through */
+				__attribute__((fallthrough));
 			}
 
 			case 'N': /* NOTICE */