Fix upgrade test

src/backend/distributed/operations/shard_split.c

@@ -1851,6 +1851,10 @@ AddDummyShardEntryInMap(HTAB *mapOfDummyShardToPlacement, uint32 targetNodeId,
 }
 
 
+/*
+ * DropDummyShards traverses the dummy shard map and drops shard at given node.
+ * It fails if the shard cannot be dropped.
+ */
 static void
 DropDummyShards(HTAB *mapOfDummyShardToPlacement)
 {

src/test/regress/expected/upgrade_list_citus_objects.out

@@ -229,6 +229,7 @@ ORDER BY 1;
  function worker_record_sequence_dependency(regclass,regclass,name)
  function worker_save_query_explain_analyze(text,jsonb)
  function worker_split_copy(bigint,split_copy_info[])
+ function worker_split_shard_replication_setup(split_shard_info[])
  schema citus
  schema citus_internal
  sequence pg_dist_colocationid_seq
@@ -250,10 +251,11 @@ ORDER BY 1;
  table pg_dist_transaction
  type citus.distribution_type
  type citus.shard_transfer_mode
- type citus.split_shard_info
  type citus_copy_format
  type noderole
+ type replication_slot_info
  type split_copy_info
+ type split_shard_info
  view citus_dist_stat_activity
  view citus_lock_waits
  view citus_locks
@@ -265,5 +267,5 @@ ORDER BY 1;
  view citus_stat_statements
  view pg_dist_shard_placement
  view time_partitions
-(256 rows)
+(259 rows)