external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor: ReplicateShardToAllWorkers more explicitly locks pg_dist_node

pull/1519/head
Brian Cloutier 2017-08-03 11:17:34 +03:00 committed by Brian Cloutier
parent f87fefa323
commit 94947c0d54
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/distributed/utils/reference_table_utils.c
View File

@ -28,6 +28,7 @@
#include "distributed/transaction_management.h" #include "distributed/transaction_management.h"
#include "distributed/worker_manager.h" #include "distributed/worker_manager.h"
#include "distributed/worker_transaction.h" #include "distributed/worker_transaction.h"
#include "storage/lmgr.h"
#include "utils/fmgroids.h" #include "utils/fmgroids.h"
#include "utils/lsyscache.h" #include "utils/lsyscache.h"
#include "utils/rel.h" #include "utils/rel.h"
@ -226,11 +227,12 @@ ReplicateSingleShardTableToAllWorkers(Oid relationId)
static void static void
ReplicateShardToAllWorkers(ShardInterval *shardInterval) ReplicateShardToAllWorkers(ShardInterval *shardInterval)
{ {
/* we do not use pgDistNode, we only obtain a lock on it to prevent modifications */ List *workerNodeList = NULL;
Relation pgDistNode = heap_open(DistNodeRelationId(), AccessShareLock);
List *workerNodeList = ActivePrimaryNodeList();
ListCell *workerNodeCell = NULL; ListCell *workerNodeCell = NULL;
LockRelationOid(DistNodeRelationId(), AccessShareLock);
workerNodeList = ActivePrimaryNodeList();
/* /*
* We will iterate over all worker nodes and if healthy placement is not exist at * We will iterate over all worker nodes and if healthy placement is not exist at
* given node we will copy the shard to that node. Then we will also modify * given node we will copy the shard to that node. Then we will also modify
@ -245,8 +247,6 @@ ReplicateShardToAllWorkers(ShardInterval *shardInterval)
ReplicateShardToNode(shardInterval, nodeName, nodePort); ReplicateShardToNode(shardInterval, nodeName, nodePort);
} }
heap_close(pgDistNode, NoLock);
} }