external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes review comments

pull/7372/head
gurkanindibay 2023-12-26 13:41:46 +03:00
parent bbf9581fef
commit 9540b47568
1 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/backend/distributed/executor/adaptive_executor.c
View File

@ -729,10 +729,11 @@ static uint64 MicrosecondsBetweenTimestamps(instr_time startTime, instr_time end
static int WorkerPoolCompare(const void *lhsKey, const void *rhsKey); static int WorkerPoolCompare(const void *lhsKey, const void *rhsKey);
static void SetAttributeInputMetadata(DistributedExecution *execution, static void SetAttributeInputMetadata(DistributedExecution *execution,
ShardCommandExecution *shardCommandExecution); ShardCommandExecution *shardCommandExecution);
static ExecutionParams * GetExecutionParams(RowModifyLevel modLevel, List *taskList, static ExecutionParams * CreateDefaultExecutionParams(RowModifyLevel modLevel,
TupleDestination *tupleDest, List *taskList,
bool expectResults, TupleDestination *tupleDest,
ParamListInfo paramListInfo); bool expectResults,
ParamListInfo paramListInfo);
/* /*
@ -1023,10 +1024,10 @@ ExecuteTaskListOutsideTransaction(RowModifyLevel modLevel, List *taskList,
* bind params (presumably from executor state) with defaults for some of the arguments. * bind params (presumably from executor state) with defaults for some of the arguments.
*/ */
static ExecutionParams * static ExecutionParams *
GetExecutionParams(RowModifyLevel modLevel, List *taskList, CreateDefaultExecutionParams(RowModifyLevel modLevel, List *taskList,
TupleDestination *tupleDest, TupleDestination *tupleDest,
bool expectResults, bool expectResults,
ParamListInfo paramListInfo) ParamListInfo paramListInfo)
{ {
int targetPoolSize = MaxAdaptiveExecutorPoolSize; int targetPoolSize = MaxAdaptiveExecutorPoolSize;
bool localExecutionSupported = true; bool localExecutionSupported = true;
@ -1054,8 +1055,10 @@ ExecuteTaskListIntoTupleDestWithParam(RowModifyLevel modLevel, List *taskList,
bool expectResults, bool expectResults,
ParamListInfo paramListInfo) ParamListInfo paramListInfo)
{ {
ExecutionParams *executionParams = GetExecutionParams(modLevel, taskList, tupleDest, ExecutionParams *executionParams = CreateDefaultExecutionParams(modLevel, taskList,
expectResults, paramListInfo); tupleDest,
expectResults,
paramListInfo);
return ExecuteTaskListExtended(executionParams); return ExecuteTaskListExtended(executionParams);
} }
@ -1070,8 +1073,10 @@ ExecuteTaskListIntoTupleDest(RowModifyLevel modLevel, List *taskList,
bool expectResults) bool expectResults)
{ {
ParamListInfo paramListInfo = NULL; ParamListInfo paramListInfo = NULL;
ExecutionParams *executionParams = GetExecutionParams(modLevel, taskList, tupleDest, ExecutionParams *executionParams = CreateDefaultExecutionParams(modLevel, taskList,
expectResults, paramListInfo); tupleDest,
expectResults,
paramListInfo);
return ExecuteTaskListExtended(executionParams); return ExecuteTaskListExtended(executionParams);
} }