external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flaky isolation_get_all_active_transactions.spec test

pull/7323/head
Onur Tirtir 2023-11-03 01:35:56 +03:00
parent 5e2439a117
commit 98a22bd2a4
2 changed files with 48 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/test/regress/expected/isolation_get_all_active_transactions.out
View File

@ -94,7 +94,7 @@ step s2-commit:
COMMIT; COMMIT;
starting permutation: s4-record-pid s3-show-activity s5-kill s3-show-activity starting permutation: s4-record-pid s3-show-activity s5-kill s3-wait-backend-termination
step s4-record-pid: step s4-record-pid:
SELECT pg_backend_pid() INTO selected_pid; SELECT pg_backend_pid() INTO selected_pid;
@ -109,18 +109,34 @@ count
step s5-kill: step s5-kill:
SELECT pg_terminate_backend(pg_backend_pid) FROM selected_pid; SELECT pg_terminate_backend(pg_backend_pid) FROM selected_pid;
SELECT pg_sleep(1); -- sleep for a while to make sure that backend is terminated
pg_terminate_backend pg_terminate_backend
--------------------------------------------------------------------- ---------------------------------------------------------------------
t t
(1 row) (1 row)
step s3-show-activity: pg_sleep
SET ROLE postgres;
select count(*) from get_all_active_transactions() where process_id IN (SELECT * FROM selected_pid);
count
--------------------------------------------------------------------- ---------------------------------------------------------------------
0
(1 row) (1 row)
step s3-wait-backend-termination:
SET ROLE postgres;
DO $$
DECLARE
i int;
BEGIN
i := 0;
-- try for 5 sec then timeout
WHILE (select count(*) > 0 from get_all_active_transactions() where process_id IN (SELECT * FROM selected_pid))
LOOP
PERFORM pg_sleep(0.1);
i := i + 1;
IF i > 50 THEN
RAISE EXCEPTION 'Timeout while waiting for backend to terminate';
END IF;
END LOOP;
END;
$$;

26
src/test/regress/spec/isolation_get_all_active_transactions.spec
View File

@ -107,6 +107,29 @@ step "s3-show-activity"
select count(*) from get_all_active_transactions() where process_id IN (SELECT * FROM selected_pid); select count(*) from get_all_active_transactions() where process_id IN (SELECT * FROM selected_pid);
} }
step "s3-wait-backend-termination"
{
SET ROLE postgres;
DO $$
DECLARE
i int;
BEGIN
i := 0;
-- try for 5 sec then timeout
WHILE (select count(*) > 0 from get_all_active_transactions() where process_id IN (SELECT * FROM selected_pid))
LOOP
PERFORM pg_sleep(0.1);
i := i + 1;
IF i > 50 THEN
RAISE EXCEPTION 'Timeout while waiting for backend to terminate';
END IF;
END LOOP;
END;
$$;
}
session "s4" session "s4"
step "s4-record-pid" step "s4-record-pid"
@ -119,8 +142,9 @@ session "s5"
step "s5-kill" step "s5-kill"
{ {
SELECT pg_terminate_backend(pg_backend_pid) FROM selected_pid; SELECT pg_terminate_backend(pg_backend_pid) FROM selected_pid;
SELECT pg_sleep(1); -- sleep for a while to make sure that backend is terminated
} }
permutation "s1-grant" "s1-begin-insert" "s2-begin-insert" "s3-as-admin" "s3-as-user-1" "s3-as-readonly" "s3-as-monitor" "s1-commit" "s2-commit" permutation "s1-grant" "s1-begin-insert" "s2-begin-insert" "s3-as-admin" "s3-as-user-1" "s3-as-readonly" "s3-as-monitor" "s1-commit" "s2-commit"
permutation "s4-record-pid" "s3-show-activity" "s5-kill" "s3-show-activity" permutation "s4-record-pid" "s3-show-activity" "s5-kill" "s3-wait-backend-termination"