external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't update shard statistics if all placements failed

pull/1149/head
Brian Cloutier 2017-01-23 16:27:02 +03:00
parent d91a32b585
commit 9acfc15c73
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/distributed/master/master_stage_protocol.c
View File

@ -267,7 +267,7 @@ master_append_table_to_shard(PG_FUNCTION_ARGS)
MultiConnection *connection = GetPlacementConnection(FOR_DML, shardPlacement, MultiConnection *connection = GetPlacementConnection(FOR_DML, shardPlacement,
NULL); NULL);
PGresult *queryResult = NULL; PGresult *queryResult = NULL;
int executeCommand = 0; int executeResult = 0;
StringInfo workerAppendQuery = makeStringInfo(); StringInfo workerAppendQuery = makeStringInfo();
appendStringInfo(workerAppendQuery, WORKER_APPEND_TABLE_TO_SHARD, appendStringInfo(workerAppendQuery, WORKER_APPEND_TABLE_TO_SHARD,
@ -275,17 +275,25 @@ master_append_table_to_shard(PG_FUNCTION_ARGS)
quote_literal_cstr(sourceTableName), quote_literal_cstr(sourceTableName),
quote_literal_cstr(sourceNodeName), sourceNodePort); quote_literal_cstr(sourceNodeName), sourceNodePort);
executeCommand = ExecuteOptionalRemoteCommand(connection, workerAppendQuery->data, executeResult = ExecuteOptionalRemoteCommand(connection, workerAppendQuery->data,
&queryResult); &queryResult);
PQclear(queryResult); PQclear(queryResult);
ForgetResults(connection); ForgetResults(connection);
if (executeCommand != 0) if (executeResult != 0)
{ {
MarkRemoteTransactionFailed(connection, false); MarkRemoteTransactionFailed(connection, false);
} }
} }
/*
* Abort if all placements failed, mark placements invalid if only some failed. By
* doing this UpdateShardStatistics never works on failed placements.
*
* (Pass false for using2PC arbitrarily, the parameter is not used)
*/
CheckForFailedPlacements(true, false);
/* update shard statistics and get new shard size */ /* update shard statistics and get new shard size */
newShardSize = UpdateShardStatistics(shardId); newShardSize = UpdateShardStatistics(shardId);