diff --git a/src/backend/distributed/commands/dependencies.c b/src/backend/distributed/commands/dependencies.c index 80801687d..429ca67c7 100644 --- a/src/backend/distributed/commands/dependencies.c +++ b/src/backend/distributed/commands/dependencies.c @@ -235,7 +235,8 @@ GetDependencyCreateDDLCommands(const ObjectAddress *dependency) return NIL; } - if (relKind == RELKIND_RELATION || relKind == RELKIND_PARTITIONED_TABLE || relKind == RELKIND_FOREIGN_TABLE) + if (relKind == RELKIND_RELATION || relKind == RELKIND_PARTITIONED_TABLE || + relKind == RELKIND_FOREIGN_TABLE) { Oid relationId = dependency->objectId; if (IsCitusTable(relationId) && !IsTableOwnedByExtension(relationId)) diff --git a/src/backend/distributed/metadata/metadata_cache.c b/src/backend/distributed/metadata/metadata_cache.c index 5ebcb1a69..ce05f7c28 100644 --- a/src/backend/distributed/metadata/metadata_cache.c +++ b/src/backend/distributed/metadata/metadata_cache.c @@ -955,7 +955,7 @@ LookupNodeForGroup(int32 groupId) if (!foundAnyNodes) { ereport(ERROR, (errmsg("there is a shard placement in node group %d but " - "there are no nodes in that group", groupId))); + "there are no nodes in that group", groupId))); } switch (ReadFromSecondaries) diff --git a/src/backend/distributed/metadata/node_metadata.c b/src/backend/distributed/metadata/node_metadata.c index 89d081827..93a4f2fad 100644 --- a/src/backend/distributed/metadata/node_metadata.c +++ b/src/backend/distributed/metadata/node_metadata.c @@ -695,7 +695,7 @@ SetUpObjectMetadata(WorkerNode *workerNode) char *truncateTriggerCreateCommand = TruncateTriggerCreateCommand(clusteredTableId); metadataSnapshotCommandList = lappend(metadataSnapshotCommandList, - truncateTriggerCreateCommand); + truncateTriggerCreateCommand); } /* add the pg_dist_shard{,placement} entries */ @@ -1225,7 +1225,7 @@ ActivateNode(char *nodeName, int nodePort) SetWorkerColumnLocalOnly(workerNode, Anum_pg_dist_node_isactive, BoolGetDatum(isActive)); - // TODO: Once all tests will be enabled for MX, we can remove sync by default check + /* TODO: Once all tests will be enabled for MX, we can remove sync by default check */ bool syncMetadata = EnableMetadataSyncByDefault && NodeIsPrimary(workerNode); if (syncMetadata) diff --git a/src/backend/distributed/worker/worker_data_fetch_protocol.c b/src/backend/distributed/worker/worker_data_fetch_protocol.c index 881619774..ce8a66959 100644 --- a/src/backend/distributed/worker/worker_data_fetch_protocol.c +++ b/src/backend/distributed/worker/worker_data_fetch_protocol.c @@ -474,14 +474,15 @@ worker_apply_sequence_command(PG_FUNCTION_ARGS) RangeVar *sequenceRange = makeRangeVar(sequenceSchema, sequenceName, -1); Oid sequenceRelationId = RangeVarGetRelid(sequenceRange, AccessShareLock, true); - + if (sequenceRelationId != InvalidOid) { Form_pg_sequence pgSequenceForm = pg_get_sequencedef(sequenceRelationId); if (pgSequenceForm->seqtypid != sequenceTypeId) { StringInfo dropSequenceString = makeStringInfo(); - char *qualifiedSequenceName = quote_qualified_identifier(sequenceSchema, sequenceName); + char *qualifiedSequenceName = quote_qualified_identifier(sequenceSchema, + sequenceName); appendStringInfoString(dropSequenceString, "DROP SEQUENCE "); appendStringInfoString(dropSequenceString, qualifiedSequenceName); appendStringInfoString(dropSequenceString, ";"); @@ -495,7 +496,7 @@ worker_apply_sequence_command(PG_FUNCTION_ARGS) CommandCounterIncrement(); sequenceRelationId = RangeVarGetRelid(createSequenceStatement->sequence, - AccessShareLock, false); + AccessShareLock, false); Assert(sequenceRelationId != InvalidOid); AlterSequenceMinMax(sequenceRelationId, sequenceSchema, sequenceName, sequenceTypeId);