From a17ab6408a26b3230905706247a13c4a9dfe5107 Mon Sep 17 00:00:00 2001 From: velioglu Date: Thu, 15 Jun 2017 17:11:19 +0300 Subject: [PATCH] Delete ExecuteRemoteCommand function --- .../worker/worker_data_fetch_protocol.c | 59 ------------------- src/include/distributed/worker_protocol.h | 2 - 2 files changed, 61 deletions(-) diff --git a/src/backend/distributed/worker/worker_data_fetch_protocol.c b/src/backend/distributed/worker/worker_data_fetch_protocol.c index d784d9a87..30c197242 100644 --- a/src/backend/distributed/worker/worker_data_fetch_protocol.c +++ b/src/backend/distributed/worker/worker_data_fetch_protocol.c @@ -1125,65 +1125,6 @@ ExecuteRemoteQuery(const char *nodeName, uint32 nodePort, char *runAsUser, } -/* - * ExecuteRemoteCommand executes the given SQL command. This command could be an - * Insert, Update, or Delete statement, or a utility command that returns - * nothing. If query is successfuly executed, the function returns true. - * Otherwise, it returns false. - */ -bool -ExecuteRemoteCommand(const char *nodeName, uint32 nodePort, StringInfo queryString) -{ - char *nodeDatabase = get_database_name(MyDatabaseId); - int32 connectionId = -1; - QueryStatus queryStatus = CLIENT_INVALID_QUERY; - bool querySent = false; - bool queryReady = false; - bool queryDone = false; - - connectionId = MultiClientConnect(nodeName, nodePort, nodeDatabase, NULL); - if (connectionId == INVALID_CONNECTION_ID) - { - return false; - } - - querySent = MultiClientSendQuery(connectionId, queryString->data); - if (!querySent) - { - MultiClientDisconnect(connectionId); - return false; - } - - while (!queryReady) - { - ResultStatus resultStatus = MultiClientResultStatus(connectionId); - if (resultStatus == CLIENT_RESULT_READY) - { - queryReady = true; - } - else if (resultStatus == CLIENT_RESULT_BUSY) - { - long sleepIntervalPerCycle = RemoteTaskCheckInterval * 1000L; - pg_usleep(sleepIntervalPerCycle); - } - else - { - MultiClientDisconnect(connectionId); - return false; - } - } - - queryStatus = MultiClientQueryStatus(connectionId); - if (queryStatus == CLIENT_QUERY_DONE) - { - queryDone = true; - } - - MultiClientDisconnect(connectionId); - return queryDone; -} - - /* * Parses the given DDL command, and returns the tree node for parsed command. */ diff --git a/src/include/distributed/worker_protocol.h b/src/include/distributed/worker_protocol.h index a8f074be3..bf0760159 100644 --- a/src/include/distributed/worker_protocol.h +++ b/src/include/distributed/worker_protocol.h @@ -128,8 +128,6 @@ extern List * TableDDLCommandList(const char *nodeName, uint32 nodePort, extern StringInfo TaskFilename(StringInfo directoryName, uint32 taskId); extern List * ExecuteRemoteQuery(const char *nodeName, uint32 nodePort, char *runAsUser, StringInfo queryString); -extern bool ExecuteRemoteCommand(const char *nodeName, uint32 nodePort, - StringInfo queryString); extern List * ColumnDefinitionList(List *columnNameList, List *columnTypeList); extern CreateStmt * CreateStatement(RangeVar *relation, List *columnDefinitionList); extern CopyStmt * CopyStatement(RangeVar *relation, char *sourceFilename);