Addressing part of comments

pull/5665/head
Yanwen Jin 2022-01-28 11:17:13 -08:00
parent 24d1a01521
commit a242159088
5 changed files with 14 additions and 33 deletions

View File

@ -1,28 +1,15 @@
safestringlib_srcdir = $(citus_abs_top_srcdir)/vendor/safestringlib
columnar_srcdir = $(citus_abs_top_srcdir)/src/backend/columnar
SUBDIRS = . safeclib
SUBDIRS +=
OBJS += \
$(patsubst $(columnar_srcdir)/%.c,%.o,$(foreach dir,$(SUBDIRS), $(sort $(wildcard $(columnar_srcdir)/$(dir)/*.c))))
MODULE_big = columnar
OBJS = safeclib/mem_primitives_lib.o \
safeclib/memcpy_s.o \
safeclib/safe_str_constraint.o \
safeclib/safe_mem_constraint.o \
safeclib/ignore_handler_s.o \
safeclib/abort_handler_s.o \
columnar.o \
columnar_tableam.o \
columnar_storage.o \
columnar_compression.o \
columnar_customscan.o \
columnar_debug.o \
columnar_metadata.o \
columnar_reader.o \
columnar_writer.o \
mod.o \
write_state_management.o
PG_CPPFLAGS += -I$(libpq_srcdir) -I$(safestringlib_srcdir)/include
DATA = $(wildcard sql/*--*.sql)
REGRESS = columnar
ifdef USE_PGXS
PG_CONFIG = pg_config

View File

@ -1026,12 +1026,12 @@ columnar_vacuum_rel(Relation rel, VacuumParams *params,
{
if (!CheckCitusVersion(WARNING))
{
/*
* Skip if the extension catalogs are not up-to-date, but avoid
* erroring during auto-vacuum.
*/
return;
}
/*
* Skip if the extension catalogs are not up-to-date, but avoid
* erroring during auto-vacuum.
*/
return;
}
/*
* If metapage version of relation is older, then we hint users to VACUUM

View File

@ -33,9 +33,3 @@ _PG_init(void)
columnar_init_gucs();
columnar_tableam_init();
}
void
_PG_fini(void)
{
columnar_tableam_finish();
}

View File

@ -6,7 +6,6 @@ safestringlib_srcdir = $(citus_abs_top_srcdir)/vendor/safestringlib
safestringlib_builddir = $(citus_top_builddir)/vendor/safestringlib/build
safestringlib_a = $(safestringlib_builddir)/libsafestring_static.a
safestringlib_sources = $(wildcard $(safestringlib_srcdir)/safeclib/*)
MODULE_big = citus
EXTENSION = citus

View File

@ -354,10 +354,11 @@ _PG_init(void)
{
DoInitialCleanup();
}
load_file("columnar.so", false);
}
/*
* DoInitialCleanup does cleanup at start time.
* Currently it: