From a48f2743bfcf887254860af385f2009596d8ca53 Mon Sep 17 00:00:00 2001 From: ivyazmitinov Date: Wed, 28 Feb 2024 09:18:49 +0100 Subject: [PATCH] Address review --- src/backend/distributed/connection/connection_management.c | 2 +- src/backend/distributed/utils/maintenanced.c | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/backend/distributed/connection/connection_management.c b/src/backend/distributed/connection/connection_management.c index 09e50bfa7..1d3eee0c4 100644 --- a/src/backend/distributed/connection/connection_management.c +++ b/src/backend/distributed/connection/connection_management.c @@ -327,7 +327,7 @@ StartNodeUserDatabaseConnection(uint32 flags, const char *hostname, int32 port, */ ConnectionHashEntry *entry = hash_search(ConnectionHash, &key, HASH_ENTER, &found); - if (!(found && entry->isValid)) + if (!found || !entry->isValid) { /* * We are just building hash entry or previously it was left in an diff --git a/src/backend/distributed/utils/maintenanced.c b/src/backend/distributed/utils/maintenanced.c index 785608729..49ed61763 100644 --- a/src/backend/distributed/utils/maintenanced.c +++ b/src/backend/distributed/utils/maintenanced.c @@ -706,10 +706,7 @@ CitusMaintenanceDaemonMain(Datum main_arg) timeout = Min(timeout, Recover2PCInterval); } - /* - * Execute only on the maintenance database, if it configured, otherwise run from every daemon. - * The config value -1 disables the distributed deadlock detection - */ + /* the config value -1 disables the distributed deadlock detection */ if (DistributedDeadlockDetectionTimeoutFactor != -1.0) { double deadlockTimeout = @@ -736,7 +733,6 @@ CitusMaintenanceDaemonMain(Datum main_arg) foundDeadlock = CheckForDistributedDeadlocks(); } - CommitTransactionCommand(); /*