From a5c12b968bced5ac85197d002c749c6f190f93fd Mon Sep 17 00:00:00 2001 From: Onder Kalaci Date: Mon, 22 May 2017 10:27:20 +0300 Subject: [PATCH] Add comment to the regression test file to prevent any misunderstandings about the usage of enable_router_execution GUC variable. --- .../expected/multi_subquery_behavioral_analytics.out | 8 +++++--- .../regress/sql/multi_subquery_behavioral_analytics.sql | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/test/regress/expected/multi_subquery_behavioral_analytics.out b/src/test/regress/expected/multi_subquery_behavioral_analytics.out index f1adee5df..b0e25d366 100644 --- a/src/test/regress/expected/multi_subquery_behavioral_analytics.out +++ b/src/test/regress/expected/multi_subquery_behavioral_analytics.out @@ -3,9 +3,11 @@ -- regression tests to cover more cases -- the tables that are used depends to multi_insert_select_behavioral_analytics_create_table.sql -- --- We don't need shard id sequence here, so commented out to prevent conflicts with concurrent tests --- ALTER SEQUENCE pg_catalog.pg_dist_shardid_seq RESTART 1430000; --- ALTER SEQUENCE pg_catalog.pg_dist_jobid_seq RESTART 1430000; +--- We don't need shard id sequence here given that we're not creating any shards, so not writing it at all +-- The following line is intended to force Citus to NOT use router planner for the tests in this +-- file. The motivation for doing this is to make sure that single-task queries can be planned +-- by non-router code-paths. Thus, this flag should NOT be used in production. Otherwise, the actual +-- router queries would fail. SET citus.enable_router_execution TO FALSE; ------------------------------------ -- Vanilla funnel query diff --git a/src/test/regress/sql/multi_subquery_behavioral_analytics.sql b/src/test/regress/sql/multi_subquery_behavioral_analytics.sql index 1e4fea414..71373b2e7 100644 --- a/src/test/regress/sql/multi_subquery_behavioral_analytics.sql +++ b/src/test/regress/sql/multi_subquery_behavioral_analytics.sql @@ -4,10 +4,12 @@ -- the tables that are used depends to multi_insert_select_behavioral_analytics_create_table.sql -- --- We don't need shard id sequence here, so commented out to prevent conflicts with concurrent tests --- ALTER SEQUENCE pg_catalog.pg_dist_shardid_seq RESTART 1430000; --- ALTER SEQUENCE pg_catalog.pg_dist_jobid_seq RESTART 1430000; +--- We don't need shard id sequence here given that we're not creating any shards, so not writing it at all +-- The following line is intended to force Citus to NOT use router planner for the tests in this +-- file. The motivation for doing this is to make sure that single-task queries can be planned +-- by non-router code-paths. Thus, this flag should NOT be used in production. Otherwise, the actual +-- router queries would fail. SET citus.enable_router_execution TO FALSE; ------------------------------------