external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes review notes

pull/7267/head
gindibay 2023-10-31 14:54:50 +03:00
parent 2f382fe961
commit ad64cb43b6
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/distributed/README.md
View File

@ -1775,7 +1775,11 @@ Each field in the struct is documented in the comments within the `DistributeObj
- **Returning tasks for `preprocess` and `postprocess`**: Ensure that either `preprocess` or `postprocess` returns a list of "DDLJob"s. If both functions return non-empty lists, then you would get an assertion failure.
- **Generic `preprocess` and `postprocess` methods**: ``PreprocessAlterDistributedObjectStmt`` and ``PostprocessAlterDistributedObjectStmt`` are generic post and pre methods that is being used for some statements. Before defining a new `preprocess` or `postprocess` method, check if the generic methods can be used.
- **Generic `preprocess` and `postprocess` methods**: ``PreprocessAlterDistributedObjectStmt`` and ``PostprocessAlterDistributedObjectStmt`` are generic post and pre methods that is being used for some statements. Both of them are being used for distributed object operations.
- PreprocessAlterDistributedObjectStmt perform below operations perform qualify operation, deparse the statement and generate a task list. PostprocessAlterDistributedObjectStmt - calls ``EnsureAllObjectDependenciesExistOnAllNodes`` to propagate missing dependencies both on coordinator and worker.
- Before defining a new `preprocess` or `postprocess` method, check if the generic methods can be used in your case.
- **`deparse`**: When propagating the command to worker nodes, make sure to define `deparse`. This is necessary because it generates a query string for each worker node.