Repartitioned INSERT/SELECT: Test GROUP BY

src/test/regress/expected/insert_select_repartition.out

@@ -518,8 +518,43 @@ SELECT * FROM target_table ORDER BY a;
  -1 | {1,2,3}
 (4 rows)
 
+DROP TABLE source_table, target_table;
 --
 -- The case where select query has a GROUP BY ...
 --
+SET citus.shard_count TO 4;
+CREATE TABLE source_table(a int, b int);
+SELECT create_distributed_table('source_table', 'a');
+ create_distributed_table
+---------------------------------------------------------------------
+
+(1 row)
+
+SET citus.shard_count TO 3;
+CREATE TABLE target_table(a int, b int);
+SELECT create_distributed_table('target_table', 'a');
+ create_distributed_table
+---------------------------------------------------------------------
+
+(1 row)
+
+INSERT INTO source_table SELECT floor(i/4), i*i FROM generate_series(1, 20) i;
+SET client_min_messages TO DEBUG1;
+INSERT INTO target_table SELECT a, max(b) FROM source_table GROUP BY a;
+DEBUG:  INSERT target table and the source relation of the SELECT partition column value must be colocated in distributed INSERT ... SELECT
+DEBUG:  performing repartitioned INSERT ... SELECT
+RESET client_min_messages;
+SELECT * FROM target_table ORDER BY a;
+ a |  b
+---------------------------------------------------------------------
+ 0 |   9
+ 1 |  49
+ 2 | 121
+ 3 | 225
+ 4 | 361
+ 5 | 400
+(6 rows)
+
+DROP TABLE source_table, target_table;
 SET client_min_messages TO WARNING;
 DROP SCHEMA insert_select_repartition CASCADE;

src/test/regress/expected/multi_insert_select_conflict.out

@@ -316,19 +316,21 @@ CONTEXT:  while executing command on localhost:xxxxx
 ROLLBACK;
 BEGIN;
 	DELETE FROM test_ref_table WHERE key > 10;
-	INSERT INTO
+	WITH r AS (
-		target_table
+		INSERT INTO
-	SELECT
+			target_table
-		col_2,
+		SELECT
-		col_1
+			col_2,
-	FROM source_table_1 ON CONFLICT (col_1) DO UPDATE SET col_2 = 1 RETURNING *;
+			col_1
+		FROM source_table_1 ON CONFLICT (col_1) DO UPDATE SET col_2 = 1 RETURNING *)
+	SELECT * FROM r ORDER BY col_1;
  col_1 | col_2
 ---------------------------------------------------------------------
+     1 |     1
+     2 |     1
      3 |     1
      4 |     1
-     1 |     1
      5 |     1
-     2 |     1
 (5 rows)
 
 ROLLBACK;

src/test/regress/sql/insert_select_repartition.sql

@@ -243,9 +243,29 @@ SELECT mapped_key, c FROM t NATURAL JOIN source_table;
 RESET client_min_messages;
 SELECT * FROM target_table ORDER BY a;
 
+DROP TABLE source_table, target_table;
+
 --
 -- The case where select query has a GROUP BY ...
 --
 
+SET citus.shard_count TO 4;
+CREATE TABLE source_table(a int, b int);
+SELECT create_distributed_table('source_table', 'a');
+
+SET citus.shard_count TO 3;
+CREATE TABLE target_table(a int, b int);
+SELECT create_distributed_table('target_table', 'a');
+
+INSERT INTO source_table SELECT floor(i/4), i*i FROM generate_series(1, 20) i;
+
+SET client_min_messages TO DEBUG1;
+INSERT INTO target_table SELECT a, max(b) FROM source_table GROUP BY a;
+RESET client_min_messages;
+
+SELECT * FROM target_table ORDER BY a;
+
+DROP TABLE source_table, target_table;
+
 SET client_min_messages TO WARNING;
 DROP SCHEMA insert_select_repartition CASCADE;

src/test/regress/sql/multi_insert_select_conflict.sql

@@ -188,12 +188,14 @@ ROLLBACK;
 
 BEGIN;
 	DELETE FROM test_ref_table WHERE key > 10;
-	INSERT INTO
+	WITH r AS (
-		target_table
+		INSERT INTO
-	SELECT
+			target_table
-		col_2,
+		SELECT
-		col_1
+			col_2,
-	FROM source_table_1 ON CONFLICT (col_1) DO UPDATE SET col_2 = 1 RETURNING *;
+			col_1
+		FROM source_table_1 ON CONFLICT (col_1) DO UPDATE SET col_2 = 1 RETURNING *)
+	SELECT * FROM r ORDER BY col_1;
 ROLLBACK;
 
 -- Following two queries are supported since we no not modify but only select from