external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2396 from citusdata/insert_select_parameters 

Do not allow unresolved parameters in INSERT...SELECT
pull/2404/head
Marco Slot 2018-09-24 15:05:55 +02:00 committed by GitHub
parent 535c535010 1ca9a5b867
commit b2c3fd891b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/distributed/planner/distributed_planner.c
View File

@ -595,6 +595,16 @@ CreateDistributedPlan(uint64 planId, Query *originalQuery, Query *query, ParamLi
if (InsertSelectIntoDistributedTable(originalQuery))
{
if (hasUnresolvedParams)
{
/*
* Unresolved parameters can cause performance regressions in
* INSERT...SELECT when the partition column is a parameter
* because we don't perform any additional pruning in the executor.
*/
return NULL;
}
distributedPlan =
CreateInsertSelectPlan(originalQuery, plannerRestrictionContext);
}