Merge pull request #3686 from citusdata/fix-typos

tests: remove stale comment, fix typo
pull/3688/head
Hadi Moshayedi 2020-03-31 15:05:18 -07:00 committed by GitHub
commit b4ba832ae9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 8 deletions

View File

@ -427,7 +427,6 @@ select count(*) FROM (
(1 row) (1 row)
RESET citus.task_executor_type; RESET citus.task_executor_type;
-- This fails due to table types not being managed properly
select key, count(distinct aggdata) select key, count(distinct aggdata)
from aggdata group by key order by 1, 2; from aggdata group by key order by 1, 2;
key | count key | count

View File

@ -184,7 +184,7 @@ DEBUG: Plan XXX query after replacing subqueries and CTEs: UPDATE recursive_dml
50 | 50 | {"f1": 50, "f2": 2500} 50 | 50 | {"f1": 50, "f2": 2500}
(1 row) (1 row)
-- there is a lateral join (e.g., corrolated subquery) thus the subqueries cannot be -- there is a lateral join (e.g., correlated subquery) thus the subqueries cannot be
-- recursively planned, however it can be planned using the repartition planner -- recursively planned, however it can be planned using the repartition planner
SET citus.enable_repartition_joins to on; SET citus.enable_repartition_joins to on;
SELECT DISTINCT foo_inner_1.tenant_id FROM SELECT DISTINCT foo_inner_1.tenant_id FROM
@ -227,7 +227,7 @@ ORDER BY foo_inner_1.tenant_id;
(10 rows) (10 rows)
RESET citus.enable_repartition_joins; RESET citus.enable_repartition_joins;
-- there is a lateral join (e.g., corrolated subquery) thus the subqueries cannot be -- there is a lateral join (e.g., correlated subquery) thus the subqueries cannot be
-- recursively planned, this one can not be planned by the repartion planner -- recursively planned, this one can not be planned by the repartion planner
-- because of the IN query on a non unique column -- because of the IN query on a non unique column
UPDATE UPDATE
@ -263,7 +263,7 @@ FROM
RETURNING *; RETURNING *;
DEBUG: generating subplan XXX_1 for subquery SELECT dept FROM recursive_dml_queries.second_distributed_table DEBUG: generating subplan XXX_1 for subquery SELECT dept FROM recursive_dml_queries.second_distributed_table
ERROR: complex joins are only supported when all distributed tables are co-located and joined on their distribution columns ERROR: complex joins are only supported when all distributed tables are co-located and joined on their distribution columns
-- again a corrolated subquery -- again a correlated subquery
-- this time distribution key eq. exists -- this time distribution key eq. exists
-- however recursive planning is prevented due to correlated subqueries -- however recursive planning is prevented due to correlated subqueries
UPDATE UPDATE

View File

@ -200,7 +200,6 @@ select count(*) FROM (
RESET citus.task_executor_type; RESET citus.task_executor_type;
-- This fails due to table types not being managed properly
select key, count(distinct aggdata) select key, count(distinct aggdata)
from aggdata group by key order by 1, 2; from aggdata group by key order by 1, 2;

View File

@ -142,7 +142,7 @@ WHERE
RETURNING RETURNING
distributed_table.*; distributed_table.*;
-- there is a lateral join (e.g., corrolated subquery) thus the subqueries cannot be -- there is a lateral join (e.g., correlated subquery) thus the subqueries cannot be
-- recursively planned, however it can be planned using the repartition planner -- recursively planned, however it can be planned using the repartition planner
SET citus.enable_repartition_joins to on; SET citus.enable_repartition_joins to on;
SELECT DISTINCT foo_inner_1.tenant_id FROM SELECT DISTINCT foo_inner_1.tenant_id FROM
@ -173,7 +173,7 @@ ORDER BY foo_inner_1.tenant_id;
RESET citus.enable_repartition_joins; RESET citus.enable_repartition_joins;
-- there is a lateral join (e.g., corrolated subquery) thus the subqueries cannot be -- there is a lateral join (e.g., correlated subquery) thus the subqueries cannot be
-- recursively planned, this one can not be planned by the repartion planner -- recursively planned, this one can not be planned by the repartion planner
-- because of the IN query on a non unique column -- because of the IN query on a non unique column
UPDATE UPDATE
@ -209,7 +209,7 @@ FROM
RETURNING *; RETURNING *;
-- again a corrolated subquery -- again a correlated subquery
-- this time distribution key eq. exists -- this time distribution key eq. exists
-- however recursive planning is prevented due to correlated subqueries -- however recursive planning is prevented due to correlated subqueries
UPDATE UPDATE