external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes review issues

pull/7388/head
gurkanindibay 2024-01-08 10:47:49 +03:00
parent a367e75dc7
commit b4dc579280
3 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/distributed/commands/comment.c
View File

@ -33,7 +33,7 @@ GetCommentPropagationCommands(Oid oid, char *objectName, ObjectType objectType)
/* Get the comment for the database */
char *comment = GetCommentForObject(oid);
char *commentObjectType = ObjectTypeInfos[objectType].name;
char const *commentObjectType = ObjectTypeInfos[objectType];
/* Create the SQL command to propagate the comment to other nodes */
if (comment != NULL)

12
src/backend/distributed/deparser/deparse_comment_stmts.c
View File

@ -29,12 +29,12 @@
#include "distributed/log_utils.h"
const ObjectTypeInfo ObjectTypeInfos[] =
const char *ObjectTypeInfos[] =
{
[OBJECT_DATABASE] = { "DATABASE", T_String },
[OBJECT_ROLE] = { "ROLE", T_String },
[OBJECT_TSCONFIGURATION] = { "TEXT SEARCH CONFIGURATION", T_List },
[OBJECT_TSDICTIONARY] = { "TEXT SEARCH DICTIONARY", T_List },
[OBJECT_DATABASE] = "DATABASE",
[OBJECT_ROLE] = "ROLE",
[OBJECT_TSCONFIGURATION] = "TEXT SEARCH CONFIGURATION",
[OBJECT_TSDICTIONARY] = "TEXT SEARCH DICTIONARY",
/* When support for propagating comments to new objects is introduced, an entry for each
* statement type should be added to this list. The first element in each entry is the 'object_type' keyword
@ -66,7 +66,7 @@ DeparseCommentStmt(Node *node)
errmsg("unknown object type")));
}
const char *objectType = ObjectTypeInfos[stmt->objtype].name;
const char *objectType = ObjectTypeInfos[stmt->objtype];
char *comment = stmt->comment != NULL ? quote_literal_cstr(stmt->comment) : "NULL";

7
src/include/distributed/comment.h
View File

@ -15,13 +15,8 @@
#include "nodes/parsenodes.h"
typedef struct
{
char *name;
int type;
} ObjectTypeInfo;
extern const ObjectTypeInfo ObjectTypeInfos[];
extern const char *ObjectTypeInfos[];
extern List * GetCommentPropagationCommands(Oid oid, char *objectName, ObjectType