From b5d70d2e1175738d66dfafed71c07a9970826a50 Mon Sep 17 00:00:00 2001
From: Naisila Puka <37271756+naisila@users.noreply.github.com>
Date: Tue, 11 Oct 2022 16:31:24 +0300
Subject: [PATCH] Fix flakyness in alter_table_set_access_method (#6421)

We decrease verbosity level here to avoid the flaky output

https://app.circleci.com/pipelines/github/citusdata/citus/27936/workflows/dc63128a-1570-41a0-8722-08f3e3cfe301/jobs/836153

```diff
select alter_table_set_access_method('ref','heap');
 NOTICE:  creating a new table for alter_table_set_access_method.ref
 NOTICE:  moving the data of alter_table_set_access_method.ref
 NOTICE:  dropping the old alter_table_set_access_method.ref
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_ref
-drop cascades to view v_ref
+DETAIL:  drop cascades to view v_ref
+drop cascades to materialized view m_ref
 CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.ref CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.ref
  alter_table_set_access_method
 -------------------------------

 (1 row)
```
---
 .../alter_table_set_access_method.out         | 23 ++-----------------
 .../sql/alter_table_set_access_method.sql     |  3 +++
 2 files changed, 5 insertions(+), 21 deletions(-)

diff --git a/src/test/regress/expected/alter_table_set_access_method.out b/src/test/regress/expected/alter_table_set_access_method.out
index e95c8f686..5ff345c66 100644
--- a/src/test/regress/expected/alter_table_set_access_method.out
+++ b/src/test/regress/expected/alter_table_set_access_method.out
@@ -593,14 +593,12 @@ SELECT create_distributed_table('dist', 'a');
 INSERT INTO dist VALUES (7),(9);
 create materialized view m_dist as select * from dist;
 create view v_dist as select * from dist;
+\set VERBOSITY terse
 select alter_table_set_access_method('local','columnar');
 NOTICE:  creating a new table for alter_table_set_access_method.local
 NOTICE:  moving the data of alter_table_set_access_method.local
 NOTICE:  dropping the old alter_table_set_access_method.local
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_local
-drop cascades to view v_local
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.local CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.local
  alter_table_set_access_method
 ---------------------------------------------------------------------
@@ -612,9 +610,6 @@ NOTICE:  creating a new table for alter_table_set_access_method.ref
 NOTICE:  moving the data of alter_table_set_access_method.ref
 NOTICE:  dropping the old alter_table_set_access_method.ref
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_ref
-drop cascades to view v_ref
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.ref CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.ref
  alter_table_set_access_method
 ---------------------------------------------------------------------
@@ -626,9 +621,6 @@ NOTICE:  creating a new table for alter_table_set_access_method.dist
 NOTICE:  moving the data of alter_table_set_access_method.dist
 NOTICE:  dropping the old alter_table_set_access_method.dist
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_dist
-drop cascades to view v_dist
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.dist CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.dist
  alter_table_set_access_method
 ---------------------------------------------------------------------
@@ -640,9 +632,6 @@ NOTICE:  creating a new table for alter_table_set_access_method.dist
 NOTICE:  moving the data of alter_table_set_access_method.dist
 NOTICE:  dropping the old alter_table_set_access_method.dist
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_dist
-drop cascades to view v_dist
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.dist CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.dist
  alter_distributed_table
 ---------------------------------------------------------------------
@@ -654,9 +643,6 @@ NOTICE:  creating a new table for alter_table_set_access_method.local
 NOTICE:  moving the data of alter_table_set_access_method.local
 NOTICE:  dropping the old alter_table_set_access_method.local
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_local
-drop cascades to view v_local
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.local CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.local
  alter_table_set_access_method
 ---------------------------------------------------------------------
@@ -668,9 +654,6 @@ NOTICE:  creating a new table for alter_table_set_access_method.ref
 NOTICE:  moving the data of alter_table_set_access_method.ref
 NOTICE:  dropping the old alter_table_set_access_method.ref
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_ref
-drop cascades to view v_ref
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.ref CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.ref
  alter_table_set_access_method
 ---------------------------------------------------------------------
@@ -682,15 +665,13 @@ NOTICE:  creating a new table for alter_table_set_access_method.dist
 NOTICE:  moving the data of alter_table_set_access_method.dist
 NOTICE:  dropping the old alter_table_set_access_method.dist
 NOTICE:  drop cascades to 2 other objects
-DETAIL:  drop cascades to materialized view m_dist
-drop cascades to view v_dist
-CONTEXT:  SQL statement "DROP TABLE alter_table_set_access_method.dist CASCADE"
 NOTICE:  renaming the new table to alter_table_set_access_method.dist
  alter_table_set_access_method
 ---------------------------------------------------------------------
 
 (1 row)
 
+\set VERBOSITY default
 SELECT * FROM m_local;
  a | b | c
 ---------------------------------------------------------------------
diff --git a/src/test/regress/sql/alter_table_set_access_method.sql b/src/test/regress/sql/alter_table_set_access_method.sql
index 33d4de0d5..eb260210c 100644
--- a/src/test/regress/sql/alter_table_set_access_method.sql
+++ b/src/test/regress/sql/alter_table_set_access_method.sql
@@ -211,6 +211,7 @@ INSERT INTO dist VALUES (7),(9);
 create materialized view m_dist as select * from dist;
 create view v_dist as select * from dist;
 
+\set VERBOSITY terse
 
 select alter_table_set_access_method('local','columnar');
 select alter_table_set_access_method('ref','columnar');
@@ -222,6 +223,8 @@ select alter_table_set_access_method('local','heap');
 select alter_table_set_access_method('ref','heap');
 select alter_table_set_access_method('dist','heap');
 
+\set VERBOSITY default
+
 SELECT * FROM m_local;
 SELECT * FROM m_ref;
 SELECT * FROM m_dist;