external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes static code analysis issues

test_branch
gindibay 2023-07-29 20:23:07 +03:00
parent 4c3341e64b
commit b69c36af49
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/distributed/metadata/node_metadata.c
View File

@ -134,7 +134,7 @@ static void MarkNodesNotSyncedInLoopBackConnection(MetadataSyncContext *context,
static void EnsureParentSessionHasExclusiveLockOnPgDistNode(pid_t parentSessionPid); static void EnsureParentSessionHasExclusiveLockOnPgDistNode(pid_t parentSessionPid);
static void SetNodeMetadata(MetadataSyncContext *context, bool localOnly); static void SetNodeMetadata(MetadataSyncContext *context, bool localOnly);
static void EnsureTransactionalMetadataSyncMode(void); static void EnsureTransactionalMetadataSyncMode(void);
static void lock_shards_in_worker_placement_list(WorkerNode *workerNode, LOCKMODE static void LockShardsInWorkerPlacementList(WorkerNode *workerNode, LOCKMODE
lockMode); lockMode);
/* declarations for dynamic loading */ /* declarations for dynamic loading */
@ -1167,11 +1167,10 @@ ActivateNodeList(MetadataSyncContext *context)
* Adds locks into all shards placed into given workerNode. * Adds locks into all shards placed into given workerNode.
*/ */
void void
lock_shards_in_worker_placement_list(WorkerNode *workerNode, LOCKMODE lockMode) LockShardsInWorkerPlacementList(WorkerNode *workerNode, LOCKMODE lockMode)
{ {
List *placementList = NIL;
placementList = AllShardPlacementsOnNodeGroup(workerNode->groupId); List *placementList = AllShardPlacementsOnNodeGroup(workerNode->groupId);
LockShardsInPlacementListMetadata(placementList, lockMode); LockShardsInPlacementListMetadata(placementList, lockMode);
} }
@ -1296,7 +1295,7 @@ citus_update_node(PG_FUNCTION_ARGS)
} }
} }
lock_shards_in_worker_placement_list(workerNode, AccessExclusiveLock); LockShardsInWorkerPlacementList(workerNode, AccessExclusiveLock);
} }
/* /*
@ -1360,7 +1359,7 @@ citus_pause_node_within_txn(PG_FUNCTION_ARGS)
if (NodeIsPrimary(workerNode)) if (NodeIsPrimary(workerNode))
{ {
lock_shards_in_worker_placement_list(workerNode, AccessExclusiveLock); LockShardsInWorkerPlacementList(workerNode, AccessExclusiveLock);
} }
PG_RETURN_VOID(); PG_RETURN_VOID();