From b72bfa9f098961699d746462888dde5d415531f6 Mon Sep 17 00:00:00 2001
From: Jelte Fennema-Nio <github-tech@jeltef.nl>
Date: Mon, 25 Sep 2023 16:23:23 +0200
Subject: [PATCH] Remove && from script to avoid hiding errors

---
 .../upgrade/generate_citus_tarballs.sh          | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/test/regress/citus_tests/upgrade/generate_citus_tarballs.sh b/src/test/regress/citus_tests/upgrade/generate_citus_tarballs.sh
index f643e4819..a91f9964b 100755
--- a/src/test/regress/citus_tests/upgrade/generate_citus_tarballs.sh
+++ b/src/test/regress/citus_tests/upgrade/generate_citus_tarballs.sh
@@ -22,17 +22,26 @@ git clone --branch "$citus_version" https://github.com/citusdata/citus.git --dep
 builddir="${basedir}/build"
 
 # do everything in a subdirectory to avoid clutter in current directory
-mkdir -p "${builddir}" && cd "${builddir}"
+mkdir -p "${builddir}"
+cd "${builddir}"
 
 "${citus_dir}/configure" --without-libcurl
 
 installdir="${builddir}/install"
-make "-j$(nproc)" && mkdir -p "${installdir}" && make DESTDIR="${installdir}" install
+make "-j$(nproc)"
+mkdir -p "${installdir}"
+make DESTDIR="${installdir}" install
 
-cd "${installdir}" && find . -type f -print >"${builddir}/files.lst"
+cd "${installdir}"
+
+find . -type f -print >"${builddir}/files.lst"
+
+cd "${builddir}"
 
 tar cvf "${basedir}/install-pg${pg_version}-citus${citus_version}.tar" $(cat "${builddir}"/files.lst)
 mv "${basedir}/install-pg${pg_version}-citus${citus_version}.tar" "${base}/install-pg${pg_version}-citus${citus_version}.tar"
 
-cd "${builddir}" && rm -rf install files.lst && make clean
+cd "${builddir}"
+rm -rf install files.lst
+make clean