external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Drop function in the tests on a never version 

As dropping the function now relies on pg_dist_object, which exists with 9.0+
pull/5749/head
Onder Kalaci 2022-03-01 18:10:27 +01:00 committed by Önder Kalacı
parent a4133c69e8
commit b79a0052a4
2 changed files with 57 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

111
src/test/regress/expected/multi_extension.out
View File

@ -428,20 +428,20 @@ SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDE
ALTER EXTENSION citus UPDATE TO '9.4-2'; ALTER EXTENSION citus UPDATE TO '9.4-2';
-- should see the old source code -- should see the old source code
SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1; SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1;
prosrc prosrc
--------------------------------------------------------------------- ---------------------------------------------------------------------
+ +
DECLARE + DECLARE +
colocated_tables regclass[]; + colocated_tables regclass[]; +
BEGIN + BEGIN +
SELECT get_colocated_table_array(relation) INTO colocated_tables;+ SELECT get_colocated_table_array(relation) INTO colocated_tables;+
PERFORM + PERFORM +
master_update_shard_statistics(shardid) + master_update_shard_statistics(shardid) +
FROM + FROM +
pg_dist_shard + pg_dist_shard +
WHERE + WHERE +
logicalrelid = ANY (colocated_tables); + logicalrelid = ANY (colocated_tables); +
END; + END; +
(1 row) (1 row)
@ -469,20 +469,20 @@ SELECT * FROM multi_extension.print_extension_changes();
ALTER EXTENSION citus UPDATE TO '9.4-1'; ALTER EXTENSION citus UPDATE TO '9.4-1';
-- should see the old source code -- should see the old source code
SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1; SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1;
prosrc prosrc
--------------------------------------------------------------------- ---------------------------------------------------------------------
+ +
DECLARE + DECLARE +
colocated_tables regclass[]; + colocated_tables regclass[]; +
BEGIN + BEGIN +
SELECT get_colocated_table_array(relation) INTO colocated_tables;+ SELECT get_colocated_table_array(relation) INTO colocated_tables;+
PERFORM + PERFORM +
master_update_shard_statistics(shardid) + master_update_shard_statistics(shardid) +
FROM + FROM +
pg_dist_shard + pg_dist_shard +
WHERE + WHERE +
logicalrelid = ANY (colocated_tables); + logicalrelid = ANY (colocated_tables); +
END; + END; +
(1 row) (1 row)
@ -578,20 +578,20 @@ SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDE
ALTER EXTENSION citus UPDATE TO '9.5-2'; ALTER EXTENSION citus UPDATE TO '9.5-2';
-- should see the old source code -- should see the old source code
SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1; SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1;
prosrc prosrc
--------------------------------------------------------------------- ---------------------------------------------------------------------
+ +
DECLARE + DECLARE +
colocated_tables regclass[]; + colocated_tables regclass[]; +
BEGIN + BEGIN +
SELECT get_colocated_table_array(relation) INTO colocated_tables;+ SELECT get_colocated_table_array(relation) INTO colocated_tables;+
PERFORM + PERFORM +
master_update_shard_statistics(shardid) + master_update_shard_statistics(shardid) +
FROM + FROM +
pg_dist_shard + pg_dist_shard +
WHERE + WHERE +
logicalrelid = ANY (colocated_tables); + logicalrelid = ANY (colocated_tables); +
END; + END; +
(1 row) (1 row)
@ -619,20 +619,20 @@ SELECT * FROM multi_extension.print_extension_changes();
ALTER EXTENSION citus UPDATE TO '9.5-1'; ALTER EXTENSION citus UPDATE TO '9.5-1';
-- should see the old source code -- should see the old source code
SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1; SELECT prosrc FROM pg_proc WHERE proname = 'master_update_table_statistics' ORDER BY 1;
prosrc prosrc
--------------------------------------------------------------------- ---------------------------------------------------------------------
+ +
DECLARE + DECLARE +
colocated_tables regclass[]; + colocated_tables regclass[]; +
BEGIN + BEGIN +
SELECT get_colocated_table_array(relation) INTO colocated_tables;+ SELECT get_colocated_table_array(relation) INTO colocated_tables;+
PERFORM + PERFORM +
master_update_shard_statistics(shardid) + master_update_shard_statistics(shardid) +
FROM + FROM +
pg_dist_shard + pg_dist_shard +
WHERE + WHERE +
logicalrelid = ANY (colocated_tables); + logicalrelid = ANY (colocated_tables); +
END; + END; +
(1 row) (1 row)
@ -1115,8 +1115,7 @@ HINT: Use DROP FUNCTION relation_is_a_known_shard(regclass) first.
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
-- This will fail because of previous function declaration -- This will fail because of previous function declaration
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
NOTICE: version "8.1-1" of extension "citus" is already installed
-- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on -- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on
SET citus.enable_version_checks TO 'true'; SET citus.enable_version_checks TO 'true';
SET columnar.enable_version_checks TO 'true'; SET columnar.enable_version_checks TO 'true';
@ -1125,8 +1124,8 @@ ERROR: cannot drop function relation_is_a_known_shard(regclass) because extensi
HINT: You can drop extension citus instead. HINT: You can drop extension citus instead.
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
NOTICE: version "8.1-1" of extension "citus" is already installed NOTICE: version "9.1-1" of extension "citus" is already installed
-- Test updating to the latest version without specifying the version number -- Test updating to the latest version without specifying the version number
ALTER EXTENSION citus UPDATE; ALTER EXTENSION citus UPDATE;
-- re-create in newest version -- re-create in newest version

4
src/test/regress/sql/multi_extension.sql
View File

@ -526,7 +526,7 @@ $function$;
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
-- This will fail because of previous function declaration -- This will fail because of previous function declaration
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
-- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on -- We can DROP problematic function and continue ALTER EXTENSION even when version checks are on
SET citus.enable_version_checks TO 'true'; SET citus.enable_version_checks TO 'true';
@ -535,7 +535,7 @@ DROP FUNCTION pg_catalog.relation_is_a_known_shard(regclass);
SET citus.enable_version_checks TO 'false'; SET citus.enable_version_checks TO 'false';
SET columnar.enable_version_checks TO 'false'; SET columnar.enable_version_checks TO 'false';
ALTER EXTENSION citus UPDATE TO '8.1-1'; ALTER EXTENSION citus UPDATE TO '9.1-1';
-- Test updating to the latest version without specifying the version number -- Test updating to the latest version without specifying the version number
ALTER EXTENSION citus UPDATE; ALTER EXTENSION citus UPDATE;