external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change GUC propagation flag's default value to off (#6516) 

This PR changes
```citus.propagate_session_settings_for_loopback_connection``` default
value to off not to expose this feature publicly at this point. See
#6488 for details.
pull/6523/head
Gokhan Gulbiz 2022-11-29 13:25:53 +03:00 committed by GitHub
parent e12d97def2
commit bc118ee551
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/distributed/shared_library_init.c
View File

@ -1992,7 +1992,7 @@ RegisterCitusConfigVariables(void)
"When enabled, rebalancer propagates all the allowed GUC settings to new connections."), "When enabled, rebalancer propagates all the allowed GUC settings to new connections."),
NULL, NULL,
&PropagateSessionSettingsForLoopbackConnection, &PropagateSessionSettingsForLoopbackConnection,
true, false,
PGC_USERSET, PGC_USERSET,
GUC_NO_SHOW_ALL, GUC_NO_SHOW_ALL,
NULL, NULL, NULL); NULL, NULL, NULL);

9
src/test/regress/expected/shard_rebalancer.out
View File

@ -2,6 +2,7 @@
-- MUTLI_SHARD_REBALANCER -- MUTLI_SHARD_REBALANCER
-- --
SET citus.next_shard_id TO 433000; SET citus.next_shard_id TO 433000;
SET citus.propagate_session_settings_for_loopback_connection TO ON;
CREATE TABLE ref_table_test(a int primary key); CREATE TABLE ref_table_test(a int primary key);
SELECT create_reference_table('ref_table_test'); SELECT create_reference_table('ref_table_test');
create_reference_table create_reference_table
@ -214,6 +215,8 @@ NOTICE: issuing SET LOCAL citus.next_shard_id TO '433105';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000'; NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.propagate_session_settings_for_loopback_connection TO 'on';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_count TO '4'; NOTICE: issuing SET LOCAL citus.shard_count TO '4';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2'; NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2';
@ -235,6 +238,8 @@ NOTICE: issuing SET LOCAL citus.next_shard_id TO '433105';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000'; NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.propagate_session_settings_for_loopback_connection TO 'on';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_count TO '4'; NOTICE: issuing SET LOCAL citus.shard_count TO '4';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2'; NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2';
@ -256,6 +261,8 @@ NOTICE: issuing SET LOCAL citus.next_shard_id TO '433105';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000'; NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.propagate_session_settings_for_loopback_connection TO 'on';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_count TO '4'; NOTICE: issuing SET LOCAL citus.shard_count TO '4';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2'; NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2';
@ -277,6 +284,8 @@ NOTICE: issuing SET LOCAL citus.next_shard_id TO '433105';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000'; NOTICE: issuing SET LOCAL citus.node_connection_timeout TO '35000';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.propagate_session_settings_for_loopback_connection TO 'on';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_count TO '4'; NOTICE: issuing SET LOCAL citus.shard_count TO '4';
DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx DETAIL: on server postgres@localhost:xxxxx connectionId: xxxxxxx
NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2'; NOTICE: issuing SET LOCAL citus.shard_replication_factor TO '2';

1
src/test/regress/sql/shard_rebalancer.sql
View File

@ -3,6 +3,7 @@
-- --
SET citus.next_shard_id TO 433000; SET citus.next_shard_id TO 433000;
SET citus.propagate_session_settings_for_loopback_connection TO ON;
CREATE TABLE ref_table_test(a int primary key); CREATE TABLE ref_table_test(a int primary key);
SELECT create_reference_table('ref_table_test'); SELECT create_reference_table('ref_table_test');