external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes PostprocessCreateDatabaseStmt comment

create_drop_db_gh
gindibay 2023-10-09 20:01:29 +03:00
parent b04c52abb9
commit be9f660fad
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/distributed/commands/database.c
View File

@ -287,9 +287,10 @@ PreprocessAlterDatabaseSetStmt(Node *node, const char *queryString,
/* /*
* PostprocessCreatedbStmt creates the plan to synchronize CREATE DATABASE * PostprocessCreatedbStmt is executed after the statement is applied to the local
* across nodes. We use the cannotBeExecutedInTransaction option to avoid * postgres instance. In this stage we can prepare the commands that need to be run on
* sending transaction blocks. * all workers to create the database.
*
*/ */
List * List *
PostprocessCreateDatabaseStmt(Node *node, const char *queryString) PostprocessCreateDatabaseStmt(Node *node, const char *queryString)
@ -381,10 +382,7 @@ citus_internal_database_command(PG_FUNCTION_ARGS)
{ {
createdb(NULL, (CreatedbStmt *) parseTree); createdb(NULL, (CreatedbStmt *) parseTree);
} }
else
{
/* TODO: check database properties */
}
} }
else if (IsA(parseTree, DropdbStmt)) else if (IsA(parseTree, DropdbStmt))
{ {
@ -393,14 +391,10 @@ citus_internal_database_command(PG_FUNCTION_ARGS)
bool missingOk = false; bool missingOk = false;
Oid databaseOid = get_database_oid(stmt->dbname, missingOk); Oid databaseOid = get_database_oid(stmt->dbname, missingOk);
if (!OidIsValid(databaseOid))
{ if(OidIsValid(databaseOid))
/* already dropped? */
}
else
{ {
/* / * remove database from database shards * / */ /* / * remove database from database shards * / */
/* DeleteDatabaseShardByDatabaseIdLocally(databaseOid); */
DropDatabase(NULL, (DropdbStmt *) parseTree); DropDatabase(NULL, (DropdbStmt *) parseTree);
} }
@ -409,7 +403,7 @@ citus_internal_database_command(PG_FUNCTION_ARGS)
{ {
ereport(ERROR, (errmsg("unsupported command type %d", nodeTag(parseTree)))); ereport(ERROR, (errmsg("unsupported command type %d", nodeTag(parseTree))));
} }
/* Below command rollbacks flags to the state before this session*/
AtEOXact_GUC(true, saveNestLevel); AtEOXact_GUC(true, saveNestLevel);
PG_RETURN_VOID(); PG_RETURN_VOID();