external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Create a new colocation properly after braking one 

When braking a colocation, we need to create a new colocation group
record in pg_dist_colocation for the relation. It is not sufficient to
have a new colocationid value in pg_dist_partition only.

This patch also fixes a bug when deleting a colocation group if no
tables are left in it. Previously we passed a relation id as a parameter
to DeleteColocationGroupIfNoTablesBelong function, where we should have
passed a colocation id.
pull/6929/head
Hanefi Onaldi 2023-05-17 16:19:56 +03:00
parent bdf085eabb
commit c22547d221
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/distributed/utils/colocation_utils.c
View File

@ -175,12 +175,11 @@ BreakColocation(Oid sourceRelationId)
*/ */
Relation pgDistColocation = table_open(DistColocationRelationId(), ExclusiveLock); Relation pgDistColocation = table_open(DistColocationRelationId(), ExclusiveLock);
uint32 newColocationId = GetNextColocationId(); uint32 oldColocationId = TableColocationId(sourceRelationId);
bool localOnly = false; CreateColocationGroupForRelation(sourceRelationId);
UpdateRelationColocationGroup(sourceRelationId, newColocationId, localOnly);
/* if there is not any remaining table in the colocation group, delete it */ /* if there is not any remaining table in the old colocation group, delete it */
DeleteColocationGroupIfNoTablesBelong(sourceRelationId); DeleteColocationGroupIfNoTablesBelong(oldColocationId);
table_close(pgDistColocation, NoLock); table_close(pgDistColocation, NoLock);
} }